mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
140 lines
4.4 KiB
TypeScript
140 lines
4.4 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { parseLookmlPullConfig, pullConfigFromIntegrationConfig } from '../../../../../src/context/ingest/adapters/lookml/pull-config.js';
|
|
|
|
describe('lookml pull config', () => {
|
|
it('parses a minimal valid config with defaulted branch', () => {
|
|
const config = parseLookmlPullConfig({ repoUrl: 'https://github.com/acme/r.git' });
|
|
expect(config.repoUrl).toBe('https://github.com/acme/r.git');
|
|
expect(config.branch).toBe('main');
|
|
expect(config.path).toBeNull();
|
|
expect(config.authToken).toBeNull();
|
|
expect(config.expectedLookerConnectionName).toBeNull();
|
|
expect(config.parsedTargetTables).toEqual({});
|
|
});
|
|
|
|
it('defaults expectedLookerConnectionName and parsedTargetTables for LookML pulls', () => {
|
|
const config = parseLookmlPullConfig({ repoUrl: 'https://github.com/acme/r.git' });
|
|
|
|
expect(config.expectedLookerConnectionName).toBeNull();
|
|
expect(config.parsedTargetTables).toEqual({});
|
|
});
|
|
|
|
it('parses a fully specified config', () => {
|
|
const config = parseLookmlPullConfig({
|
|
repoUrl: 'https://gitlab.com/team/proj.git',
|
|
branch: 'develop',
|
|
path: 'views',
|
|
authToken: 'glpat-xyz',
|
|
});
|
|
expect(config).toEqual({
|
|
repoUrl: 'https://gitlab.com/team/proj.git',
|
|
branch: 'develop',
|
|
path: 'views',
|
|
authToken: 'glpat-xyz',
|
|
expectedLookerConnectionName: null,
|
|
parsedTargetTables: {},
|
|
});
|
|
});
|
|
|
|
it('parses the validation-only expected connection and parsed target table map', () => {
|
|
const config = parseLookmlPullConfig({
|
|
repoUrl: 'https://github.com/acme/r.git',
|
|
expectedLookerConnectionName: 'b2b_sandbox_bq',
|
|
parsedTargetTables: {
|
|
'b2b.orders': {
|
|
ok: true,
|
|
catalog: 'proj',
|
|
schema: 'analytics',
|
|
name: 'orders',
|
|
canonicalTable: 'proj.analytics.orders',
|
|
},
|
|
'b2b.derived': {
|
|
ok: false,
|
|
reason: 'derived_table_not_supported',
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(config.expectedLookerConnectionName).toBe('b2b_sandbox_bq');
|
|
expect(config.parsedTargetTables['b2b.orders']).toEqual({
|
|
ok: true,
|
|
catalog: 'proj',
|
|
schema: 'analytics',
|
|
name: 'orders',
|
|
canonicalTable: 'proj.analytics.orders',
|
|
});
|
|
expect(config.parsedTargetTables['b2b.derived']).toEqual({
|
|
ok: false,
|
|
reason: 'derived_table_not_supported',
|
|
});
|
|
});
|
|
|
|
it('rejects a non-URL repoUrl', () => {
|
|
expect(() => parseLookmlPullConfig({ repoUrl: 'not-a-url' })).toThrow();
|
|
});
|
|
|
|
it('rejects a missing repoUrl', () => {
|
|
expect(() => parseLookmlPullConfig({ branch: 'main' })).toThrow();
|
|
});
|
|
|
|
it('pullConfigFromIntegrationConfig extracts the adapter-visible fields', () => {
|
|
const integration = {
|
|
pullEnabled: true,
|
|
repoUrl: 'https://github.com/acme/r.git',
|
|
branch: 'main',
|
|
path: 'models',
|
|
authToken: 'ghp_x',
|
|
pullSchedule: 'daily' as const,
|
|
nextPullAt: '2026-05-01T00:00:00.000Z',
|
|
lastPulledAt: null,
|
|
lastCommitHash: null,
|
|
};
|
|
expect(pullConfigFromIntegrationConfig(integration)).toEqual({
|
|
repoUrl: 'https://github.com/acme/r.git',
|
|
branch: 'main',
|
|
path: 'models',
|
|
authToken: 'ghp_x',
|
|
expectedLookerConnectionName: null,
|
|
parsedTargetTables: {},
|
|
});
|
|
});
|
|
|
|
it('pullConfigFromIntegrationConfig forwards the expected connection name', () => {
|
|
const integration = {
|
|
pullEnabled: true,
|
|
repoUrl: 'https://github.com/acme/r.git',
|
|
branch: 'main',
|
|
path: 'models',
|
|
authToken: 'ghp_x',
|
|
pullSchedule: 'daily' as const,
|
|
nextPullAt: '2026-05-01T00:00:00.000Z',
|
|
lastPulledAt: null,
|
|
lastCommitHash: null,
|
|
expectedLookerConnectionName: 'warehouse_bq',
|
|
};
|
|
|
|
expect(pullConfigFromIntegrationConfig(integration)).toEqual({
|
|
repoUrl: 'https://github.com/acme/r.git',
|
|
branch: 'main',
|
|
path: 'models',
|
|
authToken: 'ghp_x',
|
|
expectedLookerConnectionName: 'warehouse_bq',
|
|
parsedTargetTables: {},
|
|
});
|
|
});
|
|
|
|
it('pullConfigFromIntegrationConfig throws when repoUrl is null', () => {
|
|
const integration = {
|
|
pullEnabled: false,
|
|
repoUrl: null,
|
|
branch: null,
|
|
path: null,
|
|
authToken: null,
|
|
pullSchedule: null,
|
|
nextPullAt: null,
|
|
lastPulledAt: null,
|
|
lastCommitHash: null,
|
|
};
|
|
expect(() => pullConfigFromIntegrationConfig(integration)).toThrow(/repoUrl/);
|
|
});
|
|
});
|