ktx/packages/cli/test/context/ingest/adapters/lookml/parse.test.ts
Andrey Avtomonov 56985b7e09
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract

* test(cli): keep dialect edge tests focused

* fix(cli): stabilize dialect contract foundation

* refactor(connectors): own read-only query preparation

* refactor(connectors): resolve dialects through registry

* refactor(connectors): keep concrete dialect classes internal

* chore(workspace): enforce dialect import boundary

* refactor(cli): resolve relationship dialect at scan boundary

* refactor(cli): use dialect display parsing for entity details

* refactor(cli): use dialect display parsing for warehouse catalog

* refactor(cli): use dialect SQL in relationship workflows

* test(cli): verify solid dialect scan workflow closure

* test: split cli tests from source tree

* refactor(cli): standardize BigQuery scope listing

* feat(sqlite): implement connector scope listing

* test(connectors): cover required table listing

* feat(cli): add warehouse driver registry

* refactor(setup): route scope discovery through driver registry

* refactor(cli): route local query execution through driver registry

* refactor(historic-sql): route dialect support through driver registry

* refactor(cli): test warehouse connections through driver registry

* fix(cli): close driver registry type export gaps

* Improve setup daemon diagnostics

* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback

Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.

* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match

The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.

Align the picker boundary with the canonical 3-level KtxTableRef:

- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
  resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
  (resolveEnabledTables already accepts the 3-part shape) and
  schemasFromEnabledTables now goes through parseDottedTableEntry so it
  recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
  reuse.

Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).

* fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00

166 lines
4.8 KiB
TypeScript

import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import { parseLookmlStagedDir } from '../../../../../src/context/ingest/adapters/lookml/parse.js';
describe('parseLookmlStagedDir', () => {
let stagedDir: string;
beforeEach(async () => {
stagedDir = await mkdtemp(join(tmpdir(), 'lkml-parse-'));
});
afterEach(async () => rm(stagedDir, { recursive: true, force: true }));
it('parses a single view file and reports it under views with a relative path', async () => {
await writeFile(
join(stagedDir, 'customers.view.lkml'),
`view: customers {
dimension: id {
type: number
primary_key: yes
sql: \${TABLE}.id ;;
}
}
`,
'utf-8',
);
const result = await parseLookmlStagedDir(stagedDir);
expect(result.views.map((v) => v.path)).toEqual(['customers.view.lkml']);
expect(result.views[0].name).toBe('customers');
expect(result.models).toEqual([]);
expect(result.dashboards).toEqual([]);
});
it('parses a model file and extracts include globs', async () => {
await mkdir(join(stagedDir, 'views'), { recursive: true });
await writeFile(
join(stagedDir, 'orders.model.lkml'),
`connection: "my_bq"
include: "views/*.view.lkml"
explore: orders {}
`,
'utf-8',
);
await writeFile(
join(stagedDir, 'views', 'orders.view.lkml'),
`view: orders {
sql_table_name: public.orders ;;
}
`,
'utf-8',
);
const result = await parseLookmlStagedDir(stagedDir);
expect(result.models.map((m) => m.path)).toEqual(['orders.model.lkml']);
expect(result.models[0].name).toBe('orders');
expect(result.models[0].includes).toEqual(['views/*.view.lkml']);
expect(result.models[0].explores).toEqual(['orders']);
expect(result.views.map((v) => v.path)).toEqual(['views/orders.view.lkml']);
});
it('extracts model connection names and raw view sql_table_name declarations', async () => {
await mkdir(join(stagedDir, 'views'), { recursive: true });
await writeFile(
join(stagedDir, 'b2b.model.lkml'),
`connection: "b2b_sandbox_bq"
include: "views/*.view.lkml"
explore: orders {}
`,
'utf-8',
);
await writeFile(
join(stagedDir, 'views', 'orders.view.lkml'),
`view: orders {
sql_table_name: analytics.orders AS o ;;
}
`,
'utf-8',
);
const result = await parseLookmlStagedDir(stagedDir);
expect(result.models[0]).toMatchObject({
path: 'b2b.model.lkml',
name: 'b2b',
connectionName: 'b2b_sandbox_bq',
});
expect(result.views[0]).toMatchObject({
path: 'views/orders.view.lkml',
name: 'orders',
rawSqlTableName: 'analytics.orders AS o',
});
});
it('captures extends declarations on views', async () => {
await writeFile(
join(stagedDir, 'base.view.lkml'),
`view: base {
dimension: id {
type: number
primary_key: yes
sql: \${TABLE}.id ;;
}
}
`,
'utf-8',
);
await writeFile(
join(stagedDir, 'orders.view.lkml'),
`view: orders {
extends: [base]
sql_table_name: public.orders ;;
}
`,
'utf-8',
);
const result = await parseLookmlStagedDir(stagedDir);
const orders = result.views.find((v) => v.name === 'orders');
expect(orders).toBeDefined();
if (!orders) {
throw new Error('expected orders view');
}
expect(orders.extendsFrom).toEqual(['base']);
});
it('collects .dashboard.lkml files structurally (no deep parsing)', async () => {
await writeFile(join(stagedDir, 'overview.dashboard.lkml'), '- dashboard: overview\n title: Overview\n', 'utf-8');
const result = await parseLookmlStagedDir(stagedDir);
expect(result.dashboards.map((d) => d.path)).toEqual(['overview.dashboard.lkml']);
expect(result.dashboards[0].name).toBe('overview');
});
it('ignores non-.lkml files', async () => {
await writeFile(join(stagedDir, 'README.md'), '# readme\n', 'utf-8');
await writeFile(join(stagedDir, 'notes.txt'), 'note\n', 'utf-8');
const result = await parseLookmlStagedDir(stagedDir);
expect(result.models).toEqual([]);
expect(result.views).toEqual([]);
expect(result.dashboards).toEqual([]);
});
it('returns a sorted deterministic order across runs', async () => {
await writeFile(
join(stagedDir, 'zeta.view.lkml'),
`view: zeta {
}
`,
'utf-8',
);
await writeFile(
join(stagedDir, 'alpha.view.lkml'),
`view: alpha {
}
`,
'utf-8',
);
const r1 = await parseLookmlStagedDir(stagedDir);
const r2 = await parseLookmlStagedDir(stagedDir);
expect(r1.views.map((v) => v.path)).toEqual(['alpha.view.lkml', 'zeta.view.lkml']);
expect(r2.views.map((v) => v.path)).toEqual(r1.views.map((v) => v.path));
});
});