mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
72 lines
2.7 KiB
TypeScript
72 lines
2.7 KiB
TypeScript
import { mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { makeLocalGitRepo } from '../../../test/make-local-git-repo.js';
|
|
import { LOOKML_FETCH_REPORT_FILE } from '../../../../../src/context/ingest/adapters/lookml/fetch-report.js';
|
|
import { LookmlSourceAdapter } from '../../../../../src/context/ingest/adapters/lookml/lookml.adapter.js';
|
|
|
|
describe('LookmlSourceAdapter validation sidecars', () => {
|
|
let tmpRoot: string;
|
|
|
|
beforeEach(async () => {
|
|
tmpRoot = await mkdtemp(join(tmpdir(), 'lookml-adapter-'));
|
|
});
|
|
|
|
afterEach(async () => rm(tmpRoot, { recursive: true, force: true }));
|
|
|
|
it('returns configured target warehouse connection ids', async () => {
|
|
const adapter = new LookmlSourceAdapter({
|
|
homeDir: join(tmpRoot, 'home'),
|
|
targetConnectionIds: ['warehouse', 'analytics', 'warehouse'],
|
|
});
|
|
|
|
await expect(adapter.listTargetConnectionIds?.(join(tmpRoot, 'staged'))).resolves.toEqual([
|
|
'analytics',
|
|
'warehouse',
|
|
]);
|
|
});
|
|
|
|
it('writes a partial fetch report and marks mismatched chunks as SL-disallowed', async () => {
|
|
const originRoot = join(tmpRoot, 'origin-src');
|
|
await mkdir(join(originRoot, 'views'), { recursive: true });
|
|
await writeFile(
|
|
join(originRoot, 'b2b.model.lkml'),
|
|
'connection: "wrong_connection"\ninclude: "views/*.view.lkml"\nexplore: orders {}\n',
|
|
'utf-8',
|
|
);
|
|
await writeFile(
|
|
join(originRoot, 'views', 'orders.view.lkml'),
|
|
'view: orders { sql_table_name: public.orders ;; }\n',
|
|
'utf-8',
|
|
);
|
|
const repo = await makeLocalGitRepo(originRoot, join(tmpRoot, 'origin'));
|
|
const stagedDir = join(tmpRoot, 'staged');
|
|
await mkdir(stagedDir, { recursive: true });
|
|
|
|
const adapter = new LookmlSourceAdapter({ homeDir: join(tmpRoot, 'home') });
|
|
await adapter.fetch(
|
|
{
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: null,
|
|
authToken: null,
|
|
expectedLookerConnectionName: 'expected_connection',
|
|
},
|
|
stagedDir,
|
|
{ connectionId: '11111111-1111-4111-8111-111111111111', sourceKey: 'lookml' },
|
|
);
|
|
|
|
await expect(readFile(join(stagedDir, LOOKML_FETCH_REPORT_FILE), 'utf-8')).resolves.toContain(
|
|
'lookml_connection_mismatch',
|
|
);
|
|
await expect(adapter.readFetchReport(stagedDir)).resolves.toMatchObject({ status: 'partial' });
|
|
|
|
const chunks = await adapter.chunk(stagedDir);
|
|
expect(chunks.workUnits[0]).toMatchObject({
|
|
unitKey: 'lookml-b2b',
|
|
slDisallowed: true,
|
|
slDisallowedReason: 'lookml_connection_mismatch',
|
|
});
|
|
});
|
|
});
|