mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-16 08:25:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
125 lines
4.5 KiB
TypeScript
125 lines
4.5 KiB
TypeScript
import { mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import type { LookerRuntimeClient } from '../../../../../src/context/ingest/adapters/looker/fetch.js';
|
|
import { LookerSourceAdapter } from '../../../../../src/context/ingest/adapters/looker/looker.adapter.js';
|
|
|
|
const connectionId = '11111111-1111-4111-8111-111111111111';
|
|
|
|
function makeClient(): LookerRuntimeClient {
|
|
return {
|
|
listDashboards: vi.fn().mockResolvedValue([]),
|
|
getDashboard: vi.fn(),
|
|
listLooks: vi.fn().mockResolvedValue([]),
|
|
getLook: vi.fn(),
|
|
listFolders: vi.fn().mockResolvedValue({ folders: [] }),
|
|
listUsers: vi.fn().mockResolvedValue([]),
|
|
listGroups: vi.fn().mockResolvedValue([]),
|
|
listLookmlModels: vi.fn().mockResolvedValue({
|
|
models: [{ name: 'b2b', label: 'B2B', explores: [{ name: 'sales_pipeline', label: 'Sales Pipeline' }] }],
|
|
}),
|
|
getExplore: vi.fn().mockResolvedValue({
|
|
modelName: 'b2b',
|
|
exploreName: 'sales_pipeline',
|
|
label: 'Sales Pipeline',
|
|
description: null,
|
|
fields: { dimensions: [], measures: [] },
|
|
joins: [],
|
|
}),
|
|
};
|
|
}
|
|
|
|
describe('LookerSourceAdapter', () => {
|
|
let stagedDir: string;
|
|
|
|
beforeEach(async () => {
|
|
stagedDir = await mkdtemp(join(tmpdir(), 'looker-adapter-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(stagedDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('exposes source="looker" and skillNames=["looker_ingest"]', () => {
|
|
const adapter = new LookerSourceAdapter({ clientFactory: { createClient: () => makeClient() } });
|
|
expect(adapter.source).toBe('looker');
|
|
expect(adapter.skillNames).toEqual(['looker_ingest']);
|
|
});
|
|
|
|
it('enables context evidence indexing and delegates triage signals', async () => {
|
|
const adapter = new LookerSourceAdapter({ clientFactory: { createClient: () => makeClient() } });
|
|
|
|
expect(adapter.evidenceIndexing).toBe('documents');
|
|
expect(adapter.triageSupported).toBe(true);
|
|
await expect(adapter.getTriageSignals?.(stagedDir, 'looker:dashboard:10')).resolves.toMatchObject({
|
|
objectType: 'looker_dashboard',
|
|
});
|
|
});
|
|
|
|
it('fetches, detects, and chunks a runtime bundle through the composed adapter', async () => {
|
|
const adapter = new LookerSourceAdapter({
|
|
clientFactory: { createClient: vi.fn().mockResolvedValue(makeClient()) },
|
|
now: () => new Date('2026-04-30T12:30:00.000Z'),
|
|
});
|
|
|
|
await mkdir(stagedDir, { recursive: true });
|
|
await adapter.fetch({ lookerConnectionId: connectionId }, stagedDir, { connectionId, sourceKey: 'looker' });
|
|
|
|
expect(await adapter.detect(stagedDir)).toBe(true);
|
|
expect(await readFile(join(stagedDir, 'explores/b2b/sales_pipeline.json'), 'utf-8')).toContain('sales_pipeline');
|
|
|
|
const result = await adapter.chunk(stagedDir);
|
|
expect(result.workUnits.map((wu) => wu.unitKey)).toEqual(['looker-explore-b2b-sales_pipeline']);
|
|
});
|
|
|
|
it('passes pull success notifications to the server callback', async () => {
|
|
const onPullSucceeded = vi.fn().mockResolvedValue(undefined);
|
|
const adapter = new LookerSourceAdapter({
|
|
clientFactory: { createClient: () => makeClient() },
|
|
onPullSucceeded,
|
|
});
|
|
const completedAt = new Date('2026-04-30T12:00:00.000Z');
|
|
|
|
await adapter.onPullSucceeded({
|
|
connectionId,
|
|
sourceKey: 'looker',
|
|
syncId: 'sync-1',
|
|
trigger: 'scheduled_pull',
|
|
completedAt,
|
|
stagedDir: '/tmp/staged',
|
|
});
|
|
|
|
expect(onPullSucceeded).toHaveBeenCalledWith({
|
|
connectionId,
|
|
sourceKey: 'looker',
|
|
syncId: 'sync-1',
|
|
trigger: 'scheduled_pull',
|
|
completedAt,
|
|
stagedDir: '/tmp/staged',
|
|
});
|
|
});
|
|
|
|
it('describes incremental fetch scope from the staged scope file', async () => {
|
|
await mkdir(join(stagedDir, 'dashboards'), { recursive: true });
|
|
await writeFile(
|
|
join(stagedDir, 'looker-scope.json'),
|
|
JSON.stringify(
|
|
{
|
|
mode: 'incremental',
|
|
knownCurrentRawPaths: ['dashboards/10.json', 'dashboards/11.json'],
|
|
fetchedRawPaths: ['dashboards/11.json'],
|
|
},
|
|
null,
|
|
2,
|
|
),
|
|
);
|
|
const adapter = new LookerSourceAdapter({ clientFactory: { createClient: () => makeClient() } });
|
|
|
|
const scope = await adapter.describeScope(stagedDir);
|
|
|
|
expect(scope.isPathInScope('dashboards/10.json')).toBe(false);
|
|
expect(scope.isPathInScope('dashboards/11.json')).toBe(true);
|
|
expect(scope.isPathInScope('dashboards/12.json')).toBe(true);
|
|
});
|
|
});
|