mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
111 lines
3.8 KiB
TypeScript
111 lines
3.8 KiB
TypeScript
import { mkdtemp, readdir, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { describe, expect, it, vi } from 'vitest';
|
|
import { tableRefSet, type KtxTableRefKey } from '../../../../../src/context/scan/table-ref.js';
|
|
import { LiveDatabaseSourceAdapter } from '../../../../../src/context/ingest/adapters/live-database/live-database.adapter.js';
|
|
|
|
describe('LiveDatabaseSourceAdapter', () => {
|
|
it('fetches a schema snapshot through the introspection port', async () => {
|
|
const extractSchema = vi.fn().mockResolvedValue({
|
|
connectionId: 'conn-1',
|
|
driver: 'postgres',
|
|
extractedAt: '2026-04-27T00:00:00.000Z',
|
|
scope: { schemas: ['public'] },
|
|
metadata: {},
|
|
tables: [
|
|
{
|
|
name: 'orders',
|
|
catalog: null,
|
|
db: 'public',
|
|
kind: 'table',
|
|
comment: null,
|
|
estimatedRows: null,
|
|
columns: [
|
|
{
|
|
name: 'id',
|
|
nativeType: 'integer',
|
|
normalizedType: 'integer',
|
|
dimensionType: 'number',
|
|
nullable: false,
|
|
primaryKey: true,
|
|
comment: null,
|
|
},
|
|
],
|
|
foreignKeys: [],
|
|
},
|
|
],
|
|
});
|
|
const adapter = new LiveDatabaseSourceAdapter({
|
|
introspection: { extractSchema },
|
|
now: () => new Date('2026-04-27T00:00:00.000Z'),
|
|
});
|
|
const dir = await mkdtemp(join(tmpdir(), 'ktx-live-db-adapter-'));
|
|
|
|
await adapter.fetch(undefined, dir, { connectionId: 'conn-1', sourceKey: 'live-database' });
|
|
|
|
expect(extractSchema).toHaveBeenCalledWith('conn-1', { tableScope: undefined });
|
|
await expect(adapter.detect(dir)).resolves.toBe(true);
|
|
const chunked = await adapter.chunk(dir);
|
|
expect(chunked.workUnits.map((wu) => wu.unitKey)).toEqual(['live-database-public-orders']);
|
|
});
|
|
|
|
it('declares the live database source and skill', () => {
|
|
const adapter = new LiveDatabaseSourceAdapter({
|
|
introspection: { extractSchema: vi.fn() },
|
|
});
|
|
expect(adapter.source).toBe('live-database');
|
|
expect(adapter.skillNames).toEqual(['live_database_ingest']);
|
|
});
|
|
|
|
it('threads tableScope from fetch context into the introspection port without post-filtering', async () => {
|
|
const extractSchema = vi.fn(
|
|
async (_connectionId: string, _options?: { tableScope?: ReadonlySet<KtxTableRefKey> }) => ({
|
|
connectionId: 'warehouse',
|
|
driver: 'snowflake' as const,
|
|
extractedAt: '2026-05-22T00:00:00.000Z',
|
|
scope: {},
|
|
metadata: {},
|
|
tables: [
|
|
{
|
|
catalog: 'A',
|
|
db: 'MARTS',
|
|
name: 'IN_SCOPE',
|
|
kind: 'table' as const,
|
|
comment: null,
|
|
estimatedRows: 0,
|
|
columns: [],
|
|
foreignKeys: [],
|
|
},
|
|
{
|
|
catalog: 'A',
|
|
db: 'MARTS',
|
|
name: 'OUT_OF_SCOPE',
|
|
kind: 'table' as const,
|
|
comment: null,
|
|
estimatedRows: 0,
|
|
columns: [],
|
|
foreignKeys: [],
|
|
},
|
|
],
|
|
}),
|
|
);
|
|
const scope = tableRefSet([{ catalog: 'A', db: 'MARTS', name: 'IN_SCOPE' }]);
|
|
const adapter = new LiveDatabaseSourceAdapter({
|
|
introspection: { extractSchema },
|
|
});
|
|
const stagedDir = await mkdtemp(join(tmpdir(), 'ktx-livedb-scope-'));
|
|
try {
|
|
await adapter.fetch(undefined, stagedDir, {
|
|
connectionId: 'warehouse',
|
|
sourceKey: 'live-database',
|
|
tableScope: scope,
|
|
});
|
|
expect(extractSchema).toHaveBeenCalledWith('warehouse', { tableScope: scope });
|
|
const tables = await readdir(join(stagedDir, 'tables'));
|
|
expect(tables).toHaveLength(2);
|
|
} finally {
|
|
await rm(stagedDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|