mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
76 lines
2.7 KiB
TypeScript
76 lines
2.7 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
localConnectionInfoFromConfig,
|
|
localConnectionToWarehouseDescriptor,
|
|
localConnectionTypeForConfig,
|
|
} from '../../../src/context/connections/local-warehouse-descriptor.js';
|
|
|
|
describe('localConnectionToWarehouseDescriptor', () => {
|
|
it('maps local Postgres URLs to canonical warehouse descriptors', () => {
|
|
expect(
|
|
localConnectionToWarehouseDescriptor('warehouse', {
|
|
driver: 'postgres',
|
|
url: 'postgresql://readonly@db.example.test/analytics',
|
|
}),
|
|
).toMatchObject({
|
|
id: 'warehouse',
|
|
connection_type: 'POSTGRESQL',
|
|
host: 'db.example.test',
|
|
database: 'analytics',
|
|
});
|
|
});
|
|
|
|
it('maps BigQuery project and dataset from explicit fields', () => {
|
|
expect(
|
|
localConnectionToWarehouseDescriptor('bq', {
|
|
driver: 'bigquery',
|
|
project_id: 'acme',
|
|
dataset_id: 'warehouse',
|
|
}),
|
|
).toMatchObject({
|
|
id: 'bq',
|
|
connection_type: 'BIGQUERY',
|
|
project_id: 'acme',
|
|
dataset_id: 'warehouse',
|
|
});
|
|
});
|
|
|
|
it('returns null for non-warehouse adapters', () => {
|
|
expect(
|
|
localConnectionToWarehouseDescriptor('looker', {
|
|
driver: 'looker',
|
|
base_url: 'https://looker.example.com',
|
|
client_id: 'client',
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe('local connection info helpers', () => {
|
|
it('returns canonical warehouse connection types for local catalogs', () => {
|
|
expect(localConnectionTypeForConfig('warehouse', { driver: 'postgres' })).toBe('POSTGRESQL');
|
|
expect(localConnectionTypeForConfig('bq', { driver: 'bigquery', project_id: 'acme' })).toBe('BIGQUERY');
|
|
expect(localConnectionTypeForConfig('snowflake', { driver: 'snowflake' })).toBe('SNOWFLAKE');
|
|
});
|
|
|
|
it('keeps removed driver aliases as display-only labels', () => {
|
|
expect(localConnectionTypeForConfig('warehouse', { driver: 'postgresql' } as never)).toBe('postgresql');
|
|
expect(localConnectionTypeForConfig('warehouse', { driver: 'mssql' } as never)).toBe('mssql');
|
|
});
|
|
|
|
it('keeps non-warehouse adapter labels for display-only local connection surfaces', () => {
|
|
expect(localConnectionTypeForConfig('prod-metabase', { driver: 'metabase', api_url: 'https://metabase.example.com' })).toBe(
|
|
'metabase',
|
|
);
|
|
expect(localConnectionTypeForConfig('missing-driver', {} as never)).toBe('unknown');
|
|
});
|
|
|
|
it('builds nullable local connection info records', () => {
|
|
expect(localConnectionInfoFromConfig('warehouse', { driver: 'postgres' })).toEqual({
|
|
id: 'warehouse',
|
|
name: 'warehouse',
|
|
connectionType: 'POSTGRESQL',
|
|
});
|
|
expect(localConnectionInfoFromConfig('missing', undefined)).toBeNull();
|
|
});
|
|
});
|