mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
145 lines
4.8 KiB
TypeScript
145 lines
4.8 KiB
TypeScript
import { mkdtemp, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import {
|
|
driverRegistrations,
|
|
getDriverRegistration,
|
|
listSupportedDrivers,
|
|
} from '../../../src/context/connections/drivers.js';
|
|
import type {
|
|
KtxDriverConnectorModule,
|
|
KtxScopeConfigKey,
|
|
} from '../../../src/context/connections/drivers.js';
|
|
import type { KtxConnectionDriver } from '../../../src/context/scan/types.js';
|
|
|
|
type FixtureFactory = (projectDir: string) => Record<string, unknown>;
|
|
|
|
const connectionFixtures: Record<KtxConnectionDriver, FixtureFactory> = {
|
|
postgres: () => ({
|
|
driver: 'postgres',
|
|
url: 'postgresql://reader:secret@localhost:5432/analytics', // pragma: allowlist secret
|
|
schemas: ['public'],
|
|
}),
|
|
sqlite: () => ({ driver: 'sqlite', path: 'warehouse.db' }),
|
|
mysql: () => ({
|
|
driver: 'mysql',
|
|
host: 'localhost',
|
|
database: 'analytics',
|
|
username: 'reader',
|
|
password: 'secret', // pragma: allowlist secret
|
|
schemas: ['analytics'],
|
|
}),
|
|
clickhouse: () => ({
|
|
driver: 'clickhouse',
|
|
url: 'http://localhost:8123',
|
|
database: 'analytics',
|
|
username: 'reader',
|
|
password: 'secret', // pragma: allowlist secret
|
|
}),
|
|
sqlserver: () => ({
|
|
driver: 'sqlserver',
|
|
host: 'localhost',
|
|
database: 'analytics',
|
|
username: 'reader',
|
|
password: 'secret', // pragma: allowlist secret
|
|
schemas: ['dbo'],
|
|
}),
|
|
bigquery: () => ({
|
|
driver: 'bigquery',
|
|
dataset_id: 'analytics',
|
|
credentials_json: JSON.stringify({
|
|
project_id: 'project-1',
|
|
client_email: 'reader@example.test',
|
|
private_key: '-----BEGIN PRIVATE KEY-----\nsecret\n-----END PRIVATE KEY-----\n', // pragma: allowlist secret
|
|
}),
|
|
location: 'US',
|
|
}),
|
|
snowflake: () => ({
|
|
driver: 'snowflake',
|
|
account: 'example-account',
|
|
username: 'reader',
|
|
password: 'secret', // pragma: allowlist secret
|
|
warehouse: 'COMPUTE_WH',
|
|
database: 'ANALYTICS',
|
|
schema: 'PUBLIC',
|
|
}),
|
|
};
|
|
|
|
const allowedScopeKeys = new Set(['dataset_ids', 'databases', 'schemas', 'schema_names']);
|
|
const historicSqlReaderDrivers = new Set<KtxConnectionDriver>(['postgres', 'bigquery', 'snowflake']);
|
|
const localExecutorDrivers = new Set<KtxConnectionDriver>(['postgres', 'sqlite']);
|
|
|
|
function assertExportedRegistryBoundaryTypes(input: {
|
|
scopeConfigKey: KtxScopeConfigKey;
|
|
connectorModule: KtxDriverConnectorModule;
|
|
}): {
|
|
scopeConfigKey: KtxScopeConfigKey;
|
|
connectorModule: KtxDriverConnectorModule;
|
|
} {
|
|
return input;
|
|
}
|
|
|
|
describe('driverRegistrations', () => {
|
|
let projectDir: string;
|
|
|
|
beforeEach(async () => {
|
|
projectDir = await mkdtemp(join(tmpdir(), 'ktx-driver-registry-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(projectDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('lists every supported warehouse driver', () => {
|
|
const registryDrivers = Object.keys(driverRegistrations).sort();
|
|
expect(listSupportedDrivers()).toEqual(registryDrivers);
|
|
expect(listSupportedDrivers()).toEqual([
|
|
'bigquery',
|
|
'clickhouse',
|
|
'mysql',
|
|
'postgres',
|
|
'snowflake',
|
|
'sqlite',
|
|
'sqlserver',
|
|
]);
|
|
});
|
|
|
|
it('resolves registered drivers case-insensitively', () => {
|
|
expect(getDriverRegistration(' Postgres ')?.driver).toBe('postgres');
|
|
expect(getDriverRegistration('unknown')).toBeUndefined();
|
|
});
|
|
|
|
it.each(Object.values(driverRegistrations))('adapts $driver connector exports', async (registration) => {
|
|
const connectorModule = await registration.load();
|
|
const connection = connectionFixtures[registration.driver](projectDir);
|
|
const exportedBoundary = assertExportedRegistryBoundaryTypes({
|
|
scopeConfigKey: registration.scopeConfigKey ?? 'schemas',
|
|
connectorModule,
|
|
});
|
|
expect(exportedBoundary.connectorModule.createScanConnector).toEqual(expect.any(Function));
|
|
|
|
expect(connectorModule.isConnectionConfig(connection)).toBe(true);
|
|
expect(connectorModule.isConnectionConfig({})).toBe(false);
|
|
|
|
const connector = connectorModule.createScanConnector({
|
|
connectionId: 'warehouse',
|
|
connection,
|
|
projectDir,
|
|
});
|
|
|
|
expect(connector.driver).toBe(registration.driver);
|
|
expect(connector.listSchemas).toEqual(expect.any(Function));
|
|
expect(connector.listTables).toEqual(expect.any(Function));
|
|
await connector.cleanup?.();
|
|
|
|
if (registration.driver === 'sqlite') {
|
|
expect(registration.scopeConfigKey).toBeNull();
|
|
} else {
|
|
expect(registration.scopeConfigKey).not.toBeNull();
|
|
expect(allowedScopeKeys.has(registration.scopeConfigKey ?? '')).toBe(true);
|
|
}
|
|
expect(registration.hasHistoricSqlReader).toBe(historicSqlReaderDrivers.has(registration.driver));
|
|
expect(registration.hasLocalQueryExecutor).toBe(localExecutorDrivers.has(registration.driver));
|
|
});
|
|
});
|