mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
138 lines
4.8 KiB
TypeScript
138 lines
4.8 KiB
TypeScript
import { Command } from '@commander-js/extra-typings';
|
|
import { describe, expect, it, vi } from 'vitest';
|
|
import type { KtxCliCommandContext } from '../../src/cli-program.js';
|
|
import { registerMcpCommands } from '../../src/commands/mcp-commands.js';
|
|
|
|
function makeContext(overrides: Partial<KtxCliCommandContext> = {}): KtxCliCommandContext {
|
|
let exitCode = 0;
|
|
return {
|
|
io: {
|
|
stdout: { write: vi.fn() },
|
|
stderr: { write: vi.fn() },
|
|
},
|
|
deps: {},
|
|
packageInfo: { name: '@kaelio/ktx', version: '0.0.0-test' },
|
|
setExitCode: (code) => {
|
|
exitCode = code;
|
|
},
|
|
runInit: vi.fn(),
|
|
writeDebug: vi.fn(),
|
|
...overrides,
|
|
get exitCode() {
|
|
return exitCode;
|
|
},
|
|
} as KtxCliCommandContext;
|
|
}
|
|
|
|
describe('registerMcpCommands', () => {
|
|
it('registers the public mcp lifecycle commands', () => {
|
|
const program = new Command().exitOverride();
|
|
registerMcpCommands(program, makeContext());
|
|
const mcp = program.commands.find((command) => command.name() === 'mcp');
|
|
|
|
expect(mcp?.commands.map((command) => command.name()).sort()).toEqual([
|
|
'logs',
|
|
'serve-internal',
|
|
'start',
|
|
'status',
|
|
'stdio',
|
|
'stop',
|
|
]);
|
|
expect(
|
|
(mcp?.commands.find((command) => command.name() === 'serve-internal') as { _hidden?: boolean } | undefined)
|
|
?._hidden,
|
|
).toBe(true);
|
|
});
|
|
|
|
it('rejects non-loopback start without token before spawning', async () => {
|
|
const program = new Command().exitOverride();
|
|
const startDaemon = vi.fn();
|
|
const context = makeContext({ deps: { mcp: { startDaemon } } });
|
|
registerMcpCommands(program, context);
|
|
|
|
await expect(program.parseAsync(['mcp', 'start', '--host', '0.0.0.0'], { from: 'user' })).rejects.toThrow(
|
|
'Binding KTX MCP to 0.0.0.0 requires --token or KTX_MCP_TOKEN',
|
|
);
|
|
expect(startDaemon).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('prints "already running" when startDaemon reports already-running', async () => {
|
|
const program = new Command().exitOverride().option('--project-dir <path>');
|
|
const startDaemon = vi.fn().mockResolvedValue({
|
|
status: 'already-running',
|
|
url: 'http://127.0.0.1:7878/mcp',
|
|
state: {
|
|
schemaVersion: 1,
|
|
pid: 4242,
|
|
host: '127.0.0.1',
|
|
port: 7878,
|
|
tokenAuth: false,
|
|
projectDir: '/tmp/ktx-already',
|
|
startedAt: '2026-05-14T00:00:00.000Z',
|
|
logPath: '/tmp/ktx-already/.ktx/logs/mcp.log',
|
|
},
|
|
});
|
|
const context = makeContext({ deps: { mcp: { startDaemon } } });
|
|
registerMcpCommands(program, context);
|
|
|
|
await program.parseAsync(['--project-dir', '/tmp/ktx-already', 'mcp', 'start'], { from: 'user' });
|
|
|
|
expect(startDaemon).toHaveBeenCalledTimes(1);
|
|
expect(context.io.stdout.write).toHaveBeenCalledWith(
|
|
[
|
|
'KTX MCP daemon already running: http://127.0.0.1:7878/mcp',
|
|
'',
|
|
'KTX is ready for configured agents.',
|
|
'Open your agent for this KTX project and ask a data question, for example:',
|
|
' "Use KTX to show me the available tables and metrics."',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
});
|
|
|
|
it('prints a friendly next step after starting the daemon', async () => {
|
|
const program = new Command().exitOverride().option('--project-dir <path>');
|
|
const startDaemon = vi.fn().mockResolvedValue({
|
|
status: 'started',
|
|
url: 'http://127.0.0.1:7878/mcp',
|
|
state: {
|
|
schemaVersion: 1,
|
|
pid: 4242,
|
|
host: '127.0.0.1',
|
|
port: 7878,
|
|
tokenAuth: false,
|
|
projectDir: '/tmp/ktx-started',
|
|
startedAt: '2026-05-14T00:00:00.000Z',
|
|
logPath: '/tmp/ktx-started/.ktx/logs/mcp.log',
|
|
},
|
|
});
|
|
const context = makeContext({ deps: { mcp: { startDaemon } } });
|
|
registerMcpCommands(program, context);
|
|
|
|
await program.parseAsync(['--project-dir', '/tmp/ktx-started', 'mcp', 'start'], { from: 'user' });
|
|
|
|
expect(context.io.stdout.write).toHaveBeenCalledWith(
|
|
expect.stringContaining('KTX MCP daemon started: http://127.0.0.1:7878/mcp\n\nKTX is ready for configured agents.'),
|
|
);
|
|
expect(context.io.stdout.write).toHaveBeenCalledWith(
|
|
expect.stringContaining('"Use KTX to show me the available tables and metrics."'),
|
|
);
|
|
});
|
|
|
|
it('runs the stdio server with the resolved project directory', async () => {
|
|
const program = new Command().exitOverride().option('--project-dir <path>');
|
|
const runStdioServer = vi.fn().mockResolvedValue(undefined);
|
|
const context = makeContext({ deps: { mcp: { runStdioServer } } });
|
|
registerMcpCommands(program, context);
|
|
|
|
await expect(program.parseAsync(['--project-dir', '/tmp/ktx6', 'mcp', 'stdio'], { from: 'user' })).resolves.toBe(
|
|
program,
|
|
);
|
|
|
|
expect(runStdioServer).toHaveBeenCalledWith({
|
|
projectDir: '/tmp/ktx6',
|
|
cliVersion: '0.0.0-test',
|
|
io: context.io,
|
|
});
|
|
});
|
|
});
|