ktx/scripts/build-adventureworks-oltp-fixture.mjs
Andrey Avtomonov 2366b00301
chore(workspace): gate dead-code with knip production mode (#196)
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm

* refactor(workspace): rewrite @ktx/llm imports to relative paths

* refactor(workspace): fold internal packages into cli

* chore(workspace): gate dead-code with knip production mode

Turn on production-mode knip plus an autofix run in pre-commit and the
`pnpm dead-code` script, document the `/** @internal */` convention for
test-only exports in AGENTS.md, annotate test-only exports across the
CLI with that JSDoc, and drop dead exports/wrappers the new gate
surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`,
`createLocalScanEnrichmentProvidersFromConfig`,
`PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports).
Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit
production entries so cross-package barrel leaks are caught.

* refactor(cli): delete internal barrel index.ts files

The 34 `index.ts` re-export barrels inside `packages/cli/src/` were
holdovers from the pre-fold multi-workspace structure. Post-fold-in they
served no production purpose: external consumers go through the single
package main entry, and in-repo callers mostly imported through them
only because the path was short. Internally, knip flagged most barrel
re-exports as production-dead (only reached via tests).

This change:
- Deletes every internal barrel except `packages/cli/src/index.ts`
  (the published package entry).
- Rewrites ~270 source/test files to import each name directly from
  the file that defines it.
- Moves `tools/warehouse-verification/index.ts` to
  `create-warehouse-verification-tools.ts` (the function it defined
  locally) and updates its single consumer.
- Renames `search/backend-conformance.ts` → `.test-utils.ts` to match
  the existing test-helper file convention.
- Deletes 13 dead test-only chains (dbt-descriptions/*,
  live-database/extracted-schema, live-database/structural-sync,
  relationship-* feedback/review chain) plus their tests and a
  cascading orphan integration test.
- Updates test mocks that pointed at deleted barrel paths
  (notion-client, connector barrels in scan/local-scan-connectors
  tests) to mock the source files instead.
- Points the maintainer benchmark script
  (`scripts/relationship-benchmark-report.mjs`) at source files
  instead of `dist/context/scan/index.js`.
- Drops the barrel `!` entries from `knip.json`; adds explicit
  production entries only for the benchmark code reached via dist by
  the maintainer script.

Net: 413 files changed, ~1.2k insertions, ~9.4k deletions.

`pnpm run dead-code` (Biome + knip default + knip production) and
`pnpm run type-check` are clean; 2277 tests pass.

* refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly

Promote the CLI workspace package to the public name `@kaelio/ktx` and
drop the separate `scripts/build-public-npm-package.mjs` wrapper. The
CLI package is now publishable in place (`publishConfig.access: public`,
`provenance: true`), so artifact packing uses `pnpm pack` against
`packages/cli/` instead of assembling a parallel package tree.

Updates all workspace filter invocations, docs, tests, and release
readiness checks to reference the new package name, and folds the
tarball-name helper into `scripts/public-npm-release-metadata.mjs`.

* docs: align "agent clients" and "data agents" terminology

Replace "client agents" with "agent clients" and "database agents" with
"data agents" across AGENTS.md, README.md, the docs-site copy, and the
matching setup-agents test description, matching the canonical
vocabulary in docs/terminology.md.

Also moves packages/cli/tsconfig.json's tsBuildInfoFile from
node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive
node_modules reinstalls.

* refactor(release): single source of truth for package version

Make packages/cli/package.json the single source of truth for the
@kaelio/ktx version. publicNpmPackageVersion() now reads it directly,
so artifact filenames, release-readiness checks, and the Python wheel
version all derive from one field. The duplicate
release-policy.json.publicNpmPackageVersion is removed.

Previously the two fields could drift: tarballs were named
kaelio-ktx-0.4.1.tgz while internally containing
@kaelio/ktx@0.0.0-private.

- update-public-release-version.mjs rewrites both Python pyproject.toml
  files (ktx-daemon, ktx-sl) alongside the npm package.jsons,
  normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2).
- semantic-release-config.cjs adds the two pyproject.toml files to
  @semantic-release/git assets so the release commit back to main
  carries every version source in lockstep.
- The six "?? '0.0.0-private'" fallback literals across the CLI are
  replaced with "?? getKtxCliPackageInfo().version", and
  createDefaultKtxMcpServer makes its version arg required.
- docs/release.md describes the actual commit-back model: the dev tree
  always reflects the most recent release; no sentinel pin to
  maintain.

Verified: pnpm run artifacts:build now produces
kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with
@kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and
2287 vitests + 173 script tests pass.

* refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime

Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and
scan command entrypoints so tests can stub them, and teach
resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime
feature when ktx.yaml selects sentence-transformers.

* chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal

Both symbols are consumed only by status-project.test.ts. Annotating with
/** @internal */ keeps knip's production-mode check clean without changing
runtime behavior.

* fix(cli): use real package metadata in print-command-tree

The stubbed package name embedded a forbidden product identifier that
tripped the boundary check in CI. Read the metadata from package.json
instead — keeps the rendered tree unchanged and removes a duplicate
source of truth.

* feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts

Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer
source counts, computed with `SUM(embedding_json IS NOT NULL)` over
`knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to
"Wiki" (canonical per `docs/terminology.md`) and rename the matching
`localStats.knowledgePages` field to `localStats.wikiPages`.

Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those
duplicated the per-surface rows above. Disk now reports only actual byte
usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` /
`semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry`
helpers, and the `filter` arg on `summarizeDir` are removed.
2026-05-21 15:28:58 +02:00

259 lines
8.9 KiB
JavaScript

#!/usr/bin/env node
import { mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
import { createRequire } from 'node:module';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { expectedLinksFromSnapshot, normalizeSqliteType } from './build-benchmark-snapshot.mjs';
const scriptDir = path.dirname(fileURLToPath(import.meta.url));
const repoRoot = path.resolve(scriptDir, '..');
const require = createRequire(new URL('../packages/cli/package.json', import.meta.url));
const Database = require('better-sqlite3');
const { stringify: yamlStringify } = require('yaml');
const fixtureId = 'adventureworks_oltp_with_declared_metadata';
const defaultFixtureDir = path.join(
repoRoot,
'packages',
'context',
'test',
'fixtures',
'relationship-benchmarks',
fixtureId,
);
function quoteSqliteIdentifier(value) {
return `"${String(value).replaceAll('"', '""')}"`;
}
function quoteSqlServerIdentifier(value) {
return `[${String(value).replaceAll(']', ']]')}]`;
}
function flattenTableName(table) {
return `${table.db}.${table.name}`;
}
function sqliteDimensionType(nativeType, columnName) {
const type = normalizeSqliteType(nativeType);
const name = columnName.toLowerCase();
if (/date|time/.test(name) || /date|time/.test(String(nativeType).toLowerCase())) {
return 'time';
}
if (type === 'integer' || type === 'real') {
return 'number';
}
return 'string';
}
function sqliteValue(value) {
if (value === undefined) {
return null;
}
if (value instanceof Date) {
return value.toISOString();
}
if (typeof value === 'boolean') {
return value ? 1 : 0;
}
if (Buffer.isBuffer(value)) {
return value;
}
if (typeof value === 'object' && value !== null) {
return JSON.stringify(value);
}
return value;
}
export function snapshotForSqliteBenchmark(sqlServerSnapshot) {
const tableNameByOriginal = new Map(
sqlServerSnapshot.tables
.filter((table) => table.kind === 'table')
.map((table) => [`${table.db}.${table.name}`, flattenTableName(table)]),
);
return {
connectionId: fixtureId,
driver: 'sqlite',
extractedAt: sqlServerSnapshot.extractedAt,
scope: { catalogs: ['main'], schemas: ['main'] },
metadata: {
...sqlServerSnapshot.metadata,
source_driver: 'sqlserver',
source_connection_id: sqlServerSnapshot.connectionId,
source_database: sqlServerSnapshot.metadata?.database ?? null,
},
tables: sqlServerSnapshot.tables
.filter((table) => table.kind === 'table')
.map((table) => ({
catalog: null,
db: 'main',
name: flattenTableName(table),
kind: 'table',
comment: table.comment ?? null,
estimatedRows: table.estimatedRows ?? 0,
columns: table.columns.map((column) => ({
name: column.name,
nativeType: column.nativeType,
normalizedType: normalizeSqliteType(column.nativeType),
dimensionType: sqliteDimensionType(column.nativeType, column.name),
nullable: column.nullable,
primaryKey: column.primaryKey,
comment: column.comment ?? null,
})),
foreignKeys: (table.foreignKeys ?? []).flatMap((fk) => {
const originalTarget = `${fk.toDb}.${fk.toTable}`;
const targetName = tableNameByOriginal.get(originalTarget);
if (!targetName) {
return [];
}
return [
{
fromColumn: fk.fromColumn,
toCatalog: null,
toDb: 'main',
toTable: targetName,
toColumn: fk.toColumn,
constraintName: fk.constraintName,
},
];
}),
})),
};
}
export function writeAdventureWorksFixtureConfig(fixtureDir) {
const fixture = {
id: fixtureId,
name: 'AdventureWorks OLTP (SQL Server 2022, declared metadata)',
tier: 'row_bearing',
thresholdEligible: true,
defaultModes: [
'metadata_present',
'declared_pks_and_declared_fks_removed',
'declared_pks_removed',
'declared_fks_removed',
'profiling_disabled',
'validation_disabled',
'llm_disabled',
'embeddings_disabled',
],
};
writeFileSync(path.join(fixtureDir, 'fixture.yaml'), yamlStringify(fixture), 'utf8');
}
export function writeAdventureWorksSnapshotAndLabels(fixtureDir, sqliteSnapshot) {
writeFileSync(path.join(fixtureDir, 'snapshot.json'), `${JSON.stringify(sqliteSnapshot, null, 2)}\n`, 'utf8');
writeFileSync(path.join(fixtureDir, 'expected-links.yaml'), yamlStringify(expectedLinksFromSnapshot(sqliteSnapshot)), 'utf8');
}
export async function copySqlServerRowsToSqlite(input) {
const { connector, sourceSnapshot, sqliteSnapshot, fixtureDir } = input;
const sqlitePath = path.join(fixtureDir, 'data.sqlite');
rmSync(sqlitePath, { force: true });
const db = new Database(sqlitePath);
try {
db.pragma('journal_mode = WAL');
db.exec('BEGIN');
for (const sourceTable of sourceSnapshot.tables.filter((table) => table.kind === 'table')) {
const sqliteTable = sqliteSnapshot.tables.find((table) => table.name === flattenTableName(sourceTable));
if (!sqliteTable) {
continue;
}
const columns = sqliteTable.columns;
const createColumns = columns
.map((column) => `${quoteSqliteIdentifier(column.name)} ${normalizeSqliteType(column.nativeType).toUpperCase()}`)
.join(', ');
db.exec(`CREATE TABLE ${quoteSqliteIdentifier(sqliteTable.name)} (${createColumns})`);
const selectSql = `SELECT * FROM ${quoteSqlServerIdentifier(sourceTable.db)}.${quoteSqlServerIdentifier(sourceTable.name)}`;
const result = await connector.executeReadOnly(
{
connectionId: sourceSnapshot.connectionId,
sql: selectSql,
maxRows: Math.max(sourceTable.estimatedRows ?? 0, 1000000),
},
{ runId: `adventureworks-oltp-copy:${sqliteTable.name}` },
);
const bindSlots = columns.map(() => '?').join(', ');
const insert = db.prepare(
`INSERT INTO ${quoteSqliteIdentifier(sqliteTable.name)} (${columns
.map((column) => quoteSqliteIdentifier(column.name))
.join(', ')}) VALUES (${bindSlots})`,
);
for (const row of result.rows) {
insert.run(row.map(sqliteValue));
}
}
db.exec('COMMIT');
} catch (error) {
db.exec('ROLLBACK');
throw error;
} finally {
db.close();
}
}
export async function buildAdventureWorksOltpFixture(input) {
const fixtureDir = input.fixtureDir ?? defaultFixtureDir;
mkdirSync(fixtureDir, { recursive: true });
const sourceSnapshot = await input.connector.introspect(
{ connectionId: input.connectionId, driver: 'sqlserver' },
{ runId: 'adventureworks-oltp-fixture:introspect' },
);
const sqliteSnapshot = snapshotForSqliteBenchmark(sourceSnapshot);
writeAdventureWorksFixtureConfig(fixtureDir);
writeAdventureWorksSnapshotAndLabels(fixtureDir, sqliteSnapshot);
await copySqlServerRowsToSqlite({ connector: input.connector, sourceSnapshot, sqliteSnapshot, fixtureDir });
return {
fixtureDir,
tableCount: sqliteSnapshot.tables.length,
expected: expectedLinksFromSnapshot(sqliteSnapshot),
};
}
async function main() {
const url = process.env.KTX_ADVENTUREWORKS_SQLSERVER_URL;
if (!url) {
throw new Error(
'Set KTX_ADVENTUREWORKS_SQLSERVER_URL to a read-only SQL Server URL for a full AdventureWorks OLTP database before running this script.',
);
}
const source = JSON.parse(readFileSync(path.join(scriptDir, 'adventureworks-oltp-source.json'), 'utf8'));
const { KtxSqlServerScanConnector } = await import('../packages/cli/dist/connectors/sqlserver/index.js');
const connector = new KtxSqlServerScanConnector({
connectionId: fixtureId,
connection: {
driver: 'sqlserver',
url,
schemas: ['dbo', 'HumanResources', 'Person', 'Production', 'Purchasing', 'Sales'],
trustServerCertificate: true,
},
now: () => new Date('2026-05-07T00:00:00.000Z'),
});
const result = await buildAdventureWorksOltpFixture({ connector, connectionId: fixtureId });
if (result.tableCount !== source.expectedTables) {
throw new Error(`Expected ${source.expectedTables} tables, generated ${result.tableCount}`);
}
if (result.expected.expectedPks.length !== source.expectedPrimaryKeys) {
throw new Error(`Expected ${source.expectedPrimaryKeys} PK entries, generated ${result.expected.expectedPks.length}`);
}
if (result.expected.expectedLinks.length !== source.expectedForeignKeys) {
throw new Error(`Expected ${source.expectedForeignKeys} FK links, generated ${result.expected.expectedLinks.length}`);
}
console.log(
`[built] ${fixtureId}: ${result.tableCount} tables, ${result.expected.expectedPks.length} PKs, ${result.expected.expectedLinks.length} FKs`,
);
}
if (import.meta.url === `file://${process.argv[1]}`) {
main().catch((err) => {
console.error(err);
process.exit(1);
});
}