mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
123 lines
3.2 KiB
TypeScript
123 lines
3.2 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
import {
|
|
__resetTelemetryEmitterForTests,
|
|
shutdownTelemetryEmitter,
|
|
trackTelemetryEvent,
|
|
} from '../../src/telemetry/emitter.js';
|
|
import type { BuiltTelemetryEvent } from '../../src/telemetry/events.js';
|
|
|
|
const captures: unknown[] = [];
|
|
const shutdown = vi.fn(async () => {});
|
|
|
|
function liveConfigId(): string {
|
|
return 'fixture';
|
|
}
|
|
|
|
vi.mock('posthog-node', () => ({
|
|
PostHog: vi.fn().mockImplementation(function () {
|
|
return {
|
|
capture: (event: unknown) => captures.push(event),
|
|
shutdown,
|
|
};
|
|
}),
|
|
}));
|
|
|
|
function commandEvent(): BuiltTelemetryEvent<'command'> {
|
|
return {
|
|
name: 'command',
|
|
properties: {
|
|
cliVersion: '0.4.1',
|
|
nodeVersion: 'v22.0.0',
|
|
osPlatform: 'darwin',
|
|
osRelease: '25.0.0',
|
|
arch: 'arm64',
|
|
runtime: 'node',
|
|
isCi: false,
|
|
commandPath: ['ktx', 'status'],
|
|
durationMs: 1,
|
|
outcome: 'ok',
|
|
flagsPresent: {},
|
|
hasProject: true,
|
|
projectGroupAttached: true,
|
|
},
|
|
};
|
|
}
|
|
|
|
describe('telemetry emitter', () => {
|
|
beforeEach(() => {
|
|
captures.length = 0;
|
|
shutdown.mockClear();
|
|
__resetTelemetryEmitterForTests();
|
|
});
|
|
|
|
it('prints debug payloads without importing or sending to PostHog', async () => {
|
|
const stderr: string[] = [];
|
|
|
|
await trackTelemetryEvent({
|
|
event: commandEvent(),
|
|
distinctId: 'install-1',
|
|
projectId: 'project-1',
|
|
env: { KTX_TELEMETRY_DEBUG: '1' },
|
|
stderr: { write: (chunk) => stderr.push(chunk) },
|
|
});
|
|
|
|
expect(stderr.join('')).toContain('[telemetry]');
|
|
expect(stderr.join('')).toContain('"event":"command"');
|
|
expect(captures).toEqual([]);
|
|
});
|
|
|
|
it('sends to PostHog by default once config constants are populated', async () => {
|
|
await trackTelemetryEvent({
|
|
event: commandEvent(),
|
|
distinctId: 'install-1',
|
|
projectId: 'project-1',
|
|
env: {},
|
|
stderr: { write: () => {} },
|
|
});
|
|
|
|
expect(captures).toHaveLength(1);
|
|
expect(captures[0]).toMatchObject({
|
|
distinctId: 'install-1',
|
|
event: 'command',
|
|
groups: { project: 'project-1' },
|
|
});
|
|
});
|
|
|
|
it('captures with distinctId, properties, and groups when live config is supplied', async () => {
|
|
await trackTelemetryEvent({
|
|
event: commandEvent(),
|
|
distinctId: 'install-1',
|
|
projectId: 'project-1',
|
|
projectApiKey: liveConfigId(),
|
|
host: 'https://us.i.posthog.com',
|
|
env: {},
|
|
stderr: { write: () => {} },
|
|
});
|
|
|
|
expect(captures).toHaveLength(1);
|
|
expect(captures[0]).toMatchObject({
|
|
distinctId: 'install-1',
|
|
event: 'command',
|
|
groups: { project: 'project-1' },
|
|
properties: {
|
|
cliVersion: '0.4.1',
|
|
commandPath: ['ktx', 'status'],
|
|
},
|
|
});
|
|
});
|
|
|
|
it('shuts down the client without throwing', async () => {
|
|
await trackTelemetryEvent({
|
|
event: commandEvent(),
|
|
distinctId: 'install-1',
|
|
projectApiKey: liveConfigId(),
|
|
host: 'https://us.i.posthog.com',
|
|
env: {},
|
|
stderr: { write: () => {} },
|
|
});
|
|
|
|
await expect(shutdownTelemetryEmitter()).resolves.toBeUndefined();
|
|
expect(shutdown).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|