mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
62 lines
2.7 KiB
TypeScript
62 lines
2.7 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
deletedRawPathsScenario,
|
|
flaggedFallbackScenario,
|
|
postSaveSecretFailureScenario,
|
|
successfulReplayScenario,
|
|
validationRevertScenario,
|
|
} from './acceptance-fixtures.js';
|
|
import { renderMemoryFlowReplay } from '../../../../src/context/ingest/memory-flow/render.js';
|
|
import { buildMemoryFlowViewModel } from '../../../../src/context/ingest/memory-flow/view-model.js';
|
|
|
|
function renderScenario(input = successfulReplayScenario(), terminalWidth = 140): string {
|
|
return renderMemoryFlowReplay(buildMemoryFlowViewModel(input), { terminalWidth });
|
|
}
|
|
|
|
describe('memory-flow acceptance scenarios', () => {
|
|
it('renders a completed replay with a clear saved-memory completion line', () => {
|
|
const output = renderScenario(successfulReplayScenario());
|
|
|
|
expect(output).toContain('KTX memory flow warehouse/metricflow done');
|
|
expect(output).toContain('Saved 3 memories from 4 raw files: 2 wiki pages, 1 SL updates.');
|
|
expect(output).toContain('Commit: abc12345 Run: run-success Report: ingest-report.json');
|
|
});
|
|
|
|
it('renders deleted raw paths as eviction candidates without listing every raw path by default', () => {
|
|
const output = renderScenario(deletedRawPathsScenario());
|
|
|
|
expect(output).toContain('2 deletions');
|
|
expect(output).toContain('Eviction candidates: 2');
|
|
expect(output).not.toContain('/full/local/path/private/orders-2024.sql');
|
|
});
|
|
|
|
it('renders invalid semantic-layer writes as reverted, not saved', () => {
|
|
const output = renderScenario(validationRevertScenario());
|
|
|
|
expect(output).toContain('orders reverted: semantic-layer validation failed for warehouse.orders');
|
|
expect(output).toContain('Invalid semantic-layer writes were not saved.');
|
|
expect(output).not.toContain('Saved 1 memories');
|
|
});
|
|
|
|
it('renders flagged fallbacks in gates details', () => {
|
|
const output = renderScenario(flaggedFallbackScenario());
|
|
|
|
expect(output).toContain('0 conflict, 1 fallback');
|
|
expect(output).toContain('Flagged fallbacks: 1');
|
|
});
|
|
|
|
it('renders no ANSI color codes in the text fallback for terminals without color support', () => {
|
|
const output = renderScenario(successfulReplayScenario(), 80);
|
|
|
|
expect(output).toContain('KTX memory flow warehouse/metricflow done');
|
|
expect(output).not.toMatch(/\u001b\[[0-9;]*m/);
|
|
});
|
|
|
|
it('redacts secrets in visible post-save failure text', () => {
|
|
const output = renderScenario(postSaveSecretFailureScenario());
|
|
|
|
expect(output).toContain('Post-save error: index refresh failed https://[redacted] token=[redacted]');
|
|
expect(output).not.toContain('abc123');
|
|
expect(output).not.toContain('https://example.com/private');
|
|
});
|
|
});
|