mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass.
193 lines
6.6 KiB
TypeScript
193 lines
6.6 KiB
TypeScript
import { request as httpRequest } from 'node:http';
|
|
import { request as httpsRequest } from 'node:https';
|
|
import { URL } from 'node:url';
|
|
import { createDaemonLookerTableIdentifierParser, type KtxDaemonTableIdentifierHttpJsonRunner } from './context/ingest/adapters/looker/daemon-table-identifier-parser.js';
|
|
import type { DaemonLiveDatabaseIntrospectionOptions, KtxDaemonDatabaseHttpJsonRunner } from './context/ingest/adapters/live-database/daemon-introspection.js';
|
|
import type { LookerTableIdentifierParser } from './context/ingest/adapters/looker/mapping.js';
|
|
import { createHttpSqlAnalysisPort, type KtxSqlAnalysisHttpJsonRunner } from './context/sql-analysis/http-sql-analysis-port.js';
|
|
import type { SqlAnalysisPort } from './context/sql-analysis/ports.js';
|
|
import type { KtxCliIo } from './cli-runtime.js';
|
|
import {
|
|
ensureManagedPythonCommandRuntime,
|
|
type KtxManagedPythonInstallPolicy,
|
|
type ManagedPythonCommandRuntime,
|
|
} from './managed-python-command.js';
|
|
import { startManagedPythonDaemon, type ManagedPythonDaemonStartResult } from './managed-python-daemon.js';
|
|
|
|
/** @internal */
|
|
export type ManagedPythonHttpJsonRunner = (
|
|
path: string,
|
|
payload: Record<string, unknown>,
|
|
) => Promise<Record<string, unknown>>;
|
|
|
|
type ManagedPythonHttpPostJson = (
|
|
baseUrl: string,
|
|
path: string,
|
|
payload: Record<string, unknown>,
|
|
) => Promise<Record<string, unknown>>;
|
|
|
|
export interface ManagedPythonCoreDaemonOptions {
|
|
cliVersion: string;
|
|
projectDir: string;
|
|
installPolicy: KtxManagedPythonInstallPolicy;
|
|
io: KtxCliIo;
|
|
ensureRuntime?: (options: {
|
|
cliVersion: string;
|
|
installPolicy: KtxManagedPythonInstallPolicy;
|
|
io: KtxCliIo;
|
|
feature: 'core';
|
|
}) => Promise<ManagedPythonCommandRuntime>;
|
|
startDaemon?: (options: {
|
|
cliVersion: string;
|
|
projectDir: string;
|
|
features: ['core'];
|
|
force: false;
|
|
}) => Promise<ManagedPythonDaemonStartResult>;
|
|
}
|
|
|
|
export type ManagedPythonDaemonHttpOptions =
|
|
| {
|
|
requestJson: ManagedPythonHttpJsonRunner;
|
|
}
|
|
| {
|
|
resolveBaseUrl: () => Promise<string>;
|
|
postJson?: ManagedPythonHttpPostJson;
|
|
}
|
|
| (ManagedPythonCoreDaemonOptions & {
|
|
postJson?: ManagedPythonHttpPostJson;
|
|
});
|
|
|
|
function normalizedBaseUrl(baseUrl: string): string {
|
|
return baseUrl.endsWith('/') ? baseUrl : `${baseUrl}/`;
|
|
}
|
|
|
|
function parseJsonObject(raw: string, path: string): Record<string, unknown> {
|
|
const parsed = JSON.parse(raw) as unknown;
|
|
if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
|
|
throw new Error(`KTX daemon HTTP ${path} returned non-object JSON`);
|
|
}
|
|
return parsed as Record<string, unknown>;
|
|
}
|
|
|
|
async function postManagedDaemonJson(
|
|
baseUrl: string,
|
|
path: string,
|
|
payload: Record<string, unknown>,
|
|
): Promise<Record<string, unknown>> {
|
|
return await new Promise((resolve, reject) => {
|
|
const target = new URL(path.replace(/^\//, ''), normalizedBaseUrl(baseUrl));
|
|
const body = JSON.stringify(payload);
|
|
const client = target.protocol === 'https:' ? httpsRequest : httpRequest;
|
|
const request = client(
|
|
target,
|
|
{
|
|
method: 'POST',
|
|
headers: {
|
|
accept: 'application/json',
|
|
'content-type': 'application/json',
|
|
'content-length': Buffer.byteLength(body),
|
|
},
|
|
},
|
|
(response) => {
|
|
const chunks: Buffer[] = [];
|
|
response.on('data', (chunk: Buffer) => chunks.push(chunk));
|
|
response.on('end', () => {
|
|
const text = Buffer.concat(chunks).toString('utf8');
|
|
const statusCode = response.statusCode ?? 0;
|
|
if (statusCode < 200 || statusCode >= 300) {
|
|
reject(new Error(`KTX daemon HTTP ${path} failed with ${statusCode}: ${text}`));
|
|
return;
|
|
}
|
|
try {
|
|
resolve(parseJsonObject(text, path));
|
|
} catch (error) {
|
|
reject(error);
|
|
}
|
|
});
|
|
},
|
|
);
|
|
request.on('error', reject);
|
|
request.end(body);
|
|
});
|
|
}
|
|
|
|
/** @internal */
|
|
export function createManagedPythonDaemonBaseUrlResolver(
|
|
options: ManagedPythonCoreDaemonOptions,
|
|
): () => Promise<string> {
|
|
let cachedBaseUrl: string | undefined;
|
|
|
|
return async () => {
|
|
if (cachedBaseUrl) {
|
|
return cachedBaseUrl;
|
|
}
|
|
|
|
const ensureRuntime = options.ensureRuntime ?? ensureManagedPythonCommandRuntime;
|
|
const startDaemon = options.startDaemon ?? startManagedPythonDaemon;
|
|
await ensureRuntime({
|
|
cliVersion: options.cliVersion,
|
|
installPolicy: options.installPolicy,
|
|
io: options.io,
|
|
feature: 'core',
|
|
});
|
|
const daemon = await startDaemon({
|
|
cliVersion: options.cliVersion,
|
|
projectDir: options.projectDir,
|
|
features: ['core'],
|
|
force: false,
|
|
});
|
|
const verb = daemon.status === 'started' ? 'Started' : 'Using existing';
|
|
options.io.stderr.write(`${verb} KTX daemon: ${daemon.baseUrl}\n`);
|
|
cachedBaseUrl = daemon.baseUrl;
|
|
return cachedBaseUrl;
|
|
};
|
|
}
|
|
|
|
function isRequestJsonOnly(options: ManagedPythonDaemonHttpOptions): options is { requestJson: ManagedPythonHttpJsonRunner } {
|
|
return 'requestJson' in options;
|
|
}
|
|
|
|
function isResolveBaseUrlOnly(
|
|
options: ManagedPythonDaemonHttpOptions,
|
|
): options is { resolveBaseUrl: () => Promise<string>; postJson?: ManagedPythonHttpPostJson } {
|
|
return 'resolveBaseUrl' in options;
|
|
}
|
|
|
|
/** @internal */
|
|
export function createManagedDaemonHttpJsonRunner(
|
|
options: ManagedPythonDaemonHttpOptions,
|
|
): ManagedPythonHttpJsonRunner {
|
|
if (isRequestJsonOnly(options)) {
|
|
return options.requestJson;
|
|
}
|
|
const resolveBaseUrl = isResolveBaseUrlOnly(options)
|
|
? options.resolveBaseUrl
|
|
: createManagedPythonDaemonBaseUrlResolver(options);
|
|
const postJson = options.postJson ?? postManagedDaemonJson;
|
|
|
|
return async (path, payload) => postJson(await resolveBaseUrl(), path, payload);
|
|
}
|
|
|
|
export function createManagedDaemonLookerTableIdentifierParser(
|
|
options: ManagedPythonDaemonHttpOptions,
|
|
): LookerTableIdentifierParser {
|
|
return createDaemonLookerTableIdentifierParser({
|
|
baseUrl: 'http://127.0.0.1:0',
|
|
requestJson: createManagedDaemonHttpJsonRunner(options) as KtxDaemonTableIdentifierHttpJsonRunner,
|
|
});
|
|
}
|
|
|
|
export function createManagedDaemonSqlAnalysisPort(options: ManagedPythonDaemonHttpOptions): SqlAnalysisPort {
|
|
return createHttpSqlAnalysisPort({
|
|
baseUrl: 'http://127.0.0.1:0',
|
|
requestJson: createManagedDaemonHttpJsonRunner(options) as KtxSqlAnalysisHttpJsonRunner,
|
|
});
|
|
}
|
|
|
|
export function managedDaemonDatabaseIntrospectionOptions(
|
|
options: ManagedPythonDaemonHttpOptions,
|
|
): Pick<DaemonLiveDatabaseIntrospectionOptions, 'requestJson'> {
|
|
return {
|
|
requestJson: createManagedDaemonHttpJsonRunner(options) as KtxDaemonDatabaseHttpJsonRunner,
|
|
};
|
|
}
|