ktx/scripts/build-benchmark-snapshot.test.mjs
Andrey Avtomonov 2366b00301
chore(workspace): gate dead-code with knip production mode (#196)
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm

* refactor(workspace): rewrite @ktx/llm imports to relative paths

* refactor(workspace): fold internal packages into cli

* chore(workspace): gate dead-code with knip production mode

Turn on production-mode knip plus an autofix run in pre-commit and the
`pnpm dead-code` script, document the `/** @internal */` convention for
test-only exports in AGENTS.md, annotate test-only exports across the
CLI with that JSDoc, and drop dead exports/wrappers the new gate
surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`,
`createLocalScanEnrichmentProvidersFromConfig`,
`PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports).
Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit
production entries so cross-package barrel leaks are caught.

* refactor(cli): delete internal barrel index.ts files

The 34 `index.ts` re-export barrels inside `packages/cli/src/` were
holdovers from the pre-fold multi-workspace structure. Post-fold-in they
served no production purpose: external consumers go through the single
package main entry, and in-repo callers mostly imported through them
only because the path was short. Internally, knip flagged most barrel
re-exports as production-dead (only reached via tests).

This change:
- Deletes every internal barrel except `packages/cli/src/index.ts`
  (the published package entry).
- Rewrites ~270 source/test files to import each name directly from
  the file that defines it.
- Moves `tools/warehouse-verification/index.ts` to
  `create-warehouse-verification-tools.ts` (the function it defined
  locally) and updates its single consumer.
- Renames `search/backend-conformance.ts` → `.test-utils.ts` to match
  the existing test-helper file convention.
- Deletes 13 dead test-only chains (dbt-descriptions/*,
  live-database/extracted-schema, live-database/structural-sync,
  relationship-* feedback/review chain) plus their tests and a
  cascading orphan integration test.
- Updates test mocks that pointed at deleted barrel paths
  (notion-client, connector barrels in scan/local-scan-connectors
  tests) to mock the source files instead.
- Points the maintainer benchmark script
  (`scripts/relationship-benchmark-report.mjs`) at source files
  instead of `dist/context/scan/index.js`.
- Drops the barrel `!` entries from `knip.json`; adds explicit
  production entries only for the benchmark code reached via dist by
  the maintainer script.

Net: 413 files changed, ~1.2k insertions, ~9.4k deletions.

`pnpm run dead-code` (Biome + knip default + knip production) and
`pnpm run type-check` are clean; 2277 tests pass.

* refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly

Promote the CLI workspace package to the public name `@kaelio/ktx` and
drop the separate `scripts/build-public-npm-package.mjs` wrapper. The
CLI package is now publishable in place (`publishConfig.access: public`,
`provenance: true`), so artifact packing uses `pnpm pack` against
`packages/cli/` instead of assembling a parallel package tree.

Updates all workspace filter invocations, docs, tests, and release
readiness checks to reference the new package name, and folds the
tarball-name helper into `scripts/public-npm-release-metadata.mjs`.

* docs: align "agent clients" and "data agents" terminology

Replace "client agents" with "agent clients" and "database agents" with
"data agents" across AGENTS.md, README.md, the docs-site copy, and the
matching setup-agents test description, matching the canonical
vocabulary in docs/terminology.md.

Also moves packages/cli/tsconfig.json's tsBuildInfoFile from
node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive
node_modules reinstalls.

* refactor(release): single source of truth for package version

Make packages/cli/package.json the single source of truth for the
@kaelio/ktx version. publicNpmPackageVersion() now reads it directly,
so artifact filenames, release-readiness checks, and the Python wheel
version all derive from one field. The duplicate
release-policy.json.publicNpmPackageVersion is removed.

Previously the two fields could drift: tarballs were named
kaelio-ktx-0.4.1.tgz while internally containing
@kaelio/ktx@0.0.0-private.

- update-public-release-version.mjs rewrites both Python pyproject.toml
  files (ktx-daemon, ktx-sl) alongside the npm package.jsons,
  normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2).
- semantic-release-config.cjs adds the two pyproject.toml files to
  @semantic-release/git assets so the release commit back to main
  carries every version source in lockstep.
- The six "?? '0.0.0-private'" fallback literals across the CLI are
  replaced with "?? getKtxCliPackageInfo().version", and
  createDefaultKtxMcpServer makes its version arg required.
- docs/release.md describes the actual commit-back model: the dev tree
  always reflects the most recent release; no sentinel pin to
  maintain.

Verified: pnpm run artifacts:build now produces
kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with
@kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and
2287 vitests + 173 script tests pass.

* refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime

Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and
scan command entrypoints so tests can stub them, and teach
resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime
feature when ktx.yaml selects sentence-transformers.

* chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal

Both symbols are consumed only by status-project.test.ts. Annotating with
/** @internal */ keeps knip's production-mode check clean without changing
runtime behavior.

* fix(cli): use real package metadata in print-command-tree

The stubbed package name embedded a forbidden product identifier that
tripped the boundary check in CI. Read the metadata from package.json
instead — keeps the rendered tree unchanged and removes a duplicate
source of truth.

* feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts

Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer
source counts, computed with `SUM(embedding_json IS NOT NULL)` over
`knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to
"Wiki" (canonical per `docs/terminology.md`) and rename the matching
`localStats.knowledgePages` field to `localStats.wikiPages`.

Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those
duplicated the per-surface rows above. Disk now reports only actual byte
usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` /
`semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry`
helpers, and the `filter` arg on `summarizeDir` are removed.
2026-05-21 15:28:58 +02:00

263 lines
8.6 KiB
JavaScript

import assert from 'node:assert/strict';
import { readFile } from 'node:fs/promises';
import { createRequire } from 'node:module';
import { describe, it } from 'node:test';
import { buildBenchmarkSnapshot } from './build-benchmark-snapshot.mjs';
const require = createRequire(new URL('../packages/cli/package.json', import.meta.url));
const Database = require('better-sqlite3');
describe('buildBenchmarkSnapshot', () => {
it('emits a KtxSchemaSnapshot-shaped object plus expected-links from declared FKs', () => {
const db = new Database(':memory:');
db.exec(`
PRAGMA foreign_keys = ON;
CREATE TABLE accounts (
id INTEGER PRIMARY KEY,
name TEXT NOT NULL
);
CREATE TABLE orders (
id INTEGER PRIMARY KEY,
account_id INTEGER NOT NULL REFERENCES accounts(id),
total REAL,
created_at TEXT
);
INSERT INTO accounts (id, name) VALUES (1, 'a'), (2, 'b');
INSERT INTO orders (id, account_id, total, created_at) VALUES
(1, 1, 10.0, '2024-01-01'), (2, 1, 20.0, '2024-01-02'), (3, 2, 30.0, '2024-01-03');
`);
const result = buildBenchmarkSnapshot({ db, fixtureId: 'fixture_x' });
db.close();
assert.equal(result.snapshot.connectionId, 'fixture_x');
assert.equal(result.snapshot.driver, 'sqlite');
assert.equal(result.snapshot.tables.length, 2);
const accounts = result.snapshot.tables.find((t) => t.name === 'accounts');
assert.ok(accounts);
assert.equal(accounts.estimatedRows, 2);
assert.deepEqual(accounts.foreignKeys, []);
const idCol = accounts.columns.find((c) => c.name === 'id');
assert.equal(idCol.primaryKey, true);
assert.equal(idCol.normalizedType, 'integer');
assert.equal(idCol.dimensionType, 'number');
const orders = result.snapshot.tables.find((t) => t.name === 'orders');
assert.equal(orders.foreignKeys.length, 1);
assert.equal(orders.foreignKeys[0].fromColumn, 'account_id');
assert.equal(orders.foreignKeys[0].toTable, 'accounts');
assert.equal(orders.foreignKeys[0].toColumn, 'id');
const createdAt = orders.columns.find((c) => c.name === 'created_at');
assert.equal(createdAt.dimensionType, 'time');
const total = orders.columns.find((c) => c.name === 'total');
assert.equal(total.dimensionType, 'number');
assert.equal(total.nullable, true);
assert.deepEqual(
result.expected.expectedPks.sort((a, b) => a.table.localeCompare(b.table)),
[
{ table: 'accounts', columns: ['id'] },
{ table: 'orders', columns: ['id'] },
],
);
assert.deepEqual(result.expected.expectedLinks, [
{
fromTable: 'orders',
fromColumns: ['account_id'],
toTable: 'accounts',
toColumns: ['id'],
relationship: 'many_to_one',
},
]);
});
it('skips internal SQLite tables (sqlite_*) and views', () => {
const db = new Database(':memory:');
db.exec(`
CREATE TABLE keep_me (id INTEGER PRIMARY KEY);
CREATE VIEW keep_me_view AS SELECT id FROM keep_me;
INSERT INTO keep_me (id) VALUES (1);
`);
const result = buildBenchmarkSnapshot({ db, fixtureId: 'fx' });
db.close();
assert.equal(result.snapshot.tables.length, 1);
assert.equal(result.snapshot.tables[0].name, 'keep_me');
});
it('groups composite foreign keys into a single ordered link', () => {
const db = new Database(':memory:');
db.exec(`
PRAGMA foreign_keys = ON;
CREATE TABLE order_lines (
order_id INTEGER NOT NULL,
line_number INTEGER NOT NULL,
sku TEXT NOT NULL,
PRIMARY KEY (order_id, line_number)
);
CREATE TABLE allocations (
id INTEGER PRIMARY KEY,
order_id INTEGER NOT NULL,
line_number INTEGER NOT NULL,
FOREIGN KEY (order_id, line_number) REFERENCES order_lines(order_id, line_number)
);
`);
const result = buildBenchmarkSnapshot({ db, fixtureId: 'fx' });
db.close();
const composite = result.expected.expectedLinks.find((l) => l.fromTable === 'allocations');
assert.deepEqual(composite, {
fromTable: 'allocations',
fromColumns: ['order_id', 'line_number'],
toTable: 'order_lines',
toColumns: ['order_id', 'line_number'],
relationship: 'many_to_one',
});
const compositePk = result.expected.expectedPks.find((p) => p.table === 'order_lines');
assert.deepEqual(compositePk.columns, ['order_id', 'line_number']);
});
it('derives expected PKs and grouped FKs from an existing snapshot', async () => {
const { expectedLinksFromSnapshot } = await import('./build-benchmark-snapshot.mjs');
const expected = expectedLinksFromSnapshot({
connectionId: 'fixture',
driver: 'sqlite',
extractedAt: '2026-05-07T00:00:00.000Z',
scope: {},
metadata: {},
tables: [
{
catalog: null,
db: 'main',
name: 'Sales.SalesOrderHeader',
kind: 'table',
comment: null,
estimatedRows: 3,
columns: [
{
name: 'SalesOrderID',
nativeType: 'int',
normalizedType: 'integer',
dimensionType: 'number',
nullable: false,
primaryKey: true,
comment: null,
},
{
name: 'CustomerID',
nativeType: 'int',
normalizedType: 'integer',
dimensionType: 'number',
nullable: false,
primaryKey: false,
comment: null,
},
],
foreignKeys: [
{
fromColumn: 'CustomerID',
toCatalog: null,
toDb: 'main',
toTable: 'Sales.Customer',
toColumn: 'CustomerID',
constraintName: 'FK_SalesOrderHeader_Customer_CustomerID',
},
],
},
{
catalog: null,
db: 'main',
name: 'Sales.Customer',
kind: 'table',
comment: null,
estimatedRows: 2,
columns: [
{
name: 'CustomerID',
nativeType: 'int',
normalizedType: 'integer',
dimensionType: 'number',
nullable: false,
primaryKey: true,
comment: null,
},
],
foreignKeys: [],
},
{
catalog: null,
db: 'main',
name: 'Sales.SalesOrderDetail',
kind: 'table',
comment: null,
estimatedRows: 6,
columns: [
{
name: 'SalesOrderID',
nativeType: 'int',
normalizedType: 'integer',
dimensionType: 'number',
nullable: false,
primaryKey: true,
comment: null,
},
{
name: 'SalesOrderDetailID',
nativeType: 'int',
normalizedType: 'integer',
dimensionType: 'number',
nullable: false,
primaryKey: true,
comment: null,
},
],
foreignKeys: [
{
fromColumn: 'SalesOrderID',
toCatalog: null,
toDb: 'main',
toTable: 'Sales.SalesOrderHeader',
toColumn: 'SalesOrderID',
constraintName: 'FK_SalesOrderDetail_SalesOrderHeader_SalesOrderID',
},
],
},
],
});
assert.deepEqual(expected.expectedPks, [
{ table: 'Sales.Customer', columns: ['CustomerID'] },
{ table: 'Sales.SalesOrderDetail', columns: ['SalesOrderID', 'SalesOrderDetailID'] },
{ table: 'Sales.SalesOrderHeader', columns: ['SalesOrderID'] },
]);
assert.deepEqual(expected.expectedLinks, [
{
fromTable: 'Sales.SalesOrderDetail',
fromColumns: ['SalesOrderID'],
toTable: 'Sales.SalesOrderHeader',
toColumns: ['SalesOrderID'],
relationship: 'many_to_one',
},
{
fromTable: 'Sales.SalesOrderHeader',
fromColumns: ['CustomerID'],
toTable: 'Sales.Customer',
toColumns: ['CustomerID'],
relationship: 'many_to_one',
},
]);
});
it('exposes relationship benchmarks as an explicit CLI package script', async () => {
const packageJson = JSON.parse(await readFile(new URL('../packages/cli/package.json', import.meta.url), 'utf8'));
assert.equal(
packageJson.scripts['relationships:benchmarks:test'],
'KTX_RUN_RELATIONSHIP_BENCHMARKS=1 vitest run src/context/scan/relationship-benchmarks.test.ts',
);
});
});