ktx/packages/cli/test/viz-fallback.test.ts
Andrey Avtomonov 56985b7e09
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract

* test(cli): keep dialect edge tests focused

* fix(cli): stabilize dialect contract foundation

* refactor(connectors): own read-only query preparation

* refactor(connectors): resolve dialects through registry

* refactor(connectors): keep concrete dialect classes internal

* chore(workspace): enforce dialect import boundary

* refactor(cli): resolve relationship dialect at scan boundary

* refactor(cli): use dialect display parsing for entity details

* refactor(cli): use dialect display parsing for warehouse catalog

* refactor(cli): use dialect SQL in relationship workflows

* test(cli): verify solid dialect scan workflow closure

* test: split cli tests from source tree

* refactor(cli): standardize BigQuery scope listing

* feat(sqlite): implement connector scope listing

* test(connectors): cover required table listing

* feat(cli): add warehouse driver registry

* refactor(setup): route scope discovery through driver registry

* refactor(cli): route local query execution through driver registry

* refactor(historic-sql): route dialect support through driver registry

* refactor(cli): test warehouse connections through driver registry

* fix(cli): close driver registry type export gaps

* Improve setup daemon diagnostics

* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback

Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.

* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match

The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.

Align the picker boundary with the canonical 3-level KtxTableRef:

- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
  resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
  (resolveEnabledTables already accepts the 3-part shape) and
  schemasFromEnabledTables now goes through parseDottedTableEntry so it
  recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
  reuse.

Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).

* fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00

120 lines
3.7 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest';
import {
rendererUnavailableVizFallback,
resetVizFallbackWarningsForTest,
resolveVizFallback,
warnVizFallbackOnce,
} from '../src/viz-fallback.js';
function io(options: { stdoutTty?: boolean; stdinTty?: boolean; rawMode?: boolean }) {
return {
stdin: {
isTTY: options.stdinTty,
...(options.rawMode === false ? {} : { setRawMode: vi.fn() }),
},
stdout: { isTTY: options.stdoutTty },
stderr: { write: vi.fn() },
};
}
describe('resolveVizFallback', () => {
beforeEach(() => {
resetVizFallbackWarningsForTest();
});
it('degrades when stdout is not an interactive terminal', () => {
expect(resolveVizFallback(io({ stdoutTty: false }), { TERM: 'xterm-256color' })).toEqual({
shouldDegrade: true,
reason: 'stdout-not-tty',
message: 'stdout is not an interactive terminal',
});
});
it('degrades when TERM is dumb even if stdout is a TTY', () => {
expect(resolveVizFallback(io({ stdoutTty: true }), { TERM: 'dumb' })).toEqual({
shouldDegrade: true,
reason: 'term-dumb',
message: 'TERM=dumb does not support the visual renderer',
});
});
it('allows visualization for a normal TTY', () => {
expect(resolveVizFallback(io({ stdoutTty: true }), { TERM: 'xterm-256color' })).toEqual({
shouldDegrade: false,
});
});
it('allows snapshot visualization when interactive input is not required', () => {
expect(
resolveVizFallback(
io({ stdoutTty: true, stdinTty: false, rawMode: false }),
{ TERM: 'xterm-256color' },
{ requireInput: false },
),
).toEqual({
shouldDegrade: false,
});
});
it('degrades when interactive input is required but stdin is not a TTY', () => {
expect(
resolveVizFallback(
io({ stdoutTty: true, stdinTty: false }),
{ TERM: 'xterm-256color' },
{ requireInput: true },
),
).toEqual({
shouldDegrade: true,
reason: 'stdin-not-tty',
message: 'stdin is not an interactive terminal',
});
});
it('degrades when interactive input is required but stdin raw mode is unavailable', () => {
expect(
resolveVizFallback(
io({ stdoutTty: true, stdinTty: true, rawMode: false }),
{ TERM: 'xterm-256color' },
{ requireInput: true },
),
).toEqual({
shouldDegrade: true,
reason: 'stdin-raw-mode-unavailable',
message: 'stdin raw mode is unavailable',
});
});
it('warns only once per fallback reason', () => {
const testIo = io({ stdoutTty: false });
const decision = resolveVizFallback(testIo, { TERM: 'xterm-256color' });
warnVizFallbackOnce(testIo, decision);
warnVizFallbackOnce(testIo, decision);
warnVizFallbackOnce(testIo, rendererUnavailableVizFallback());
warnVizFallbackOnce(testIo, rendererUnavailableVizFallback());
warnVizFallbackOnce(testIo, {
shouldDegrade: true,
reason: 'stdin-raw-mode-unavailable',
message: 'stdin raw mode is unavailable',
});
warnVizFallbackOnce(testIo, {
shouldDegrade: true,
reason: 'stdin-raw-mode-unavailable',
message: 'stdin raw mode is unavailable',
});
expect(testIo.stderr.write).toHaveBeenCalledTimes(3);
expect(testIo.stderr.write).toHaveBeenNthCalledWith(
1,
'Visualization requested but stdout is not an interactive terminal; printing plain output.\n',
);
expect(testIo.stderr.write).toHaveBeenNthCalledWith(
2,
'Visualization requested but the terminal renderer is unavailable; printing plain output.\n',
);
expect(testIo.stderr.write).toHaveBeenNthCalledWith(
3,
'Visualization requested but stdin raw mode is unavailable; printing plain output.\n',
);
});
});