mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
314 lines
12 KiB
TypeScript
314 lines
12 KiB
TypeScript
import { mkdir, mkdtemp, readFile, rm, stat, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { readKtxSetupState } from '../src/context/project/setup-config.js';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { gray } from '../src/io/symbols.js';
|
|
import { type KtxSetupProjectPromptAdapter, runKtxSetupProjectStep } from '../src/setup-project.js';
|
|
|
|
function makeIo(options: { stdoutIsTty?: boolean } = {}) {
|
|
let stdout = '';
|
|
let stderr = '';
|
|
return {
|
|
io: {
|
|
stdout: {
|
|
isTTY: options.stdoutIsTty,
|
|
write: (chunk: string) => {
|
|
stdout += chunk;
|
|
},
|
|
},
|
|
stderr: {
|
|
write: (chunk: string) => {
|
|
stderr += chunk;
|
|
},
|
|
},
|
|
},
|
|
stdout: () => stdout,
|
|
stderr: () => stderr,
|
|
};
|
|
}
|
|
|
|
function makePromptAdapter(options: { choice?: string; choices?: string[]; textValue?: string; textValues?: string[] }) {
|
|
const choices = [...(options.choices ?? (options.choice ? [options.choice] : []))];
|
|
const textValues = [...(options.textValues ?? (options.textValue !== undefined ? [options.textValue] : []))];
|
|
return {
|
|
select: vi.fn(async () => choices.shift() ?? 'exit'),
|
|
text: vi.fn(async () => textValues.shift() ?? ''),
|
|
cancel: vi.fn(),
|
|
} satisfies KtxSetupProjectPromptAdapter;
|
|
}
|
|
|
|
function defaultSubfolderLabel(parentDir: string): string {
|
|
const childName = 'ktx-project';
|
|
const childDir = join(parentDir, childName);
|
|
return `New subfolder (${gray(childDir.slice(0, -childName.length))}${childName})`;
|
|
}
|
|
|
|
describe('setup project step', () => {
|
|
let tempDir: string;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-setup-project-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('creates a new project in non-interactive auto mode with --yes and marks the project step complete', async () => {
|
|
const projectDir = join(tempDir, 'warehouse');
|
|
const testIo = makeIo();
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir, mode: 'auto', inputMode: 'disabled', yes: true },
|
|
testIo.io,
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
expect(await readFile(join(projectDir, 'ktx.yaml'), 'utf-8')).not.toContain('completed_steps:');
|
|
expect(await readKtxSetupState(projectDir)).toEqual({ completed_steps: ['project'] });
|
|
await expect(stat(join(projectDir, '.git'))).resolves.toBeDefined();
|
|
await expect(readFile(join(projectDir, '.ktx/.gitignore'), 'utf-8')).resolves.toContain('secrets/');
|
|
expect(testIo.stdout()).toContain(`Project: ${projectDir}`);
|
|
expect(testIo.stderr()).toBe('');
|
|
});
|
|
|
|
it('creates a missing auto-mode project only when --yes is present in no-input mode', async () => {
|
|
const projectDir = join(tempDir, 'warehouse');
|
|
const rejectedIo = makeIo();
|
|
const acceptedIo = makeIo();
|
|
|
|
await expect(
|
|
runKtxSetupProjectStep({ projectDir, mode: 'auto', inputMode: 'disabled', yes: false }, rejectedIo.io),
|
|
).resolves.toMatchObject({ status: 'missing-input' });
|
|
expect(rejectedIo.stderr()).toContain('Missing setup choice: pass --yes');
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).rejects.toThrow();
|
|
|
|
await expect(
|
|
runKtxSetupProjectStep({ projectDir, mode: 'auto', inputMode: 'disabled', yes: true }, acceptedIo.io),
|
|
).resolves.toMatchObject({ status: 'ready', projectDir });
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).resolves.toBeDefined();
|
|
});
|
|
|
|
it('fails clearly in no-input auto mode when ktx.yaml is missing and --yes is absent', async () => {
|
|
const projectDir = join(tempDir, 'warehouse');
|
|
const testIo = makeIo();
|
|
|
|
await expect(
|
|
runKtxSetupProjectStep({ projectDir, mode: 'auto', inputMode: 'disabled', yes: false }, testIo.io),
|
|
).resolves.toMatchObject({ status: 'missing-input' });
|
|
|
|
expect(testIo.stderr()).toContain('Missing setup choice: pass --yes');
|
|
});
|
|
|
|
it('prompts to use the current directory and creates a project in interactive auto mode', async () => {
|
|
const projectDir = join(tempDir, 'warehouse');
|
|
const prompts = makePromptAdapter({ choice: 'current' });
|
|
const testIo = makeIo({ stdoutIsTty: true });
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
testIo.io,
|
|
{ prompts },
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
expect(prompts.select).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'Where should KTX create the project?',
|
|
options: [
|
|
expect.objectContaining({ value: 'current', label: `Current directory (${projectDir})` }),
|
|
expect.objectContaining({
|
|
value: 'new-default',
|
|
label: defaultSubfolderLabel(projectDir),
|
|
}),
|
|
expect.objectContaining({ value: 'new-custom', label: 'Custom path' }),
|
|
expect.objectContaining({ value: 'exit', label: 'Exit' }),
|
|
],
|
|
}),
|
|
);
|
|
expect(prompts.text).not.toHaveBeenCalled();
|
|
expect(await readFile(join(projectDir, 'ktx.yaml'), 'utf-8')).not.toContain('completed_steps:');
|
|
expect(await readKtxSetupState(projectDir)).toEqual({ completed_steps: ['project'] });
|
|
});
|
|
|
|
it('offers an absolute default destination for a new project folder', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const projectDir = join(startDir, 'ktx-project');
|
|
const prompts = makePromptAdapter({ choices: ['new-default', 'create'] });
|
|
const testIo = makeIo({ stdoutIsTty: true });
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
testIo.io,
|
|
{ prompts },
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
expect(prompts.select).toHaveBeenNthCalledWith(
|
|
1,
|
|
expect.objectContaining({
|
|
message: 'Where should KTX create the project?',
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
value: 'new-default',
|
|
label: defaultSubfolderLabel(startDir),
|
|
}),
|
|
]),
|
|
}),
|
|
);
|
|
expect(prompts.select).toHaveBeenNthCalledWith(
|
|
2,
|
|
expect.objectContaining({ message: `Create KTX project at ${projectDir}?` }),
|
|
);
|
|
expect(prompts.text).not.toHaveBeenCalled();
|
|
expect(result.status === 'ready' ? result.project.configPath : '').toBe(join(projectDir, 'ktx.yaml'));
|
|
expect(testIo.stdout()).toContain(`│ KTX will create:\n│ ${projectDir}`);
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).resolves.toBeDefined();
|
|
});
|
|
|
|
it('prompts for a custom path and resolves it inside the current setup directory', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const projectDir = join(startDir, 'analytics-ktx');
|
|
const prompts = makePromptAdapter({ choices: ['new-custom', 'create'], textValue: 'analytics-ktx' });
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
makeIo({ stdoutIsTty: true }).io,
|
|
{ prompts },
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
expect(prompts.text).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'Project folder path\n│ Press Escape to go back.\n│',
|
|
placeholder: './analytics-ktx, ~/analytics-ktx, or /Users/you/projects/analytics-ktx',
|
|
}),
|
|
);
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).resolves.toBeDefined();
|
|
});
|
|
|
|
it('expands a custom home-directory path before creating a new project', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const homeDir = join(tempDir, 'home');
|
|
const projectDir = join(homeDir, 'analytics-ktx');
|
|
const prompts = makePromptAdapter({ choices: ['new-custom', 'create'], textValue: '~/analytics-ktx' });
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
makeIo({ stdoutIsTty: true }).io,
|
|
{ prompts, homeDir },
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).resolves.toBeDefined();
|
|
});
|
|
|
|
it('confirms a custom new project path and lets Back return to the project choice', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const homeDir = join(tempDir, 'home');
|
|
const customProjectDir = join(homeDir, 'analytics-ktx');
|
|
const prompts = makePromptAdapter({
|
|
choices: ['new-custom', 'back', 'exit'],
|
|
textValue: '~/analytics-ktx',
|
|
});
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
makeIo({ stdoutIsTty: true }).io,
|
|
{ prompts, homeDir },
|
|
);
|
|
|
|
expect(result.status).toBe('cancelled');
|
|
expect(result.projectDir).toBe(startDir);
|
|
expect(prompts.select).toHaveBeenNthCalledWith(
|
|
2,
|
|
expect.objectContaining({
|
|
message: `Create KTX project at ${customProjectDir}?`,
|
|
options: [
|
|
expect.objectContaining({ value: 'create', label: 'Create project' }),
|
|
expect.objectContaining({ value: 'choose-another', label: 'Choose another folder' }),
|
|
expect.objectContaining({ value: 'back', label: 'Back' }),
|
|
],
|
|
}),
|
|
);
|
|
expect(prompts.select).toHaveBeenNthCalledWith(
|
|
3,
|
|
expect.objectContaining({ message: 'Where should KTX create the project?' }),
|
|
);
|
|
await expect(stat(join(customProjectDir, 'ktx.yaml'))).rejects.toThrow();
|
|
});
|
|
|
|
it('rejects an empty new folder path without creating a project in the process cwd', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const prompts = makePromptAdapter({ choices: ['new-custom'], textValue: ' ' });
|
|
const initProject = vi.fn(async () => {
|
|
throw new Error('initProject should not run for an empty path');
|
|
});
|
|
const testIo = makeIo({ stdoutIsTty: true });
|
|
|
|
await expect(
|
|
runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
testIo.io,
|
|
{ prompts, initProject },
|
|
),
|
|
).resolves.toMatchObject({ status: 'missing-input', projectDir: startDir });
|
|
|
|
expect(initProject).not.toHaveBeenCalled();
|
|
expect(testIo.stderr()).toContain(
|
|
'Enter a relative path like ./analytics-ktx, a home path like ~/analytics-ktx, or an absolute path.',
|
|
);
|
|
});
|
|
|
|
it('confirms before creating KTX files inside an existing non-empty folder', async () => {
|
|
const startDir = join(tempDir, 'start');
|
|
const projectDir = join(startDir, 'analytics-ktx');
|
|
await mkdir(projectDir, { recursive: true });
|
|
await writeFile(join(projectDir, 'README.md'), 'Existing project notes\n', 'utf-8');
|
|
const prompts = makePromptAdapter({ choices: ['new-custom', 'use-existing'], textValue: 'analytics-ktx' });
|
|
|
|
const result = await runKtxSetupProjectStep(
|
|
{ projectDir: startDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
makeIo({ stdoutIsTty: true }).io,
|
|
{ prompts },
|
|
);
|
|
|
|
expect(result.status).toBe('ready');
|
|
expect(result.projectDir).toBe(projectDir);
|
|
expect(prompts.select).toHaveBeenNthCalledWith(
|
|
2,
|
|
expect.objectContaining({
|
|
message: `That folder already exists and is not empty: ${projectDir}`,
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({ value: 'use-existing', label: 'Yes, create KTX files there' }),
|
|
expect.objectContaining({ value: 'choose-another', label: 'Choose another folder' }),
|
|
]),
|
|
}),
|
|
);
|
|
await expect(readFile(join(projectDir, 'README.md'), 'utf-8')).resolves.toBe('Existing project notes\n');
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).resolves.toBeDefined();
|
|
});
|
|
|
|
it('prompts to exit and returns cancelled in interactive auto mode', async () => {
|
|
const projectDir = join(tempDir, 'warehouse');
|
|
const prompts = makePromptAdapter({ choice: 'exit' });
|
|
|
|
await expect(
|
|
runKtxSetupProjectStep(
|
|
{ projectDir, mode: 'auto', inputMode: 'auto', yes: false },
|
|
makeIo({ stdoutIsTty: true }).io,
|
|
{ prompts },
|
|
),
|
|
).resolves.toMatchObject({ status: 'cancelled', projectDir });
|
|
|
|
expect(prompts.cancel).toHaveBeenCalledWith('Setup cancelled.');
|
|
expect(prompts.text).not.toHaveBeenCalled();
|
|
await expect(stat(join(projectDir, 'ktx.yaml'))).rejects.toThrow();
|
|
});
|
|
});
|