mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
74 lines
2.4 KiB
TypeScript
74 lines
2.4 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import { findDanglingWikiRefsForActions } from '../../../src/context/wiki/wiki-ref-validation.js';
|
|
|
|
function makeWikiService(pages: Record<string, { refs?: string[]; content?: string }>) {
|
|
return {
|
|
listPageKeys: vi.fn().mockResolvedValue(Object.keys(pages)),
|
|
readPage: vi.fn().mockImplementation((_scope: string, _scopeId: string | null, pageKey: string) => {
|
|
const page = pages[pageKey];
|
|
if (!page) {
|
|
return Promise.resolve(null);
|
|
}
|
|
return Promise.resolve({
|
|
pageKey,
|
|
frontmatter: { summary: pageKey, usage_mode: 'auto', refs: page.refs },
|
|
content: page.content ?? '',
|
|
});
|
|
}),
|
|
};
|
|
}
|
|
|
|
describe('wiki ref validation', () => {
|
|
it('allows circular refs once both touched pages exist', async () => {
|
|
const wikiService = makeWikiService({
|
|
'page-a': { refs: ['page-b'], content: 'See [[page-b]].' },
|
|
'page-b': { refs: ['page-a'], content: 'See [[page-a]].' },
|
|
});
|
|
|
|
const dangling = await findDanglingWikiRefsForActions({
|
|
wikiService: wikiService as any,
|
|
scope: 'GLOBAL',
|
|
scopeId: null,
|
|
actions: [
|
|
{ target: 'wiki', type: 'created', key: 'page-a', detail: 'Page A' },
|
|
{ target: 'wiki', type: 'created', key: 'page-b', detail: 'Page B' },
|
|
],
|
|
});
|
|
|
|
expect(dangling).toEqual([]);
|
|
});
|
|
|
|
it('treats removed pages as unavailable ref targets', async () => {
|
|
const wikiService = makeWikiService({
|
|
'page-a': { refs: ['page-b'], content: 'See [[page-b]].' },
|
|
});
|
|
|
|
const dangling = await findDanglingWikiRefsForActions({
|
|
wikiService: wikiService as any,
|
|
scope: 'GLOBAL',
|
|
scopeId: null,
|
|
actions: [
|
|
{ target: 'wiki', type: 'updated', key: 'page-a', detail: 'Page A' },
|
|
{ target: 'wiki', type: 'removed', key: 'page-b', detail: 'Page B' },
|
|
],
|
|
});
|
|
|
|
expect(dangling).toEqual(['page-a -> page-b']);
|
|
});
|
|
|
|
it('does not validate existing dangling refs on untouched pages', async () => {
|
|
const wikiService = makeWikiService({
|
|
'page-a': { refs: [], content: '' },
|
|
'old-page': { refs: ['missing-page'], content: 'See [[missing-page]].' },
|
|
});
|
|
|
|
const dangling = await findDanglingWikiRefsForActions({
|
|
wikiService: wikiService as any,
|
|
scope: 'GLOBAL',
|
|
scopeId: null,
|
|
actions: [{ target: 'wiki', type: 'updated', key: 'page-a', detail: 'Page A' }],
|
|
});
|
|
|
|
expect(dangling).toEqual([]);
|
|
});
|
|
});
|