mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
97 lines
3.1 KiB
TypeScript
97 lines
3.1 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { assertPatchAllowedForWorkUnit, parsePatchTouchedPaths, textArtifactRoots } from '../../../../src/context/ingest/isolated-diff/git-patch.js';
|
|
|
|
describe('isolated diff patch contract', () => {
|
|
it('parses touched paths from no-rename git patches', () => {
|
|
const patch = [
|
|
'diff --git a/wiki/global/a.md b/wiki/global/a.md',
|
|
'index 1111111..2222222 100644',
|
|
'--- a/wiki/global/a.md',
|
|
'+++ b/wiki/global/a.md',
|
|
'@@ -1 +1 @@',
|
|
'-old',
|
|
'+new',
|
|
'diff --git a/semantic-layer/c1/orders.yaml b/semantic-layer/c1/orders.yaml',
|
|
'new file mode 100644',
|
|
'--- /dev/null',
|
|
'+++ b/semantic-layer/c1/orders.yaml',
|
|
'@@ -0,0 +1 @@',
|
|
'+name: orders',
|
|
'',
|
|
].join('\n');
|
|
|
|
expect(parsePatchTouchedPaths(patch)).toEqual([
|
|
{
|
|
path: 'wiki/global/a.md',
|
|
oldPath: 'wiki/global/a.md',
|
|
newPath: 'wiki/global/a.md',
|
|
mode: '100644',
|
|
binary: false,
|
|
},
|
|
{
|
|
path: 'semantic-layer/c1/orders.yaml',
|
|
oldPath: 'semantic-layer/c1/orders.yaml',
|
|
newPath: 'semantic-layer/c1/orders.yaml',
|
|
mode: '100644',
|
|
binary: false,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('rejects semantic-layer paths for slDisallowed work units', () => {
|
|
const patch = 'diff --git a/semantic-layer/c1/orders.yaml b/semantic-layer/c1/orders.yaml\nindex 1..2 100644\n';
|
|
|
|
expect(() =>
|
|
assertPatchAllowedForWorkUnit({
|
|
unitKey: 'lookml-mismatch',
|
|
patch,
|
|
slDisallowed: true,
|
|
}),
|
|
).toThrow(/slDisallowed WorkUnit lookml-mismatch touched semantic-layer\/c1\/orders.yaml/);
|
|
});
|
|
|
|
it('rejects semantic-layer paths outside allowed target connections', () => {
|
|
const patch =
|
|
'diff --git a/semantic-layer/finance/orders.yaml b/semantic-layer/finance/orders.yaml\nindex 1..2 100644\n';
|
|
|
|
expect(() =>
|
|
assertPatchAllowedForWorkUnit({
|
|
unitKey: 'wu-finance',
|
|
patch,
|
|
slDisallowed: false,
|
|
allowedTargetConnectionIds: new Set(['warehouse']),
|
|
}),
|
|
).toThrow(
|
|
/semantic-layer target connection not allowed: semantic-layer\/finance\/orders.yaml \(finance\); allowed: warehouse/,
|
|
);
|
|
});
|
|
|
|
it('rejects executable and binary changes under known text artifact roots', () => {
|
|
expect(textArtifactRoots).toEqual(['wiki/', 'semantic-layer/']);
|
|
|
|
const executablePatch =
|
|
'diff --git a/wiki/global/a.md b/wiki/global/a.md\nold mode 100644\nnew mode 100755\nindex 1..2\n';
|
|
expect(() =>
|
|
assertPatchAllowedForWorkUnit({
|
|
unitKey: 'wu-1',
|
|
patch: executablePatch,
|
|
slDisallowed: false,
|
|
}),
|
|
).toThrow(/unexpected executable mode under wiki\/global\/a.md/);
|
|
|
|
const binaryPatch = [
|
|
'diff --git a/semantic-layer/c1/orders.yaml b/semantic-layer/c1/orders.yaml',
|
|
'index 1111111..2222222 100644',
|
|
'GIT binary patch',
|
|
'literal 0',
|
|
'',
|
|
].join('\n');
|
|
expect(() =>
|
|
assertPatchAllowedForWorkUnit({
|
|
unitKey: 'wu-2',
|
|
patch: binaryPatch,
|
|
slDisallowed: false,
|
|
}),
|
|
).toThrow(/unexpected binary patch under semantic-layer\/c1\/orders.yaml/);
|
|
});
|
|
});
|