mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
139 lines
4.2 KiB
TypeScript
139 lines
4.2 KiB
TypeScript
import { mkdtemp, rm } from 'node:fs/promises';
|
|
import { writeFileSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import Database from 'better-sqlite3';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { createSqliteQueryExecutor, sqliteDatabasePathFromConnection } from '../../../src/context/connections/sqlite-query-executor.js';
|
|
|
|
describe('createSqliteQueryExecutor', () => {
|
|
let tempDir: string;
|
|
let dbPath: string;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-sqlite-query-'));
|
|
dbPath = join(tempDir, 'warehouse.db');
|
|
const db = new Database(dbPath);
|
|
db.exec(`
|
|
CREATE TABLE orders (
|
|
id INTEGER PRIMARY KEY,
|
|
status TEXT NOT NULL,
|
|
amount INTEGER NOT NULL
|
|
);
|
|
INSERT INTO orders (status, amount) VALUES
|
|
('paid', 20),
|
|
('paid', 30),
|
|
('open', 10);
|
|
`);
|
|
db.close();
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('executes read-only SELECT SQL against a relative SQLite path', async () => {
|
|
const executor = createSqliteQueryExecutor();
|
|
|
|
const result = await executor.execute({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite', path: 'warehouse.db' },
|
|
sql: 'select status, count(*) as order_count from orders group by status order by status',
|
|
maxRows: 10,
|
|
});
|
|
|
|
expect(result).toEqual({
|
|
headers: ['status', 'order_count'],
|
|
rows: [
|
|
['open', 1],
|
|
['paid', 2],
|
|
],
|
|
totalRows: 2,
|
|
command: 'SELECT',
|
|
rowCount: 2,
|
|
});
|
|
});
|
|
|
|
it('supports file urls for SQLite database paths', async () => {
|
|
expect(
|
|
sqliteDatabasePathFromConnection({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite', url: `file://${dbPath}` },
|
|
sql: 'select 1',
|
|
}),
|
|
).toBe(dbPath);
|
|
});
|
|
|
|
it('resolves file references for SQLite path fields', async () => {
|
|
const pointerPath = join(tempDir, 'sqlite-path.txt');
|
|
writeFileSync(pointerPath, dbPath, 'utf-8');
|
|
|
|
expect(
|
|
sqliteDatabasePathFromConnection({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite', path: `file:${pointerPath}` },
|
|
sql: 'select 1',
|
|
}),
|
|
).toBe(dbPath);
|
|
});
|
|
|
|
it('resolves env references for SQLite database urls', async () => {
|
|
const originalDatabaseUrl = process.env.KTX_SQLITE_TEST_URL;
|
|
process.env.KTX_SQLITE_TEST_URL = `sqlite:${dbPath}`;
|
|
|
|
try {
|
|
expect(
|
|
sqliteDatabasePathFromConnection({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite', url: 'env:KTX_SQLITE_TEST_URL' },
|
|
sql: 'select 1',
|
|
}),
|
|
).toBe(dbPath);
|
|
} finally {
|
|
if (originalDatabaseUrl === undefined) {
|
|
delete process.env.KTX_SQLITE_TEST_URL;
|
|
} else {
|
|
process.env.KTX_SQLITE_TEST_URL = originalDatabaseUrl;
|
|
}
|
|
}
|
|
});
|
|
|
|
it('rejects mutating SQL before opening the database', async () => {
|
|
const executor = createSqliteQueryExecutor();
|
|
|
|
await expect(
|
|
executor.execute({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite', path: 'warehouse.db' },
|
|
sql: 'delete from orders',
|
|
}),
|
|
).rejects.toThrow('Only read-only SELECT/WITH queries can be executed locally');
|
|
});
|
|
|
|
it('requires a SQLite driver and a database path', async () => {
|
|
const executor = createSqliteQueryExecutor();
|
|
|
|
await expect(
|
|
executor.execute({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'postgres', path: 'warehouse.db' },
|
|
sql: 'select 1',
|
|
}),
|
|
).rejects.toThrow('Local SQLite execution cannot run driver "postgres"');
|
|
|
|
await expect(
|
|
executor.execute({
|
|
connectionId: 'warehouse',
|
|
projectDir: tempDir,
|
|
connection: { driver: 'sqlite' },
|
|
sql: 'select 1',
|
|
}),
|
|
).rejects.toThrow('Local SQLite execution requires connections.warehouse.path or connections.warehouse.url');
|
|
});
|
|
});
|