mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
66 lines
2.5 KiB
JavaScript
66 lines
2.5 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import { readdir, readFile } from 'node:fs/promises';
|
|
import { describe, it } from 'node:test';
|
|
|
|
const KTX_ROOT = new URL('../', import.meta.url);
|
|
|
|
const RELATIONSHIP_RUNTIME_SOURCES = Object.freeze([
|
|
'packages/cli/src/context/scan/relationship-benchmarks.ts',
|
|
'packages/cli/src/context/scan/relationship-budget.ts',
|
|
'packages/cli/src/context/scan/relationship-candidates.ts',
|
|
'packages/cli/src/context/scan/relationship-composite-candidates.ts',
|
|
'packages/cli/src/context/scan/relationship-graph-resolver.ts',
|
|
'packages/cli/src/context/scan/relationship-locality.ts',
|
|
'packages/cli/src/context/scan/relationship-name-similarity.ts',
|
|
'packages/cli/src/context/scan/relationship-discovery.ts',
|
|
'packages/cli/src/context/scan/relationship-profiling.ts',
|
|
'packages/cli/src/context/scan/relationship-scoring.ts',
|
|
'packages/cli/src/context/scan/relationship-validation.ts',
|
|
]);
|
|
|
|
async function checkedInFixtureIds() {
|
|
const fixtureRoot = new URL('packages/cli/test/fixtures/relationship-benchmarks/', KTX_ROOT);
|
|
const entries = await readdir(fixtureRoot, { withFileTypes: true });
|
|
return entries
|
|
.filter((entry) => entry.isDirectory())
|
|
.map((entry) => entry.name)
|
|
.sort((left, right) => left.localeCompare(right));
|
|
}
|
|
|
|
async function readRuntimeSources() {
|
|
return Promise.all(
|
|
RELATIONSHIP_RUNTIME_SOURCES.map(async (relativePath) => ({
|
|
relativePath,
|
|
source: await readFile(new URL(relativePath, KTX_ROOT), 'utf8'),
|
|
})),
|
|
);
|
|
}
|
|
|
|
describe('relationship evidence-fusion source guardrails', () => {
|
|
it('keeps runtime relationship modules free of fixture-id conditionals', async () => {
|
|
const fixtureIds = await checkedInFixtureIds();
|
|
const sources = await readRuntimeSources();
|
|
const hits = [];
|
|
|
|
for (const { relativePath, source } of sources) {
|
|
for (const fixtureId of fixtureIds) {
|
|
if (source.includes(fixtureId)) {
|
|
hits.push(`${relativePath}: ${fixtureId}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
assert.deepEqual(hits, []);
|
|
});
|
|
|
|
it('keeps runtime relationship modules free of length-threshold drop-all cliffs', async () => {
|
|
const sources = await readRuntimeSources();
|
|
const dropAllPattern = /if\s*\([^)]*\.length\s*>\s*\d+[^)]*\)\s*(?:\{\s*)?return\s*\[\];/gs;
|
|
const hits = sources.flatMap(({ relativePath, source }) => {
|
|
const matches = Array.from(source.matchAll(dropAllPattern));
|
|
return matches.map((match) => `${relativePath}: ${match[0].replace(/\s+/g, ' ').trim()}`);
|
|
});
|
|
|
|
assert.deepEqual(hits, []);
|
|
});
|
|
});
|