mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
165 lines
4.2 KiB
TypeScript
165 lines
4.2 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
buildTelemetryEvent,
|
|
telemetryEventCatalog,
|
|
telemetryEventSchemas,
|
|
type TelemetryCommonEnvelope,
|
|
} from '../../src/telemetry/events.js';
|
|
|
|
const envelope: TelemetryCommonEnvelope = {
|
|
cliVersion: '0.4.1',
|
|
nodeVersion: 'v22.0.0',
|
|
osPlatform: 'darwin',
|
|
osRelease: '25.0.0',
|
|
arch: 'arm64',
|
|
runtime: 'node',
|
|
isCi: false,
|
|
};
|
|
|
|
describe('telemetry event schemas', () => {
|
|
it('catalogs all v1 telemetry events', () => {
|
|
expect(telemetryEventCatalog.map((event) => event.name)).toEqual([
|
|
'install_first_run',
|
|
'command',
|
|
'setup_step',
|
|
'connection_added',
|
|
'connection_test',
|
|
'project_stack_snapshot',
|
|
'ingest_completed',
|
|
'scan_completed',
|
|
'sl_validate_completed',
|
|
'sl_query_completed',
|
|
'sql_completed',
|
|
'wiki_query_completed',
|
|
'mcp_request_completed',
|
|
'daemon_started',
|
|
'daemon_stopped',
|
|
'sl_plan_completed',
|
|
'sql_gen_completed',
|
|
]);
|
|
});
|
|
|
|
it('builds strict daemon telemetry events', () => {
|
|
const daemonEnvelope = {
|
|
...envelope,
|
|
runtime: 'daemon-py' as const,
|
|
nodeVersion: '3.13.0',
|
|
};
|
|
|
|
expect(
|
|
buildTelemetryEvent('sl_plan_completed', daemonEnvelope, {
|
|
outcome: 'ok',
|
|
stage: 'transpile',
|
|
durationMs: 25,
|
|
sourceCount: 2,
|
|
joinCount: 1,
|
|
}),
|
|
).toMatchObject({
|
|
name: 'sl_plan_completed',
|
|
properties: {
|
|
runtime: 'daemon-py',
|
|
outcome: 'ok',
|
|
stage: 'transpile',
|
|
sourceCount: 2,
|
|
joinCount: 1,
|
|
},
|
|
});
|
|
|
|
expect(() =>
|
|
telemetryEventSchemas.sql_gen_completed.parse({
|
|
...daemonEnvelope,
|
|
outcome: 'ok',
|
|
dialect: 'postgres',
|
|
durationMs: 4,
|
|
sql: 'select * from private_table',
|
|
}),
|
|
).toThrow();
|
|
});
|
|
|
|
it('builds a strict install_first_run event', () => {
|
|
expect(buildTelemetryEvent('install_first_run', envelope, {})).toEqual({
|
|
name: 'install_first_run',
|
|
properties: envelope,
|
|
});
|
|
});
|
|
|
|
it('builds a strict command event with project grouping fields', () => {
|
|
expect(
|
|
buildTelemetryEvent('command', envelope, {
|
|
commandPath: ['ktx', 'status'],
|
|
durationMs: 12,
|
|
outcome: 'ok',
|
|
flagsPresent: { json: true },
|
|
hasProject: true,
|
|
projectGroupAttached: true,
|
|
}),
|
|
).toEqual({
|
|
name: 'command',
|
|
properties: {
|
|
...envelope,
|
|
commandPath: ['ktx', 'status'],
|
|
durationMs: 12,
|
|
outcome: 'ok',
|
|
flagsPresent: { json: true },
|
|
hasProject: true,
|
|
projectGroupAttached: true,
|
|
},
|
|
});
|
|
});
|
|
|
|
it('rejects unmodeled event properties', () => {
|
|
expect(() =>
|
|
telemetryEventSchemas.command.parse({
|
|
...envelope,
|
|
commandPath: ['ktx', 'status'],
|
|
durationMs: 12,
|
|
outcome: 'ok',
|
|
flagsPresent: {},
|
|
hasProject: true,
|
|
projectGroupAttached: true,
|
|
tableName: 'private_table',
|
|
}),
|
|
).toThrow();
|
|
});
|
|
|
|
it('builds strict Phase 2 events without private names or text', () => {
|
|
expect(
|
|
buildTelemetryEvent('connection_test', envelope, {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
outcome: 'ok',
|
|
durationMs: 34,
|
|
serverVersion: '16',
|
|
}),
|
|
).toMatchObject({
|
|
name: 'connection_test',
|
|
properties: {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
outcome: 'ok',
|
|
durationMs: 34,
|
|
serverVersion: '16',
|
|
},
|
|
});
|
|
|
|
expect(() =>
|
|
telemetryEventSchemas.sql_completed.parse({
|
|
...envelope,
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
queryVerb: 'select',
|
|
referencedTableCount: 1,
|
|
durationMs: 10,
|
|
outcome: 'ok',
|
|
sql: 'select * from private_table',
|
|
}),
|
|
).toThrow();
|
|
});
|
|
|
|
it('rejects raw private field names that are not in the telemetry schemas', () => {
|
|
expect(JSON.stringify(telemetryEventSchemas)).not.toContain('tableName');
|
|
expect(Object.keys(telemetryEventSchemas.sql_completed.shape)).not.toContain('sql');
|
|
expect(JSON.stringify(telemetryEventSchemas)).not.toContain('path');
|
|
});
|
|
});
|