mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
84 lines
3 KiB
TypeScript
84 lines
3 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import type { ToolContext } from '../../../../src/context/tools/base-tool.js';
|
|
import type { ToolSession } from '../../../../src/context/tools/tool-session.js';
|
|
import { createTouchedSlSources } from '../../../../src/context/tools/touched-sl-sources.js';
|
|
import type { SemanticLayerSource } from '../../../../src/context/sl/types.js';
|
|
import { SlDiscoverTool } from '../../../../src/context/sl/tools/sl-discover.tool.js';
|
|
|
|
function makeTool() {
|
|
const semanticLayerService = {
|
|
listConnectionIdsWithNames: vi.fn(async () => [] as Array<{ id: string; name: string; connectionType: string }>),
|
|
loadAllSources: vi.fn(async () => ({ sources: [] as SemanticLayerSource[], loadErrors: [] })),
|
|
};
|
|
const slSearchService = {
|
|
search: vi.fn(async () => []),
|
|
};
|
|
const tool = new SlDiscoverTool(
|
|
{
|
|
semanticLayerService: semanticLayerService as never,
|
|
slSearchService: slSearchService as never,
|
|
authorResolver: { resolve: vi.fn() },
|
|
},
|
|
{ maxSources: 25, minRrfScore: 0, maxDetailedSources: 5 },
|
|
);
|
|
return { tool, semanticLayerService, slSearchService };
|
|
}
|
|
|
|
function makeContext(overrides: Partial<ToolContext> = {}): ToolContext {
|
|
return {
|
|
sourceId: 'src',
|
|
messageId: 'msg',
|
|
userId: 'user',
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeSession(semanticLayerService: Record<string, unknown>): ToolSession {
|
|
return {
|
|
connectionId: 'dbt-main',
|
|
isWorktreeScoped: true,
|
|
preHead: 'base',
|
|
touchedSlSources: createTouchedSlSources(),
|
|
actions: [],
|
|
semanticLayerService: semanticLayerService as never,
|
|
wikiService: {} as never,
|
|
configService: {} as never,
|
|
gitService: {} as never,
|
|
};
|
|
}
|
|
|
|
describe('SlDiscoverTool - session-scoped reads', () => {
|
|
it('discovers sources through context.session.semanticLayerService when a session is present', async () => {
|
|
const { tool, semanticLayerService } = makeTool();
|
|
const sessionSemanticLayerService = {
|
|
listConnectionIdsWithNames: vi.fn().mockResolvedValue([
|
|
{ id: 'warehouse', name: 'warehouse', connectionType: 'postgres' },
|
|
]),
|
|
loadAllSources: vi.fn().mockResolvedValue({
|
|
sources: [
|
|
{
|
|
name: 'orders',
|
|
table: 'public.orders',
|
|
grain: ['order_id'],
|
|
columns: [{ name: 'order_id', type: 'string' }],
|
|
measures: [],
|
|
joins: [],
|
|
},
|
|
],
|
|
loadErrors: [],
|
|
}),
|
|
};
|
|
|
|
const result = await tool.call({}, makeContext({ session: makeSession(sessionSemanticLayerService) }));
|
|
|
|
expect(result.structured.totalSources).toBe(1);
|
|
expect(result.structured.sources[0]).toMatchObject({
|
|
connectionId: 'warehouse',
|
|
name: 'orders',
|
|
columnCount: 1,
|
|
});
|
|
expect(sessionSemanticLayerService.listConnectionIdsWithNames).toHaveBeenCalled();
|
|
expect(sessionSemanticLayerService.loadAllSources).toHaveBeenCalledWith('warehouse');
|
|
expect(semanticLayerService.listConnectionIdsWithNames).not.toHaveBeenCalled();
|
|
});
|
|
});
|