mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
67 lines
2.6 KiB
TypeScript
67 lines
2.6 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
scopedTableNames,
|
|
tableRefFromKey,
|
|
tableRefKey,
|
|
tableRefSet,
|
|
type KtxTableRefKey,
|
|
} from '../../../src/context/scan/table-ref.js';
|
|
|
|
describe('tableRefKey roundtrip', () => {
|
|
it('encodes and decodes a three-part ref', () => {
|
|
const ref = { catalog: 'ANALYTICS', db: 'MARTS', name: 'LISTINGS' };
|
|
expect(tableRefFromKey(tableRefKey(ref))).toEqual(ref);
|
|
});
|
|
|
|
it('treats null catalog/db as the empty segment', () => {
|
|
const ref = { catalog: null, db: 'public', name: 'users' };
|
|
expect(tableRefFromKey(tableRefKey(ref))).toEqual(ref);
|
|
});
|
|
|
|
it('roundtrips a bare-name ref', () => {
|
|
const ref = { catalog: null, db: null, name: 'orders' };
|
|
expect(tableRefFromKey(tableRefKey(ref))).toEqual(ref);
|
|
});
|
|
});
|
|
|
|
describe('tableRefSet', () => {
|
|
it('produces a set with member-equality on canonical keys', () => {
|
|
const scope = tableRefSet([
|
|
{ catalog: 'ANALYTICS', db: 'MARTS', name: 'LISTINGS' },
|
|
{ catalog: 'ANALYTICS', db: 'MARTS', name: 'ITEMS' },
|
|
]);
|
|
expect(scope.size).toBe(2);
|
|
expect(scope.has(tableRefKey({ catalog: 'ANALYTICS', db: 'MARTS', name: 'LISTINGS' }))).toBe(true);
|
|
expect(scope.has(tableRefKey({ catalog: 'ANALYTICS', db: 'MARTS', name: 'OTHER' }))).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('scopedTableNames', () => {
|
|
it('projects to the requested (catalog, db) namespace', () => {
|
|
const scope = tableRefSet([
|
|
{ catalog: 'ANALYTICS', db: 'MARTS', name: 'LISTINGS' },
|
|
{ catalog: 'ANALYTICS', db: 'MARTS', name: 'ITEMS' },
|
|
{ catalog: 'ANALYTICS', db: 'STAGING', name: 'LISTINGS' },
|
|
]);
|
|
expect(scopedTableNames(scope, { catalog: 'ANALYTICS', db: 'MARTS' }).sort()).toEqual(['ITEMS', 'LISTINGS']);
|
|
expect(scopedTableNames(scope, { catalog: 'ANALYTICS', db: 'STAGING' })).toEqual(['LISTINGS']);
|
|
});
|
|
|
|
it('requires non-null scope segments to match the namespace', () => {
|
|
const scope = tableRefSet([{ catalog: null, db: 'public', name: 'users' }]);
|
|
expect(scopedTableNames(scope, { catalog: 'any-catalog', db: 'public' })).toEqual([]);
|
|
});
|
|
|
|
it('returns empty when no scope entry matches the namespace', () => {
|
|
const scope = tableRefSet([{ catalog: 'A', db: 'B', name: 'C' }]);
|
|
expect(scopedTableNames(scope, { catalog: 'X', db: 'Y' })).toEqual([]);
|
|
});
|
|
|
|
it('dedupes exact namespace matches only', () => {
|
|
const scope: ReadonlySet<KtxTableRefKey> = tableRefSet([
|
|
{ catalog: null, db: 'public', name: 'users' },
|
|
{ catalog: 'A', db: 'public', name: 'users' },
|
|
]);
|
|
expect(scopedTableNames(scope, { catalog: 'A', db: 'public' })).toEqual(['users']);
|
|
});
|
|
});
|