mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { applyKtxRelationshipValidationBudget, defaultKtxRelationshipValidationBudget } from '../../../src/context/scan/relationship-budget.js';
|
|
|
|
interface Candidate {
|
|
id: string;
|
|
confidence: number;
|
|
}
|
|
|
|
describe('relationship validation budget', () => {
|
|
it('computes the default validation budget from table count', () => {
|
|
expect(defaultKtxRelationshipValidationBudget(0)).toBe(0);
|
|
expect(defaultKtxRelationshipValidationBudget(3)).toBe(6);
|
|
expect(defaultKtxRelationshipValidationBudget(400)).toBe(800);
|
|
expect(defaultKtxRelationshipValidationBudget(900)).toBe(1000);
|
|
expect(defaultKtxRelationshipValidationBudget(-4)).toBe(0);
|
|
expect(defaultKtxRelationshipValidationBudget(3.8)).toBe(6);
|
|
});
|
|
|
|
it('splits candidates by descending score with stable tie ordering', () => {
|
|
const result = applyKtxRelationshipValidationBudget<Candidate>({
|
|
candidates: [
|
|
{ id: 'first', confidence: 0.8 },
|
|
{ id: 'second', confidence: 0.9 },
|
|
{ id: 'third', confidence: 0.9 },
|
|
{ id: 'fourth', confidence: 0.2 },
|
|
],
|
|
tableCount: 100,
|
|
budget: 2,
|
|
score: (candidate) => candidate.confidence,
|
|
});
|
|
|
|
expect(result.effectiveBudget).toBe(2);
|
|
expect(result.toValidate.map((entry) => entry.candidate.id)).toEqual(['second', 'third']);
|
|
expect(result.deferred.map((entry) => entry.candidate.id)).toEqual(['first', 'fourth']);
|
|
expect(result.toValidate.map((entry) => entry.originalIndex)).toEqual([1, 2]);
|
|
});
|
|
|
|
it('uses the default budget when the budget is omitted', () => {
|
|
const candidates = Array.from({ length: 8 }, (_, index) => ({
|
|
id: `candidate-${index}`,
|
|
confidence: 1 - index / 10,
|
|
}));
|
|
|
|
const result = applyKtxRelationshipValidationBudget<Candidate>({
|
|
candidates,
|
|
tableCount: 2,
|
|
score: (candidate) => candidate.confidence,
|
|
});
|
|
|
|
expect(result.effectiveBudget).toBe(4);
|
|
expect(result.toValidate).toHaveLength(4);
|
|
expect(result.deferred).toHaveLength(4);
|
|
});
|
|
|
|
it('treats budget zero as disabling SQL validation', () => {
|
|
const result = applyKtxRelationshipValidationBudget<Candidate>({
|
|
candidates: [
|
|
{ id: 'first', confidence: 1 },
|
|
{ id: 'second', confidence: 0.5 },
|
|
],
|
|
tableCount: 10,
|
|
budget: 0,
|
|
score: (candidate) => candidate.confidence,
|
|
});
|
|
|
|
expect(result.effectiveBudget).toBe(0);
|
|
expect(result.toValidate).toEqual([]);
|
|
expect(result.deferred.map((entry) => entry.candidate.id)).toEqual(['first', 'second']);
|
|
});
|
|
|
|
it('treats budget all as validating every candidate', () => {
|
|
const result = applyKtxRelationshipValidationBudget<Candidate>({
|
|
candidates: [
|
|
{ id: 'first', confidence: 0.1 },
|
|
{ id: 'second', confidence: 0.9 },
|
|
],
|
|
tableCount: 1,
|
|
budget: 'all',
|
|
score: (candidate) => candidate.confidence,
|
|
});
|
|
|
|
expect(result.effectiveBudget).toBe('all');
|
|
expect(result.toValidate.map((entry) => entry.candidate.id)).toEqual(['first', 'second']);
|
|
expect(result.deferred).toEqual([]);
|
|
});
|
|
});
|