mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
143 lines
4.8 KiB
TypeScript
143 lines
4.8 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { connectionConfigSchema } from '../../../src/context/project/driver-schemas.js';
|
|
|
|
describe('connectionConfigSchema (driver discriminated union)', () => {
|
|
it.each([
|
|
['postgres', 'postgres://user:pass@host:5432/db'], // pragma: allowlist secret
|
|
['mysql', 'mysql://user:pass@host:3306/db'], // pragma: allowlist secret
|
|
['snowflake', 'snowflake://account/db'],
|
|
['bigquery', 'bigquery://project/dataset'],
|
|
['sqlite', 'sqlite:///tmp/db.sqlite'],
|
|
['clickhouse', 'clickhouse://host:8123/db'],
|
|
['sqlserver', 'sqlserver://host:1433;database=db'],
|
|
])('parses %s warehouse connection', (driver, url) => {
|
|
expect(connectionConfigSchema.parse({ driver, url })).toMatchObject({ driver, url });
|
|
});
|
|
|
|
it('preserves unknown warehouse fields via looseObject passthrough', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'postgres',
|
|
url: 'postgres://x',
|
|
customField: { enabled: true },
|
|
context: { queryHistory: { enabled: false } },
|
|
});
|
|
expect(parsed).toMatchObject({
|
|
driver: 'postgres',
|
|
customField: { enabled: true },
|
|
context: { queryHistory: { enabled: false } },
|
|
});
|
|
});
|
|
|
|
it('rejects an unknown driver', () => {
|
|
expect(() => connectionConfigSchema.parse({ driver: 'nope', url: 'x' })).toThrow();
|
|
});
|
|
|
|
it('rejects legacy warehouse driver aliases', () => {
|
|
expect(() => connectionConfigSchema.parse({ driver: 'postgresql', url: 'postgresql://host/db' })).toThrow();
|
|
});
|
|
});
|
|
|
|
describe('connectionConfigSchema - context source drivers with mappings', () => {
|
|
it('parses a metabase connection with mappings', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'metabase',
|
|
api_url: 'https://metabase.example.com',
|
|
api_key_ref: 'env:METABASE_API_KEY', // pragma: allowlist secret
|
|
mappings: {
|
|
databaseMappings: { '3': 'prod-warehouse' },
|
|
syncEnabled: { '3': true },
|
|
syncMode: 'ONLY',
|
|
},
|
|
});
|
|
expect(parsed).toMatchObject({
|
|
driver: 'metabase',
|
|
api_url: 'https://metabase.example.com',
|
|
mappings: {
|
|
databaseMappings: { '3': 'prod-warehouse' },
|
|
syncMode: 'ONLY',
|
|
},
|
|
});
|
|
});
|
|
|
|
it('parses a looker connection with connectionMappings', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'looker',
|
|
base_url: 'https://looker.example.com',
|
|
client_id: 'abc',
|
|
client_secret_ref: 'env:LOOKER_CLIENT_SECRET', // pragma: allowlist secret
|
|
mappings: { connectionMappings: { bigquery_prod: 'wh' } },
|
|
});
|
|
expect(parsed.mappings).toEqual({ connectionMappings: { bigquery_prod: 'wh' } });
|
|
});
|
|
|
|
it('parses a lookml connection with expectedLookerConnectionName', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'lookml',
|
|
repoUrl: 'https://github.com/acme/looker.git',
|
|
branch: 'main',
|
|
mappings: { expectedLookerConnectionName: 'bigquery_prod' },
|
|
});
|
|
expect(parsed.mappings).toEqual({ expectedLookerConnectionName: 'bigquery_prod' });
|
|
});
|
|
|
|
it('rejects metabase mapping with non-integer database key', () => {
|
|
expect(() =>
|
|
connectionConfigSchema.parse({
|
|
driver: 'metabase',
|
|
api_url: 'https://x',
|
|
mappings: { databaseMappings: { abc: 'wh' } },
|
|
}),
|
|
).toThrow();
|
|
});
|
|
});
|
|
|
|
describe('connectionConfigSchema - notion / dbt / metricflow', () => {
|
|
it('parses a notion connection with selected_roots crawl', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'notion',
|
|
auth_token_ref: 'env:NOTION_TOKEN',
|
|
crawl_mode: 'selected_roots',
|
|
root_page_ids: ['abc', 'def'],
|
|
max_pages_per_run: 500,
|
|
});
|
|
expect(parsed).toMatchObject({
|
|
driver: 'notion',
|
|
crawl_mode: 'selected_roots',
|
|
root_page_ids: ['abc', 'def'],
|
|
max_pages_per_run: 500,
|
|
});
|
|
});
|
|
|
|
it('rejects notion with unknown crawl_mode', () => {
|
|
expect(() =>
|
|
connectionConfigSchema.parse({
|
|
driver: 'notion',
|
|
auth_token_ref: 'env:NOTION_TOKEN',
|
|
crawl_mode: 'everything',
|
|
}),
|
|
).toThrow();
|
|
});
|
|
|
|
it('parses a dbt connection from a local source_dir', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'dbt',
|
|
source_dir: '/tmp/dbt-project',
|
|
target: 'dev',
|
|
});
|
|
expect(parsed).toMatchObject({ driver: 'dbt', source_dir: '/tmp/dbt-project', target: 'dev' });
|
|
});
|
|
|
|
it('parses a metricflow connection with nested config', () => {
|
|
const parsed = connectionConfigSchema.parse({
|
|
driver: 'metricflow',
|
|
metricflow: {
|
|
repoUrl: 'https://github.com/acme/sl.git',
|
|
branch: 'main',
|
|
},
|
|
});
|
|
expect(parsed).toMatchObject({
|
|
driver: 'metricflow',
|
|
metricflow: { repoUrl: 'https://github.com/acme/sl.git' },
|
|
});
|
|
});
|
|
});
|