mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
103 lines
3.3 KiB
TypeScript
103 lines
3.3 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import { createPostgresQueryExecutor } from '../../../src/context/connections/postgres-query-executor.js';
|
|
|
|
function makeClient() {
|
|
const calls: unknown[] = [];
|
|
const client = {
|
|
connect: vi.fn(async () => undefined),
|
|
query: vi.fn(async (input: unknown) => {
|
|
calls.push(input);
|
|
if (input === 'BEGIN READ ONLY') {
|
|
return { rows: [], fields: [], rowCount: null, command: 'BEGIN' };
|
|
}
|
|
if (input === 'COMMIT') {
|
|
return { rows: [], fields: [], rowCount: null, command: 'COMMIT' };
|
|
}
|
|
return {
|
|
rows: [
|
|
['paid', 2],
|
|
['open', 1],
|
|
],
|
|
fields: [{ name: 'status' }, { name: 'order_count' }],
|
|
rowCount: 2,
|
|
command: 'SELECT',
|
|
};
|
|
}),
|
|
end: vi.fn(async () => undefined),
|
|
};
|
|
return { client, calls };
|
|
}
|
|
|
|
describe('createPostgresQueryExecutor', () => {
|
|
it('runs a read-only transaction in array row mode and closes the client', async () => {
|
|
const { client, calls } = makeClient();
|
|
const executor = createPostgresQueryExecutor({
|
|
clientFactory: vi.fn(() => client),
|
|
});
|
|
|
|
const result = await executor.execute({
|
|
connectionId: 'warehouse',
|
|
connection: { driver: 'postgres', url: 'postgres://example/db' },
|
|
sql: 'select status, count(*) as order_count from public.orders group by status',
|
|
maxRows: 50,
|
|
});
|
|
|
|
expect(client.connect).toHaveBeenCalledTimes(1);
|
|
expect(calls[0]).toBe('BEGIN READ ONLY');
|
|
expect(calls[1]).toEqual({
|
|
text: 'select * from (select status, count(*) as order_count from public.orders group by status) as ktx_query_result limit 50',
|
|
rowMode: 'array',
|
|
});
|
|
expect(calls[2]).toBe('COMMIT');
|
|
expect(client.end).toHaveBeenCalledTimes(1);
|
|
expect(result).toEqual({
|
|
headers: ['status', 'order_count'],
|
|
rows: [
|
|
['paid', 2],
|
|
['open', 1],
|
|
],
|
|
totalRows: 2,
|
|
command: 'SELECT',
|
|
rowCount: 2,
|
|
});
|
|
});
|
|
|
|
it('rolls back and closes the client when query execution fails', async () => {
|
|
const client = {
|
|
connect: vi.fn(async () => undefined),
|
|
query: vi.fn(async (input: unknown) => {
|
|
if (input === 'BEGIN READ ONLY' || input === 'ROLLBACK') {
|
|
return { rows: [], fields: [], rowCount: null, command: String(input) };
|
|
}
|
|
throw new Error('syntax error');
|
|
}),
|
|
end: vi.fn(async () => undefined),
|
|
};
|
|
const executor = createPostgresQueryExecutor({
|
|
clientFactory: vi.fn(() => client),
|
|
});
|
|
|
|
await expect(
|
|
executor.execute({
|
|
connectionId: 'warehouse',
|
|
connection: { driver: 'postgres', url: 'postgres://example/db' },
|
|
sql: 'select * from broken',
|
|
maxRows: 10,
|
|
}),
|
|
).rejects.toThrow('syntax error');
|
|
expect(client.query).toHaveBeenCalledWith('ROLLBACK');
|
|
expect(client.end).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('requires a Postgres url', async () => {
|
|
const executor = createPostgresQueryExecutor({ clientFactory: vi.fn() });
|
|
|
|
await expect(
|
|
executor.execute({
|
|
connectionId: 'warehouse',
|
|
connection: { driver: 'postgres' },
|
|
sql: 'select 1',
|
|
}),
|
|
).rejects.toThrow('Local Postgres execution requires connections.warehouse.url');
|
|
});
|
|
});
|