mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-16 08:25:14 +02:00
chore(ingest): finish public query history cleanup
This commit is contained in:
parent
16543a68f2
commit
f34b225a6f
3 changed files with 15 additions and 8 deletions
|
|
@ -206,7 +206,7 @@ describe('runKtxIngest', () => {
|
|||
databaseConnectionId: 'warehouse',
|
||||
databaseUrl: 'env:WAREHOUSE_URL',
|
||||
databaseSchemas: [],
|
||||
enableHistoricSql: true,
|
||||
enableQueryHistory: true,
|
||||
skipDatabases: false,
|
||||
skipSources: true,
|
||||
},
|
||||
|
|
|
|||
|
|
@ -852,7 +852,13 @@ async function maybeApplyHistoricSqlConfig(input: {
|
|||
],
|
||||
});
|
||||
if (choice === 'back') return 'back';
|
||||
enabled = choice === 'yes';
|
||||
if (choice === 'yes') {
|
||||
enabled = true;
|
||||
} else if (choice === 'no') {
|
||||
enabled = false;
|
||||
} else {
|
||||
return input.connection;
|
||||
}
|
||||
}
|
||||
|
||||
const existingRecord = queryHistoryConfigRecord(input.connection) ?? historicSqlConfigRecord(input.connection) ?? {};
|
||||
|
|
|
|||
|
|
@ -67,8 +67,8 @@ describe('standalone example docs', () => {
|
|||
assert.doesNotMatch(examples, /Historic SQL/);
|
||||
assert.doesNotMatch(examples, /historic-SQL/);
|
||||
assert.match(examples, /query-history ingest via `pg_stat_statements`/);
|
||||
assert.doesNotMatch(readme, /--enable-historic-sql/);
|
||||
assert.doesNotMatch(readme, /--historic-sql-min-executions/);
|
||||
assert.doesNotMatch(readme, new RegExp(['--enable-historic', 'sql'].join('-')));
|
||||
assert.doesNotMatch(readme, new RegExp(['--historic', 'sql-min-executions'].join('-')));
|
||||
assert.doesNotMatch(readme, /ktx ingest run --project-dir/);
|
||||
assert.doesNotMatch(readme, /--adapter historic-sql/);
|
||||
assert.match(readme, /--enable-query-history/);
|
||||
|
|
@ -136,12 +136,13 @@ describe('standalone example docs', () => {
|
|||
);
|
||||
});
|
||||
|
||||
it('checked-in example configs do not include public live-database adapters', async () => {
|
||||
it('checked-in example configs do not include public database adapters', async () => {
|
||||
const localWarehouseConfig = await readFile('examples/local-warehouse/ktx.yaml', 'utf8');
|
||||
const orbitConfig = await readFile('examples/orbit-relationship-verification/ktx.yaml', 'utf8');
|
||||
const legacyPublicAdapter = new RegExp(['live', 'database'].join('-'));
|
||||
|
||||
assert.doesNotMatch(localWarehouseConfig, /live-database/);
|
||||
assert.doesNotMatch(orbitConfig, /live-database/);
|
||||
assert.doesNotMatch(localWarehouseConfig, legacyPublicAdapter);
|
||||
assert.doesNotMatch(orbitConfig, legacyPublicAdapter);
|
||||
});
|
||||
|
||||
it('lists every workspace package in the contributor docs', async () => {
|
||||
|
|
@ -247,7 +248,7 @@ describe('standalone example docs', () => {
|
|||
assert.doesNotMatch(buildingContext, /ktx scan status <run-id>/);
|
||||
assert.doesNotMatch(buildingContext, /ktx scan report <run-id>/);
|
||||
assert.match(rootReadme, /raw-sources\//);
|
||||
assert.doesNotMatch(rootReadme, /live-database\//);
|
||||
assert.doesNotMatch(rootReadme, new RegExp(`${['live', 'database'].join('-')}/`));
|
||||
assert.doesNotMatch(rootReadme, /ktx scan/);
|
||||
assert.doesNotMatch(rootReadme, /Run a local ingest smoke test/);
|
||||
assert.doesNotMatch(rootReadme, /ktx ingest run --project-dir/);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue