apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-10 08:05:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(context): delete MANAGED_SENTENCE_TRANSFORMERS_BASE_URL sentinel

Browse source
This commit is contained in:
Andrey Avtomonov 2026-05-21 02:01:05 +02:00
parent 295d027739
commit e08c2523c9
5 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/context/src/llm/index.ts
View file

@ -37,7 +37,6 @@ export {
summarizeKtxLlmDebugRequest,
} from './debug-request-recorder.js';
export {
MANAGED_SENTENCE_TRANSFORMERS_BASE_URL,
createLocalKtxEmbeddingProviderFromConfig,
createLocalKtxLlmProviderFromConfig,
createLocalKtxLlmRuntimeFromConfig,

5
packages/context/src/llm/local-config.test.ts
View file

@ -5,7 +5,6 @@ import {
type KtxProjectLlmConfig,
} from '../project/config.js';
import {
MANAGED_SENTENCE_TRANSFORMERS_BASE_URL,
createLocalKtxEmbeddingProviderFromConfig,
createLocalKtxLlmProviderFromConfig,
resolveLocalKtxEmbeddingConfig,
@ -151,13 +150,13 @@ describe('local KTX embedding config', () => {
});
});
it('returns null when sentence-transformers base_url is still the unresolved managed sentinel', () => {
it('returns null when sentence-transformers has no base_url (managed daemon delegation)', () => {
const config: KtxProjectEmbeddingConfig = {
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: {
base_url: MANAGED_SENTENCE_TRANSFORMERS_BASE_URL,
base_url: '',
pathPrefix: '',
},
};

4
packages/context/src/llm/local-config.ts
View file

@ -22,8 +22,6 @@ interface LocalConfigDeps {
createAiSdkRuntime?: (deps: { llmProvider: KtxLlmProvider }) => KtxLlmRuntimePort;
}
export const MANAGED_SENTENCE_TRANSFORMERS_BASE_URL = 'managed:local-embeddings';
function resolveOptional(value: string | undefined, env: NodeJS.ProcessEnv): string | undefined {
return resolveKtxConfigReference(value, env) || undefined;
}
@ -149,7 +147,7 @@ export function resolveLocalKtxEmbeddingConfig(
}
if (config.backend === 'sentence-transformers') {
const baseURL = config.sentenceTransformers?.base_url;
if (!baseURL || baseURL === MANAGED_SENTENCE_TRANSFORMERS_BASE_URL) {
if (!baseURL) {
return null;
}
return {

1
packages/context/src/package-exports.test.ts
View file

@ -143,7 +143,6 @@ describe('@ktx/context package exports', () => {
expect(root.assertSearchBackendConformanceCase).toBeTypeOf('function');
expect(root.assertSearchBackendCapabilities).toBeTypeOf('function');
expect(root.createLocalKtxEmbeddingProviderFromConfig).toBeTypeOf('function');
expect(root.MANAGED_SENTENCE_TRANSFORMERS_BASE_URL).toBe('managed:local-embeddings');
expect(agent).toBeDefined();
expect(agent.AgentRunnerService).toBeTypeOf('function');
expect(root.AgentRunnerService).toBeTypeOf('function');

2
packages/context/src/project/config.ts
View file

@ -36,7 +36,7 @@ const vertexProviderSchema = z
const sentenceTransformersSchema = z
.strictObject({
base_url: z.string().default('').describe('Base URL of the sentence-transformers HTTP server. Empty string uses the managed local runtime.'),
base_url: z.string().default('').describe('Base URL of the sentence-transformers HTTP server. Leave empty (or omit) to use the project-managed local daemon.'),
pathPrefix: z.string().optional().describe('Optional URL path prefix prepended to embedding requests.'),
})
.describe('Sentence-transformers embedding server configuration.');