Merge pull request #22 from Kaelio/andreybavt/fix-metabase-readiness

fix(cli): report metabase ingest readiness

packages/cli/src/demo.test.ts

@@ -11,6 +11,9 @@ import type { renderMemoryFlowTui } from './memory-flow-tui.js';
 import { KTX_NEXT_STEP_COMMANDS } from './next-steps.js';
 import { resetVizFallbackWarningsForTest } from './viz-fallback.js';
 
+const SEEDED_DEMO_SEMANTIC_SOURCE_COUNT = 46;
+const SEEDED_DEMO_KNOWLEDGE_PAGE_COUNT = 28;
+
 function makeIo(options: { isTTY?: boolean; columns?: number; rawMode?: boolean } = {}) {
   let stdout = '';
   let stderr = '';
@@ -336,8 +339,14 @@ describe('runKtxDemo', () => {
         notion: { pageCount: 8 },
       },
       generatedOutputs: {
-        semanticLayer: { manifestSourceCount: 46, fileCount: 46 },
-        knowledge: { manifestPageCount: 28, fileCount: 28 },
+        semanticLayer: {
+          manifestSourceCount: SEEDED_DEMO_SEMANTIC_SOURCE_COUNT,
+          fileCount: SEEDED_DEMO_SEMANTIC_SOURCE_COUNT,
+        },
+        knowledge: {
+          manifestPageCount: SEEDED_DEMO_KNOWLEDGE_PAGE_COUNT,
+          fileCount: SEEDED_DEMO_KNOWLEDGE_PAGE_COUNT,
+        },
         links: { manifestLinkCount: 23, linkCount: 23 },
         reports: { primaryPath: 'reports/seeded-demo-report.json', fileCount: 1 },
       },
@@ -636,10 +645,16 @@ describe('runKtxDemo', () => {
     ).resolves.toBe(0);
 
     expect(seededIo.stdout()).toContain('Status: ready');
-    expect(seededIo.stdout()).toContain('Semantic-layer sources: 46 manifest, 46 files');
-    expect(seededIo.stdout()).toContain('Knowledge pages: 28 manifest, 28 files');
+    expect(seededIo.stdout()).toContain(
+      `Semantic-layer sources: ${SEEDED_DEMO_SEMANTIC_SOURCE_COUNT} manifest, ${SEEDED_DEMO_SEMANTIC_SOURCE_COUNT} files`,
+    );
+    expect(seededIo.stdout()).toContain(
+      `Knowledge pages: ${SEEDED_DEMO_KNOWLEDGE_PAGE_COUNT} manifest, ${SEEDED_DEMO_KNOWLEDGE_PAGE_COUNT} files`,
+    );
     expect(seededIo.stdout()).not.toContain('Status: corrupt');
-    expect(seededIo.stdout()).not.toContain('Semantic-layer sources: 46 manifest, 0 files');
+    expect(seededIo.stdout()).not.toContain(
+      `Semantic-layer sources: ${SEEDED_DEMO_SEMANTIC_SOURCE_COUNT} manifest, 0 files`,
+    );
   });
 
   it('fails corrupted demo projects in no-input mode with reset guidance', async () => {

packages/cli/src/setup.test.ts

@@ -3,6 +3,7 @@ import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
+import { localFakeBundleReport, persistLocalBundleReport } from './ingest.test-utils.js';
 import { contextBuildCommands, writeKtxSetupContextState } from './setup-context.js';
 import { runDemoTour } from './setup-demo-tour.js';
 import { readKtxSetupStatus, runKtxSetup } from './setup.js';
@@ -311,6 +312,62 @@ describe('setup status', () => {
     });
   });
 
+  it('reports Vertex LLM and context ready after a successful Metabase ingest report', async () => {
+    await writeFile(
+      join(tempDir, 'ktx.yaml'),
+      [
+        'project: revenue',
+        'setup:',
+        '  database_connection_ids:',
+        '    - warehouse',
+        '  completed_steps:',
+        '    - project',
+        '    - databases',
+        '    - sources',
+        'connections:',
+        '  warehouse:',
+        '    driver: postgres',
+        '    url: env:DATABASE_URL',
+        '  metabase:',
+        '    driver: metabase',
+        '    url: env:METABASE_URL',
+        '    api_key_ref: env:METABASE_API_KEY',
+        '    warehouse_connection_id: warehouse',
+        'llm:',
+        '  provider:',
+        '    backend: vertex',
+        '    vertex:',
+        '      project: kaelio-dev',
+        '      location: us-east5',
+        '  models:',
+        '    default: claude-sonnet-4-6',
+        'ingest:',
+        '  embeddings:',
+        '    backend: deterministic',
+        '    model: deterministic',
+        '    dimensions: 8',
+        '',
+      ].join('\n'),
+      'utf-8',
+    );
+    await persistLocalBundleReport(
+      tempDir,
+      localFakeBundleReport('metabase-job-1', {
+        connectionId: 'warehouse',
+        sourceKey: 'metabase',
+      }),
+    );
+
+    const status = await readKtxSetupStatus(tempDir);
+    const io = makeIo();
+    await expect(runKtxSetup({ command: 'status', projectDir: tempDir, json: false }, io.io)).resolves.toBe(0);
+
+    expect(status.llm).toMatchObject({ backend: 'vertex', ready: true, model: 'claude-sonnet-4-6' });
+    expect(status.context).toMatchObject({ ready: true, status: 'completed' });
+    expect(io.stdout()).toContain('LLM ready: yes (claude-sonnet-4-6)');
+    expect(io.stdout()).toContain('KTX context built: yes');
+  });
+
   it('prints plain and JSON setup status', async () => {
     const plainIo = makeIo();
     const jsonIo = makeIo();

packages/cli/src/setup.ts

@@ -1,7 +1,8 @@
 import { existsSync } from 'node:fs';
 import { join, resolve } from 'node:path';
 import { cancel, isCancel, select } from '@clack/prompts';
-import { loadKtxProject } from '@ktx/context/project';
+import { getLatestLocalIngestStatus, savedMemoryCountsForReport } from '@ktx/context/ingest';
+import { ktxLocalStateDbPath, loadKtxProject, type KtxLocalProject } from '@ktx/context/project';
 import type { KtxCliIo } from './cli-runtime.js';
 import { formatSetupNextStepLines } from './next-steps.js';
 import { isKtxSetupExitError, withSetupInterruptConfirmation } from './setup-interrupt.js';
@@ -248,6 +249,31 @@ function sourceConnections(config: Awaited<ReturnType<typeof loadKtxProject>>['c
     .sort((left, right) => left.connectionId.localeCompare(right.connectionId));
 }
 
+type LocalIngestStatusReport = NonNullable<Awaited<ReturnType<typeof getLatestLocalIngestStatus>>>;
+
+function reportHasSavedContext(report: LocalIngestStatusReport): boolean {
+  if (report.body.failedWorkUnits.length > 0) {
+    return false;
+  }
+  const counts = savedMemoryCountsForReport(report);
+  return counts.wikiCount > 0 || counts.slCount > 0;
+}
+
+async function readIngestContextStatus(project: KtxLocalProject): Promise<KtxSetupContextStatusSummary | null> {
+  if (!existsSync(ktxLocalStateDbPath(project))) {
+    return null;
+  }
+  const report = await getLatestLocalIngestStatus(project);
+  if (!report || !reportHasSavedContext(report)) {
+    return null;
+  }
+  return {
+    ready: true,
+    status: 'completed',
+    runId: report.runId,
+  };
+}
+
 export async function readKtxSetupStatus(projectDir: string): Promise<KtxSetupStatus> {
   const resolvedProjectDir = resolve(projectDir);
   if (!existsSync(join(resolvedProjectDir, 'ktx.yaml'))) {
@@ -279,6 +305,10 @@ export async function readKtxSetupStatus(projectDir: string): Promise<KtxSetupSt
 
   const completedSteps = project.config.setup?.completed_steps ?? [];
   const contextState = await readKtxSetupContextState(resolvedProjectDir);
+  const setupContextStatus = setupContextStatusFromState(contextState, {
+    completedStep: completedSteps.includes('context'),
+  });
+  const ingestContextStatus = setupContextStatus.ready ? null : await readIngestContextStatus(project);
   const databaseIds = project.config.setup?.database_connection_ids ?? Object.keys(project.config.connections);
   const databasesComplete = completedSteps.includes('databases');
   const manifest = await readKtxAgentInstallManifest(resolvedProjectDir);
@@ -301,7 +331,7 @@ export async function readKtxSetupStatus(projectDir: string): Promise<KtxSetupSt
       ...source,
       ready: completedSteps.includes('sources'),
     })),
-    context: setupContextStatusFromState(contextState, { completedStep: completedSteps.includes('context') }),
+    context: ingestContextStatus ?? setupContextStatus,
     agents,
   };
 }

packages/cli/src/standalone-smoke.test.ts

@@ -368,7 +368,7 @@ describe('standalone built ktx CLI smoke', () => {
       const knowledgeSearch = structuredContent<{
         results: Array<{ key: string; summary: string; score: number }>;
         totalFound: number;
-      }>(await client.callTool({ name: 'knowledge_search', arguments: { query: 'ARR contract', limit: 5 } }));
+      }>(await client.callTool({ name: 'knowledge_search', arguments: { query: 'ARR contract-first definition', limit: 10 } }));
       expect(knowledgeSearch.totalFound).toBeGreaterThan(0);
       expect(knowledgeSearch.results.map((result) => result.key)).toContain('orbit-arr-contract-first-definition');
 
@@ -387,7 +387,7 @@ describe('standalone built ktx CLI smoke', () => {
       const slRead = structuredContent<{ sourceName: string; yaml: string }>(
         await client.callTool({
           name: 'sl_read_source',
-          arguments: { connectionId: 'postgres-warehouse', sourceName: 'mart_arr_daily' },
+          arguments: { connectionId: 'dbt-main', sourceName: 'mart_arr_daily' },
         }),
       );
       expect(slRead.sourceName).toBe('mart_arr_daily');
@@ -397,7 +397,7 @@ describe('standalone built ktx CLI smoke', () => {
       const slValidate = structuredContent<{ success: boolean; errors: string[]; warnings: string[] }>(
         await client.callTool({
           name: 'sl_validate',
-          arguments: { connectionId: 'postgres-warehouse', names: ['mart_arr_daily'] },
+          arguments: { connectionId: 'dbt-main', names: ['mart_arr_daily', 'stg_contracts'] },
         }),
       );
       expect(slValidate.success).toBe(true);