mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-16 08:25:14 +02:00
feat(cli): shell completion for commands, flags, and entity names (#244)
* feat(completion): complete known argument values
* fix(completion): hide Commander-hidden subcommands from completions
Replace the `__`-prefix name heuristic with Commander's `_hidden` flag so
internal subcommands registered with { hidden: true } (e.g. `mcp serve-internal`)
are excluded from completions, mirroring `ktx --help`.
* test: cover wiki and sl read command routing
* test: cover raw wiki and sl reads
* feat: add wiki read command
* feat: add sl read command
* feat: complete read command entity names
* docs: document wiki and sl read commands
* test: include read commands in command tree
* feat(sl): read and validate unique sources by name
* feat(sl): make read and validate connection id optional
* fix(completion): dedupe semantic source names
* docs(sl): document connection-optional read and validate
* fix(sl): require connection id for query command
* docs(sl): clarify query connection requirement
* fix(completion): don't resolve option values as subcommands
resolveCommand skipped flag tokens but not the value consumed by a
value-taking option in the `--flag value` form, so a connection id like
`query` was matched as the `sl query` subcommand and yielded no `sl`
completions. Track value-taking options and skip their consumed value
before matching subcommands.
* test(telemetry): assert first-run notice via TELEMETRY_NOTICE constant
CI (which tests this branch merged with main) failed because #243 changed
the first-run notice wording in identity.ts (dropped "anonymous") but left
this test grepping for the old literal 'ktx collects anonymous usage data',
so indexOf returned -1. Assert against the exported TELEMETRY_NOTICE
constant instead so the test tracks the source of truth and cannot drift
when the notice text changes again.
This commit is contained in:
parent
c196d1f192
commit
d320d54ab2
28 changed files with 1596 additions and 54 deletions
86
docs-site/content/docs/cli-reference/ktx-completion.mdx
Normal file
86
docs-site/content/docs/cli-reference/ktx-completion.mdx
Normal file
|
|
@ -0,0 +1,86 @@
|
|||
---
|
||||
title: "ktx completion"
|
||||
description: "Print a shell completion script for tab completion."
|
||||
---
|
||||
|
||||
Print a shell completion script for **ktx**. Once installed, pressing <kbd>Tab</kbd>
|
||||
completes commands, subcommands, and flags, and - inside a **ktx** project - the
|
||||
names of things that already exist: semantic-layer source names for
|
||||
`ktx sl read` and `ktx sl validate`, wiki page keys for `ktx wiki read`, and
|
||||
configured connection ids for `ktx connection test`, `ktx ingest`, and
|
||||
`ktx sql`. This saves you from remembering exact source, page, or connection
|
||||
names.
|
||||
|
||||
## Command signature
|
||||
|
||||
```bash
|
||||
ktx completion <shell>
|
||||
```
|
||||
|
||||
`<shell>` must be `zsh` or `bash`. The command writes the script to stdout; it
|
||||
does not modify any files. Enable completion by evaluating the script in your
|
||||
shell startup file.
|
||||
|
||||
## Installation
|
||||
|
||||
Add the matching line to your shell startup file, then restart your shell (or
|
||||
`source` the file). `ktx` must be on your `PATH`.
|
||||
|
||||
```bash
|
||||
# zsh — add to ~/.zshrc
|
||||
eval "$(ktx completion zsh)"
|
||||
```
|
||||
|
||||
```bash
|
||||
# bash — add to ~/.bashrc
|
||||
eval "$(ktx completion bash)"
|
||||
```
|
||||
|
||||
To try it for the current session only, run the same `eval` line directly in
|
||||
your terminal.
|
||||
|
||||
## What gets completed
|
||||
|
||||
| Position | Completions |
|
||||
|----------|-------------|
|
||||
| `ktx <Tab>` | Top-level commands (`setup`, `sl`, `wiki`, `ingest`, …) |
|
||||
| `ktx sl <Tab>` | The `read` / `validate` / `query` subcommands |
|
||||
| `ktx sl read <Tab>` | Existing semantic-layer source names |
|
||||
| `ktx sl validate <Tab>` | Existing semantic-layer source names |
|
||||
| `ktx wiki <Tab>` | The `read` subcommand |
|
||||
| `ktx wiki read <Tab>` | Existing wiki page keys |
|
||||
| `ktx connection test <Tab>` | Configured connection ids |
|
||||
| `ktx ingest <Tab>` | Configured connection ids |
|
||||
| `ktx sql --connection <Tab>` | Configured connection ids |
|
||||
| `ktx completion <Tab>` | `zsh` or `bash` |
|
||||
| `ktx <command> --<Tab>` | The command's flags and inherited global flags |
|
||||
| `ktx sl --output <Tab>` | An option's allowed values (here `pretty`, `plain`, `json`) |
|
||||
| `ktx sl --connection-id <Tab>` | Configured connection ids |
|
||||
|
||||
Source names, wiki page keys, and connection ids are read from the **ktx**
|
||||
project resolved from your current directory (or `--project-dir` /
|
||||
`KTX_PROJECT_DIR`). Outside a **ktx** project, completion still suggests
|
||||
commands and flags but no project entities. Bare `ktx sl <Tab>` and
|
||||
`ktx wiki <Tab>` complete subcommands instead of entity names because their
|
||||
positional arguments are free-text search queries.
|
||||
|
||||
## Examples
|
||||
|
||||
```bash
|
||||
# Print the zsh completion script
|
||||
ktx completion zsh
|
||||
|
||||
# Print the bash completion script
|
||||
ktx completion bash
|
||||
|
||||
# Install for zsh
|
||||
echo 'eval "$(ktx completion zsh)"' >> ~/.zshrc
|
||||
```
|
||||
|
||||
## Common errors
|
||||
|
||||
| Error | Cause | Recovery |
|
||||
|-------|-------|----------|
|
||||
| `error: command-argument value '<name>' is invalid for argument 'shell'. Allowed choices are zsh, bash.` | A shell other than `zsh` or `bash` was requested | Re-run with `ktx completion zsh` or `ktx completion bash` |
|
||||
| Tab completion does nothing | The script was not evaluated, or `ktx` is not on `PATH` | Confirm the `eval` line is in your startup file, restart the shell, and verify `ktx --version` runs |
|
||||
| Source, page, or connection names are missing | The current directory is not inside a **ktx** project | Run from the project directory, or pass `--project-dir`, or set `KTX_PROJECT_DIR` |
|
||||
|
|
@ -11,13 +11,16 @@ the vocabulary agents use to generate correct SQL.
|
|||
|
||||
```bash
|
||||
ktx sl [options] [query...] # list (bare) or search (with query)
|
||||
ktx sl validate <sourceName> [options]
|
||||
ktx sl read <sourceName>
|
||||
ktx sl validate <sourceName>
|
||||
ktx sl query [options]
|
||||
```
|
||||
|
||||
- Bare `ktx sl` lists semantic sources.
|
||||
- `ktx sl <query...>` searches semantic sources (multi-word queries are
|
||||
joined with a space).
|
||||
- `ktx sl <query...>` searches semantic sources. Multi-word queries are joined
|
||||
with a space.
|
||||
- `ktx sl read <sourceName>` prints the YAML for one source. Add
|
||||
`--connection-id` only when the source name exists in multiple connections.
|
||||
- `ktx sl validate` and `ktx sl query` remain as explicit subcommands.
|
||||
|
||||
## Subcommands
|
||||
|
|
@ -26,6 +29,7 @@ ktx sl query [options]
|
|||
|-----------|-------------|
|
||||
| (none, no query) | List semantic sources |
|
||||
| (none, with query) | Search semantic sources |
|
||||
| `read <sourceName>` | Print the YAML for one semantic source |
|
||||
| `validate <sourceName>` | Validate a semantic source against the database schema |
|
||||
| `query` | Compile or execute a semantic query |
|
||||
|
||||
|
|
@ -40,17 +44,23 @@ ktx sl query [options]
|
|||
| `--output <mode>` | Output mode: `pretty` (default in TTY), `plain` (TSV), or `json` | `pretty` |
|
||||
| `--json` | Shortcut for `--output=json` (overrides `--output`) | `false` |
|
||||
|
||||
### `sl read`
|
||||
|
||||
| Flag | Description | Default |
|
||||
|------|-------------|---------|
|
||||
| `--connection-id <id>` | Optional **ktx** connection id for disambiguation | - |
|
||||
|
||||
### `sl validate`
|
||||
|
||||
| Flag | Description | Default |
|
||||
|------|-------------|---------|
|
||||
| `--connection-id <id>` | **ktx** connection id (required) | - |
|
||||
| `--connection-id <id>` | Optional **ktx** connection id for disambiguation | - |
|
||||
|
||||
### `sl query`
|
||||
|
||||
| Flag | Description | Default |
|
||||
|------|-------------|---------|
|
||||
| `--connection-id <id>` | **ktx** connection id | - |
|
||||
| `--connection-id <id>` | Required **ktx** connection id | - |
|
||||
| `--query-file <path>` | JSON semantic query file | - |
|
||||
| `--measure <measure>` | Measure to query; repeatable (at least one required) | - |
|
||||
| `--dimension <dimension>` | Dimension to include; repeatable | - |
|
||||
|
|
@ -65,8 +75,9 @@ ktx sl query [options]
|
|||
| `--no-input` | Disable interactive managed runtime installation | - |
|
||||
| `--max-rows <n>` | Maximum rows to return when executing | - |
|
||||
|
||||
`sl query` requires at least one `--measure` unless `--query-file` is set.
|
||||
`--query-file` should point to a JSON semantic query object.
|
||||
`sl query` requires `--connection-id` and at least one `--measure` unless
|
||||
`--query-file` is set. `--query-file` must point to a JSON semantic query
|
||||
object.
|
||||
|
||||
## Examples
|
||||
|
||||
|
|
@ -83,7 +94,16 @@ ktx sl --json
|
|||
# Search sources as JSON
|
||||
ktx sl "revenue" --json
|
||||
|
||||
# Validate a source against the live schema
|
||||
# Print the YAML for a source name that is unique across connections
|
||||
ktx sl read orders
|
||||
|
||||
# Print the YAML for a source name that exists in multiple connections
|
||||
ktx sl --connection-id my-warehouse read orders
|
||||
|
||||
# Validate a source name that is unique across connections
|
||||
ktx sl validate orders
|
||||
|
||||
# Validate a source name that exists in multiple connections
|
||||
ktx sl validate orders --connection-id my-warehouse
|
||||
|
||||
# Compile a query and view the generated SQL
|
||||
|
|
@ -144,6 +164,12 @@ shows `#1`, `#2`, and later rank badges for the displayed results. Plain and
|
|||
JSON output keep the raw `score` value, which is a ranking score rather than a
|
||||
percentage.
|
||||
|
||||
`ktx sl read <sourceName>` prints the source YAML directly to stdout when the
|
||||
source name is unique across connections. If the name exists in multiple
|
||||
connections, rerun the command with `--connection-id <id>`. The command does
|
||||
not wrap output in pretty, plain, or JSON formatting, so it can be piped to
|
||||
other tools.
|
||||
|
||||
```json
|
||||
{
|
||||
"sql": "SELECT orders.status, SUM(orders.total_amount) AS total_revenue FROM public.orders GROUP BY orders.status",
|
||||
|
|
@ -160,7 +186,8 @@ percentage.
|
|||
|
||||
| Error | Cause | Recovery |
|
||||
|-------|-------|----------|
|
||||
| Source not found | Source name or connection id is wrong | Run `ktx sl --json` and retry with an exact source name and connection id |
|
||||
| Source not found | Source name or connection id is wrong | Run `ktx sl <query>` or `ktx sl --connection-id <id>` to find the exact source name, then retry `ktx sl read <sourceName>` or `ktx sl validate <sourceName>` |
|
||||
| Source name is ambiguous | The same source name exists in multiple connections | Rerun with `--connection-id <id>` from the error message |
|
||||
| Validation fails | YAML references missing columns, invalid joins, or invalid SQL expressions | Fix the source YAML and rerun `ktx sl validate` |
|
||||
| Query compile fails | Measure, dimension, filter, or segment name is invalid | Search sources with `ktx sl <query>`, inspect the source YAML in your project files, then retry using declared fields |
|
||||
| Execution returns too many rows | `--max-rows` is missing or too high | Add `--max-rows` with a bounded value before executing |
|
||||
|
|
|
|||
|
|
@ -1,21 +1,24 @@
|
|||
---
|
||||
title: "ktx wiki"
|
||||
description: "List or search wiki pages."
|
||||
description: "List, search, or read wiki pages."
|
||||
---
|
||||
|
||||
List and search wiki pages in your **ktx** project. Wiki pages are Markdown
|
||||
documents that capture business definitions, rules, and gotchas. Agents search
|
||||
them for context when answering questions about your data.
|
||||
List, search, and read wiki pages in your **ktx** project. Wiki pages are
|
||||
Markdown documents that capture business definitions, rules, and gotchas.
|
||||
Agents search them for context when answering questions about your data.
|
||||
|
||||
## Command signature
|
||||
|
||||
```bash
|
||||
ktx wiki [options] [query...]
|
||||
ktx wiki [options] [query...] # list (bare) or search (with query)
|
||||
ktx wiki read <key>
|
||||
```
|
||||
|
||||
- Bare `ktx wiki` lists local wiki pages.
|
||||
- `ktx wiki <query...>` searches local wiki pages (multi-word queries are
|
||||
joined with a space).
|
||||
- `ktx wiki <query...>` searches local wiki pages. Multi-word queries are
|
||||
joined with a space.
|
||||
- `ktx wiki read <key>` prints the whole Markdown file for one wiki page,
|
||||
including YAML frontmatter.
|
||||
|
||||
Edit the Markdown files under `wiki/` directly, or ingest source content with
|
||||
`ktx ingest`, when you need to add or update wiki knowledge.
|
||||
|
|
@ -50,6 +53,9 @@ ktx wiki "monthly recurring revenue"
|
|||
# Search wiki pages as JSON
|
||||
ktx wiki "monthly recurring revenue" --json --limit 10
|
||||
|
||||
# Print the exact Markdown file for a known page key
|
||||
ktx wiki read revenue-definitions
|
||||
|
||||
# Print search results as TSV
|
||||
ktx wiki "monthly recurring revenue" --output plain
|
||||
|
||||
|
|
@ -62,8 +68,10 @@ ktx --debug wiki "monthly recurring revenue" --json
|
|||
Wiki commands print clack-style pretty output in a TTY and TSV-style plain
|
||||
output when requested. JSON output wraps the items with a command metadata
|
||||
envelope. Search results include `matchReasons` and `lanes` metadata so you can
|
||||
see whether lexical, token, or semantic search contributed to the ranking. Open
|
||||
the matching Markdown files directly when you need the full page contents.
|
||||
see whether lexical, token, or semantic search contributed to the ranking. Use
|
||||
`ktx wiki read <key>` when you need the full page contents. Read output is the
|
||||
exact Markdown file stored on disk, including YAML frontmatter, and is not
|
||||
wrapped in pretty, plain, or JSON formatting.
|
||||
Pretty search output shows `#1`, `#2`, and later rank badges for the displayed
|
||||
results. Plain and JSON output keep the raw `score` value, which is a ranking
|
||||
score rather than a percentage.
|
||||
|
|
@ -121,4 +129,4 @@ stays machine-readable:
|
|||
| Error | Cause | Recovery |
|
||||
|-------|-------|----------|
|
||||
| Search returns no results | The query terms do not match summaries, tags, or content, and the semantic lane is unavailable or has no positive matches | Run with `--debug`, check the semantic lane status, retry with business synonyms, then create a page if the knowledge is missing |
|
||||
| A page is missing | No Markdown file exists for that business context | Add a file under `wiki/` or run `ktx ingest <connectionId>` |
|
||||
| A page is missing | No Markdown file exists for that business context or `ktx wiki read <key>` used the wrong key | Run `ktx wiki <query>` to find the page key, then retry `ktx wiki read <key>` |
|
||||
|
|
|
|||
|
|
@ -36,9 +36,11 @@ ktx
|
|||
wiki
|
||||
list
|
||||
search <query>
|
||||
read <key>
|
||||
sl
|
||||
list
|
||||
search <query>
|
||||
read <sourceName>
|
||||
validate <sourceName>
|
||||
query
|
||||
sql
|
||||
|
|
@ -57,6 +59,7 @@ ktx
|
|||
stop
|
||||
status
|
||||
reindex
|
||||
completion <shell>
|
||||
```
|
||||
|
||||
The public context-build entrypoint is `ktx ingest [connectionId]` or
|
||||
|
|
@ -97,6 +100,10 @@ ktx ingest
|
|||
ktx sl "revenue"
|
||||
ktx wiki "revenue recognition"
|
||||
|
||||
# Print a known wiki page or semantic source
|
||||
ktx wiki read revenue-definitions
|
||||
ktx sl --connection-id warehouse read orders
|
||||
|
||||
# Execute read-only SQL
|
||||
ktx sql --connection warehouse "select count(*) from public.orders"
|
||||
|
||||
|
|
|
|||
|
|
@ -11,6 +11,7 @@
|
|||
"ktx-wiki",
|
||||
"ktx-status",
|
||||
"ktx-mcp",
|
||||
"ktx-admin"
|
||||
"ktx-admin",
|
||||
"ktx-completion"
|
||||
]
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue