feat: query_policy semantic-layer-only restricts agents to predefined semantic-layer measures (#334)

* feat(sl): add predefined_measures_only guard to semantic query planning

SemanticQuery gains a predefined_measures_only flag; the planner rejects
any measure resolved with Provenance.COMPOSED (runtime aggregate
expressions and query-time derivations) while predefined measures,
predefined derived chains, dimensions, filters, and segments pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(config): add per-connection query_policy to warehouse connections

query_policy: semantic-layer-only | read-only-sql (default) on the
warehouse connection schema, plus a policy module with the raw-SQL
guard, federated member restriction lookup, and the project-level
predicate used to gate sql_execution registration.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(cli): enforce query_policy on raw SQL through one shared executor

ktx sql and the MCP sql_execution tool now share executeProjectRawSql
(resolve, policy check, read-only validation, execute), collapsing
their duplicated validate-then-execute paths. Restricted connections
are rejected before validation; federated raw SQL is rejected when any
member is restricted. sql_execution is not registered when every SQL
connection is restricted, and connection_list marks restricted
connections so agents route to sl_query. executeProjectReadOnlySql
stays generic for ktx-internal SQL (scan, ingest, SL-generated).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(sl): compile queries with predefined_measures_only from query_policy

compileLocalSlQuery injects the flag from the connection's query_policy,
never from caller input, covering both ktx sl query and the MCP
sl_query tool through the daemon compile path.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: document query_policy semantic-layer-only

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sl): close semantic-layer-only bypasses via filters and federated hint

The predefined_measures_only guard only inspected query.measures, so a
composed aggregate written into `filters` slipped through _classify_filters
into a HAVING clause untouched — letting a restricted agent evaluate
arbitrary aggregates (e.g. threshold-probing `sum(x) BETWEEN a AND b`).
Reject filter clauses that compose an aggregate function; a HAVING that
compares a predefined measure by name (`orders.revenue > 100`) still works.

Also make the federated sl_query error policy-aware: when a member is
restricted, raw federated SQL is disabled too, so stop directing the agent
to `ktx sql -c _ktx_federated` / sql_execution (a guaranteed failure) and
point to per-connection semantic-layer queries instead.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Andrey Avtomonov <andreybavt@gmail.com>
This commit is contained in:
Luca Martial 2026-07-03 01:54:17 -07:00 committed by GitHub
parent 66768fe009
commit a651b82e2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
21 changed files with 887 additions and 68 deletions

View file

@ -169,6 +169,9 @@ class SemanticQuery(BaseModel):
order_by: list[str | dict[str, Any]] = []
limit: int = 1000
include_empty: bool = True
# Set by ktx from the connection's query_policy, never by agent input:
# reject runtime-composed measures so only predefined measures execute.
predefined_measures_only: bool = False
@model_validator(mode="after")
def _validate_limit(self) -> SemanticQuery:

View file

@ -62,6 +62,10 @@ class QueryPlanner:
# 2. Resolve measures (parse, look up pre-defined, classify)
raw_measures = self._resolve_measures(query.measures)
if query.predefined_measures_only:
self._reject_composed_measures(raw_measures)
self._reject_composed_filter_aggregates(query.filters)
# 3. Topological sort for derived measures
measures = self._topological_sort_measures(raw_measures)
@ -239,6 +243,42 @@ class QueryPlanner:
measures = self._qualify_duplicate_names(measures)
return measures
def _reject_composed_measures(self, measures: list[ResolvedMeasure]) -> None:
composed = [m for m in measures if m.provenance is Provenance.COMPOSED]
if not composed:
return
rejected = ", ".join(f"'{m.expr}'" for m in composed)
raise ValueError(
f"Only predefined semantic-layer measures can be queried on this "
f"connection (query_policy: semantic-layer-only); composed measure "
f"expressions are not allowed: {rejected}. Use measures declared "
f"on the semantic-layer sources, referenced as 'source.measure'."
)
def _reject_composed_filter_aggregates(self, filters: list[str]) -> None:
# Predefined measures are compared in HAVING by name (e.g.
# `orders.revenue > 100`), which parses as a plain column ref. Any
# aggregate function written into a filter is therefore a runtime-composed
# aggregate the policy forbids — without this guard it would slip through
# `_classify_filters` into HAVING and evaluate an arbitrary aggregate.
composed: list[str] = []
for f in filters:
if not f or not f.strip():
continue
for clause in self._split_top_level_and(f):
if self.parser.parse(clause).is_aggregate:
composed.append(clause)
if not composed:
return
rejected = ", ".join(f"'{c}'" for c in composed)
raise ValueError(
f"Only predefined semantic-layer measures can be queried on this "
f"connection (query_policy: semantic-layer-only); filters may not "
f"compose aggregate expressions: {rejected}. Filter on declared "
f"dimensions or columns, or compare a predefined measure by name "
f"(e.g. 'orders.revenue > 100')."
)
def _collect_colliding_predefined_names(self, raw: list[str | dict]) -> set[str]:
counts: Counter[str] = Counter()
for item in raw:

View file

@ -0,0 +1,148 @@
"""predefined_measures_only rejects runtime-composed measures while leaving
predefined measures, predefined derived chains, dimensions, and filters usable."""
from __future__ import annotations
import pytest
from semantic_layer.engine import SemanticEngine
from semantic_layer.models import SourceDefinition
def _engine() -> SemanticEngine:
orders = SourceDefinition(
name="orders",
table="public.orders",
grain=["id"],
columns=[
{"name": "id", "type": "number"},
{"name": "amount", "type": "number"},
{"name": "status", "type": "string"},
],
measures=[
{"name": "revenue", "expr": "sum(amount)"},
{"name": "order_count", "expr": "count(*)"},
{"name": "aov", "expr": "revenue / order_count"},
],
)
return SemanticEngine.from_sources({"orders": orders})
def test_rejects_composed_string_measure() -> None:
with pytest.raises(ValueError, match="composed measure") as excinfo:
_engine().query(
{
"measures": ["sum(orders.amount)"],
"predefined_measures_only": True,
}
)
assert "sum(orders.amount)" in str(excinfo.value)
assert "query_policy: semantic-layer-only" in str(excinfo.value)
def test_rejects_composed_dict_measure() -> None:
with pytest.raises(ValueError, match="composed measure"):
_engine().query(
{
"measures": [{"expr": "avg(orders.amount)", "name": "avg_amount"}],
"predefined_measures_only": True,
}
)
def test_rejects_query_time_derivation_over_predefined_measures() -> None:
with pytest.raises(ValueError, match="composed measure"):
_engine().query(
{
"measures": [
{"expr": "orders.revenue / orders.order_count", "name": "ratio"}
],
"predefined_measures_only": True,
}
)
def test_rejects_composed_aggregate_in_filter() -> None:
# A HAVING-classified filter must not smuggle a runtime aggregate the
# measures guard would reject (threshold-probing bypass).
with pytest.raises(ValueError, match="compose aggregate expressions") as excinfo:
_engine().query(
{
"measures": ["orders.revenue"],
"dimensions": ["orders.status"],
"filters": ["avg(orders.amount) > 100"],
"predefined_measures_only": True,
}
)
assert "avg(orders.amount) > 100" in str(excinfo.value)
assert "query_policy: semantic-layer-only" in str(excinfo.value)
def test_rejects_composed_aggregate_in_compound_filter() -> None:
with pytest.raises(ValueError, match="compose aggregate expressions"):
_engine().query(
{
"measures": ["orders.revenue"],
"filters": ["orders.status = 'active' AND sum(orders.amount) > 5000"],
"predefined_measures_only": True,
}
)
def test_allows_predefined_measure_having_filter() -> None:
result = _engine().query(
{
"measures": ["orders.revenue"],
"dimensions": ["orders.status"],
"filters": ["orders.revenue > 100"],
"predefined_measures_only": True,
}
)
assert "having" in result.sql.lower()
def test_composed_aggregate_filter_allowed_when_flag_absent() -> None:
result = _engine().query(
{
"measures": ["orders.revenue"],
"filters": ["avg(orders.amount) > 100"],
}
)
assert "having" in result.sql.lower()
def test_allows_predefined_measure_with_dimensions_and_filters() -> None:
result = _engine().query(
{
"measures": ["orders.revenue"],
"dimensions": ["orders.status"],
"filters": ["orders.status != 'cancelled'"],
"predefined_measures_only": True,
}
)
assert "sum" in result.sql.lower()
def test_allows_unqualified_predefined_measure() -> None:
result = _engine().query(
{
"measures": ["revenue"],
"predefined_measures_only": True,
}
)
assert "sum" in result.sql.lower()
def test_allows_predefined_derived_measure_chain() -> None:
result = _engine().query(
{
"measures": ["orders.aov"],
"predefined_measures_only": True,
}
)
assert "sum" in result.sql.lower()
def test_composed_measures_allowed_when_flag_absent() -> None:
result = _engine().query({"measures": ["sum(orders.amount)"]})
assert "sum" in result.sql.lower()