mirror of
https://github.com/Kaelio/ktx.git
synced 2026-07-04 10:52:13 +02:00
feat: query_policy semantic-layer-only restricts agents to predefined semantic-layer measures (#334)
* feat(sl): add predefined_measures_only guard to semantic query planning SemanticQuery gains a predefined_measures_only flag; the planner rejects any measure resolved with Provenance.COMPOSED (runtime aggregate expressions and query-time derivations) while predefined measures, predefined derived chains, dimensions, filters, and segments pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(config): add per-connection query_policy to warehouse connections query_policy: semantic-layer-only | read-only-sql (default) on the warehouse connection schema, plus a policy module with the raw-SQL guard, federated member restriction lookup, and the project-level predicate used to gate sql_execution registration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(cli): enforce query_policy on raw SQL through one shared executor ktx sql and the MCP sql_execution tool now share executeProjectRawSql (resolve, policy check, read-only validation, execute), collapsing their duplicated validate-then-execute paths. Restricted connections are rejected before validation; federated raw SQL is rejected when any member is restricted. sql_execution is not registered when every SQL connection is restricted, and connection_list marks restricted connections so agents route to sl_query. executeProjectReadOnlySql stays generic for ktx-internal SQL (scan, ingest, SL-generated). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(sl): compile queries with predefined_measures_only from query_policy compileLocalSlQuery injects the flag from the connection's query_policy, never from caller input, covering both ktx sl query and the MCP sl_query tool through the daemon compile path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: document query_policy semantic-layer-only Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(sl): close semantic-layer-only bypasses via filters and federated hint The predefined_measures_only guard only inspected query.measures, so a composed aggregate written into `filters` slipped through _classify_filters into a HAVING clause untouched — letting a restricted agent evaluate arbitrary aggregates (e.g. threshold-probing `sum(x) BETWEEN a AND b`). Reject filter clauses that compose an aggregate function; a HAVING that compares a predefined measure by name (`orders.revenue > 100`) still works. Also make the federated sl_query error policy-aware: when a member is restricted, raw federated SQL is disabled too, so stop directing the agent to `ktx sql -c _ktx_federated` / sql_execution (a guaranteed failure) and point to per-connection semantic-layer queries instead. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Andrey Avtomonov <andreybavt@gmail.com>
This commit is contained in:
parent
66768fe009
commit
a651b82e2f
21 changed files with 887 additions and 68 deletions
|
|
@ -1,10 +1,14 @@
|
|||
import { describe, expect, it, vi } from 'vitest';
|
||||
import type { executeFederatedQuery } from '../../../src/connectors/duckdb/federated-executor.js';
|
||||
import { executeProjectReadOnlySql } from '../../../src/context/connections/project-sql-executor.js';
|
||||
import { executeProjectRawSql, executeProjectReadOnlySql } from '../../../src/context/connections/project-sql-executor.js';
|
||||
import type { KtxLocalProject } from '../../../src/context/project/project.js';
|
||||
import type { KtxScanConnector } from '../../../src/context/scan/types.js';
|
||||
import type { SqlAnalysisPort } from '../../../src/context/sql-analysis/ports.js';
|
||||
import { KtxQueryError } from '../../../src/errors.js';
|
||||
|
||||
function fakeProject(connections: Record<string, { driver: string }>): KtxLocalProject {
|
||||
function fakeProject(
|
||||
connections: Record<string, { driver: string; query_policy?: 'semantic-layer-only' }>,
|
||||
): KtxLocalProject {
|
||||
return {
|
||||
projectDir: '/tmp/proj',
|
||||
configPath: '/tmp/proj/ktx.yaml',
|
||||
|
|
@ -114,3 +118,97 @@ describe('executeProjectReadOnlySql headerTypes', () => {
|
|||
expect(result.headerTypes).toEqual(['INTEGER']);
|
||||
});
|
||||
});
|
||||
|
||||
function fakeSqlAnalysis(validation: { ok: boolean; error: string | null }): SqlAnalysisPort {
|
||||
return {
|
||||
analyzeForFingerprint: vi.fn(),
|
||||
analyzeBatch: vi.fn(),
|
||||
validateReadOnly: vi.fn(async () => validation),
|
||||
} as unknown as SqlAnalysisPort;
|
||||
}
|
||||
|
||||
describe('executeProjectRawSql', () => {
|
||||
it('validates then executes raw SQL on an unrestricted connection', async () => {
|
||||
const project = fakeProject({ pg: { driver: 'postgres' } });
|
||||
const sqlAnalysis = fakeSqlAnalysis({ ok: true, error: null });
|
||||
const connector = connectorReturning({
|
||||
headers: ['id'],
|
||||
rows: [[1]],
|
||||
totalRows: 1,
|
||||
rowCount: 1,
|
||||
});
|
||||
|
||||
const result = await executeProjectRawSql({
|
||||
project,
|
||||
connectionId: 'pg',
|
||||
sql: 'SELECT id FROM orders',
|
||||
maxRows: 25,
|
||||
sqlAnalysis,
|
||||
createConnector: () => connector,
|
||||
runId: 'test-raw-sql',
|
||||
});
|
||||
|
||||
expect(result.rows).toEqual([[1]]);
|
||||
expect(sqlAnalysis.validateReadOnly).toHaveBeenCalledWith('SELECT id FROM orders', 'postgres');
|
||||
});
|
||||
|
||||
it('rejects a restricted connection before validation or execution', async () => {
|
||||
const project = fakeProject({ pg: { driver: 'postgres', query_policy: 'semantic-layer-only' } });
|
||||
const sqlAnalysis = fakeSqlAnalysis({ ok: true, error: null });
|
||||
const createConnector = vi.fn();
|
||||
|
||||
const execution = executeProjectRawSql({
|
||||
project,
|
||||
connectionId: 'pg',
|
||||
sql: 'SELECT 1',
|
||||
maxRows: 25,
|
||||
sqlAnalysis,
|
||||
createConnector: createConnector as never,
|
||||
runId: 'test-raw-sql',
|
||||
});
|
||||
await expect(execution).rejects.toBeInstanceOf(KtxQueryError);
|
||||
await expect(execution).rejects.toThrow(/query_policy: semantic-layer-only/);
|
||||
expect(sqlAnalysis.validateReadOnly).not.toHaveBeenCalled();
|
||||
expect(createConnector).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('rejects federated raw SQL when a member connection is restricted', async () => {
|
||||
const project = fakeProject({
|
||||
pg: { driver: 'postgres', query_policy: 'semantic-layer-only' },
|
||||
lite: { driver: 'sqlite' },
|
||||
});
|
||||
const executeFederated = vi.fn();
|
||||
|
||||
await expect(
|
||||
executeProjectRawSql({
|
||||
project,
|
||||
connectionId: '_ktx_federated',
|
||||
sql: 'SELECT 1',
|
||||
maxRows: 25,
|
||||
sqlAnalysis: fakeSqlAnalysis({ ok: true, error: null }),
|
||||
createConnector: vi.fn() as never,
|
||||
executeFederated: executeFederated as never,
|
||||
runId: 'test-raw-sql',
|
||||
}),
|
||||
).rejects.toThrow(/"pg"/);
|
||||
expect(executeFederated).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('classifies a read-only validation failure as an expected query error', async () => {
|
||||
const project = fakeProject({ pg: { driver: 'postgres' } });
|
||||
const createConnector = vi.fn();
|
||||
|
||||
const execution = executeProjectRawSql({
|
||||
project,
|
||||
connectionId: 'pg',
|
||||
sql: 'DROP TABLE orders',
|
||||
maxRows: 25,
|
||||
sqlAnalysis: fakeSqlAnalysis({ ok: false, error: 'SQL is not read-only: DROP.' }),
|
||||
createConnector: createConnector as never,
|
||||
runId: 'test-raw-sql',
|
||||
});
|
||||
await expect(execution).rejects.toBeInstanceOf(KtxQueryError);
|
||||
await expect(execution).rejects.toThrow('SQL is not read-only: DROP.');
|
||||
expect(createConnector).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue