apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-28 08:49:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor: remove legacy ktx compatibility shims (#211)

Browse source 
* refactor: remove legacy ktx compatibility shims

* fix: restore overlay collision guidance
This commit is contained in:
Andrey Avtomonov 2026-05-24 16:57:23 +02:00 • committed by GitHub
parent a954a29a76
commit 96952fb43c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
59 changed files with 294 additions and 342 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/cli/src/context/sl/semantic-layer.service.test.ts
View file

@ -847,7 +847,7 @@ describe('loadAllSources — standalone enrichment via inherits_columns_from', (
});
});
it('reports file-attributed errors for legacy overlay column patches', async () => {
it('reports file-attributed errors for overlay columns that shadow manifest columns', async () => {
const schemaPath = 'semantic-layer/conn-1/_schema/marts.yaml';
const overlayPath = 'semantic-layer/conn-1/orders.yaml';
configService.listFiles.mockResolvedValue({ files: [schemaPath, overlayPath] });
@ -871,7 +871,8 @@ describe('loadAllSources — standalone enrichment via inherits_columns_from', (
const { loadErrors } = await service.loadAllSources('conn-1');
expect(loadErrors.join('\n')).toContain(overlayPath);
expect(loadErrors.join('\n')).toContain("move it to 'column_overrides:'");
expect(loadErrors.join('\n')).toContain("column 'id' in columns already exists on manifest source 'orders'");
expect(loadErrors.join('\n')).not.toContain('column_overrides');
});
it('reports and logs directory listing failures instead of treating them as empty sources', async () => {