refactor: remove legacy ktx compatibility shims (#211)

* refactor: remove legacy ktx compatibility shims

* fix: restore overlay collision guidance

packages/cli/src/context/connections/dialects.test.ts

@@ -4,7 +4,6 @@ import { getDialectForDriver } from './dialects.js';
 describe('getDialectForDriver', () => {
   it.each([
     ['postgres', '"public"."orders"'],
-    ['postgresql', '"public"."orders"'],
     ['mysql', '`public`.`orders`'],
     ['clickhouse', '`public`.`orders`'],
     ['sqlite', '"orders"'],
@@ -24,7 +23,12 @@ describe('getDialectForDriver', () => {
 
   it('throws with a supported-driver list for unknown drivers', () => {
     expect(() => getDialectForDriver('oracle')).toThrow(
-      'Unsupported warehouse driver "oracle". Supported drivers: bigquery, clickhouse, mysql, postgres, postgresql, sqlite, sqlite3, snowflake, sqlserver',
+      'Unsupported warehouse driver "oracle". Supported drivers: bigquery, clickhouse, mysql, postgres, sqlite, snowflake, sqlserver',
     );
   });
+
+  it('rejects legacy driver aliases', () => {
+    expect(() => getDialectForDriver('postgresql')).toThrow('Unsupported warehouse driver "postgresql"');
+    expect(() => getDialectForDriver('sqlite3')).toThrow('Unsupported warehouse driver "sqlite3"');
+  });
 });

packages/cli/src/context/connections/dialects.ts

@@ -2,14 +2,12 @@ import type { KtxSchemaDimensionType, KtxTableRef } from '../scan/types.js';
 
 type SupportedDriver =
   | 'postgres'
-  | 'postgresql'
   | 'mysql'
   | 'sqlserver'
   | 'snowflake'
   | 'bigquery'
   | 'clickhouse'
-  | 'sqlite'
-  | 'sqlite3';
+  | 'sqlite';
 
 export interface KtxDialect {
   readonly type: SupportedDriver;
@@ -23,9 +21,7 @@ const supportedDrivers: SupportedDriver[] = [
   'clickhouse',
   'mysql',
   'postgres',
-  'postgresql',
   'sqlite',
-  'sqlite3',
   'snowflake',
   'sqlserver',
 ];
@@ -83,11 +79,9 @@ function createDialect(type: SupportedDriver, quote: (identifier: string) => str
 
 const dialects: Record<SupportedDriver, KtxDialect> = {
   postgres: createDialect('postgres', doubleQuoted),
-  postgresql: createDialect('postgresql', doubleQuoted),
   mysql: createDialect('mysql', backtickQuoted),
   clickhouse: createDialect('clickhouse', backtickQuoted),
   sqlite: createDialect('sqlite', doubleQuoted, true),
-  sqlite3: createDialect('sqlite3', doubleQuoted, true),
   snowflake: createDialect('snowflake', doubleQuoted),
   bigquery: createDialect('bigquery', bigQueryQuoted),
   sqlserver: createDialect('sqlserver', bracketQuoted),

packages/cli/src/context/connections/local-query-executor.ts

@@ -22,10 +22,10 @@ export function createDefaultLocalQueryExecutor(options: DefaultLocalQueryExecut
   return {
     async execute(input: KtxSqlQueryExecutionInput): Promise<KtxSqlQueryExecutionResult> {
       const driver = driverFor(input);
-      if (driver === 'postgres' || driver === 'postgresql') {
+      if (driver === 'postgres') {
         return postgres.execute(input);
       }
-      if (driver === 'sqlite' || driver === 'sqlite3') {
+      if (driver === 'sqlite') {
         return sqlite.execute(input);
       }
       throw new Error(`No local query executor is configured for driver "${input.connection?.driver ?? 'unknown'}".`);

packages/cli/src/context/connections/local-warehouse-descriptor.test.ts

@@ -53,6 +53,11 @@ describe('local connection info helpers', () => {
     expect(localConnectionTypeForConfig('snowflake', { driver: 'snowflake' })).toBe('SNOWFLAKE');
   });
 
+  it('keeps removed driver aliases as display-only labels', () => {
+    expect(localConnectionTypeForConfig('warehouse', { driver: 'postgresql' } as never)).toBe('postgresql');
+    expect(localConnectionTypeForConfig('warehouse', { driver: 'mssql' } as never)).toBe('mssql');
+  });
+
   it('keeps non-warehouse adapter labels for display-only local connection surfaces', () => {
     expect(localConnectionTypeForConfig('prod-metabase', { driver: 'metabase', api_url: 'https://metabase.example.com' })).toBe(
       'metabase',

packages/cli/src/context/connections/local-warehouse-descriptor.ts

@@ -20,10 +20,8 @@ export interface LocalConnectionInfo {
 
 const DRIVER_TO_CONNECTION_TYPE: Record<string, ConnectionType> = {
   postgres: 'POSTGRESQL',
-  postgresql: 'POSTGRESQL',
   sqlite: 'SQLITE',
   sqlserver: 'SQLSERVER',
-  mssql: 'SQLSERVER',
   mysql: 'MYSQL',
   clickhouse: 'CLICKHOUSE',
   snowflake: 'SNOWFLAKE',

packages/cli/src/context/connections/postgres-query-executor.ts

@@ -38,7 +38,7 @@ export function createPostgresQueryExecutor(options: PostgresQueryExecutorOption
     async execute(input: KtxSqlQueryExecutionInput): Promise<KtxSqlQueryExecutionResult> {
       const driver = connectionDriver(input);
       const connection = input.connection;
-      if (driver !== 'postgres' && driver !== 'postgresql') {
+      if (driver !== 'postgres') {
         throw new Error(`Local Postgres execution cannot run driver "${connection?.driver ?? 'unknown'}".`);
       }
       if (typeof connection?.url !== 'string' || connection.url.trim().length === 0) {

packages/cli/src/context/connections/sqlite-query-executor.ts

@@ -52,7 +52,7 @@ function sqlitePathFromUrl(url: string): string {
 /** @internal */
 export function sqliteDatabasePathFromConnection(input: KtxSqlQueryExecutionInput): string {
   const driver = connectionDriver(input);
-  if (driver !== 'sqlite' && driver !== 'sqlite3') {
+  if (driver !== 'sqlite') {
     throw new Error(`Local SQLite execution cannot run driver "${input.connection?.driver ?? 'unknown'}".`);
   }