apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-07 07:55:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(cli): standardize BigQuery scope listing

Browse source
This commit is contained in:
Andrey Avtomonov 2026-05-25 13:33:03 +02:00
parent 4619217804
commit 8ec2acba40
4 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/connectors/bigquery/connector.ts
View file

@ -428,7 +428,7 @@ export class KtxBigQueryScanConnector implements KtxScanConnector {
return this.dialect.quoteIdentifier(identifier);
}
async listDatasets(): Promise<string[]> {
async listSchemas(): Promise<string[]> {
const [datasets] = await this.getClient().getDatasets();
return datasets.map((dataset) => dataset.id).filter((id): id is string => Boolean(id));
}

2
packages/cli/src/context/scan/types.ts
View file

@ -313,6 +313,8 @@ export interface KtxScanConnector {
capabilities: KtxConnectorCapabilities;
eventStreamDiscovery?: KtxEventStreamDiscoveryPort;
introspect(input: KtxScanInput, ctx: KtxScanContext): Promise<KtxSchemaSnapshot>;
listSchemas(): Promise<string[]>;
listTables(schemas?: string[]): Promise<KtxTableListEntry[]>;
testConnection?(): Promise<KtxConnectorTestResult>;
sampleColumn?(input: KtxColumnSampleInput, ctx: KtxScanContext): Promise<KtxColumnSampleResult>;
sampleTable?(input: KtxTableSampleInput, ctx: KtxScanContext): Promise<KtxTableSampleResult>;

2
packages/cli/src/setup-databases.ts
View file

@ -411,7 +411,7 @@ async function defaultListSchemas(projectDir: string, connectionId: string): Pro
if (!isKtxBigQueryConnectionConfig(connection)) return [];
const connector = new KtxBigQueryScanConnector({ connectionId, connection });
try {
return await connector.listDatasets();
return await connector.listSchemas();
} finally {
await connector.cleanup();
}

2
packages/cli/test/connectors/bigquery/connector.test.ts
View file

@ -267,7 +267,7 @@ describe('KtxBigQueryScanConnector', () => {
),
).resolves.toEqual({ values: ['open', 'paid'], cardinality: 2 });
await expect(connector.getTableRowCount('orders')).resolves.toBe(12);
await expect(connector.listDatasets()).resolves.toEqual(['analytics', 'staging']);
await expect(connector.listSchemas()).resolves.toEqual(['analytics', 'staging']);
await expect(
connector.columnStats(
{ connectionId: 'warehouse', table: { catalog: 'project-1', db: 'analytics', name: 'orders' }, column: 'status' },