apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-07-22 11:51:01 +02:00
Code Issues Projects Releases Packages Wiki Activity

Normalize semantic layer descriptions

Browse source
This commit is contained in:
Luca Martial 2026-05-11 00:31:15 -07:00
parent c82989119b
commit 86c818a454
21 changed files with 498 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

29
packages/context/src/sl/semantic-layer.service.test.ts
View file

@ -257,12 +257,14 @@ describe('sourceDefinitionSchema', () => {
it('preserves dbt structural metadata fields used by manifest-backed SL readers', () => {
const result = sourceDefinitionSchema.safeParse({
name: 'orders',
descriptions: { dbt: 'Order facts from dbt.' },
table: 'public.orders',
grain: ['id'],
columns: [
{
name: 'status',
type: 'string',
descriptions: { dbt: 'Order lifecycle status.' },
constraints: { dbt: { not_null: true, unique: true } },
enum_values: { dbt: ['placed', 'shipped'] },
tests: {
@ -282,7 +284,9 @@ describe('sourceDefinitionSchema', () => {
if (!result.success) {
return;
}
expect(result.data.descriptions).toEqual({ dbt: 'Order facts from dbt.' });
expect(result.data.columns[0]).toMatchObject({
descriptions: { dbt: 'Order lifecycle status.' },
constraints: { dbt: { not_null: true, unique: true } },
enum_values: { dbt: ['placed', 'shipped'] },
tests: {
@ -528,6 +532,31 @@ describe('loadAllSources — standalone enrichment via inherits_columns_from', (
const aav = sources.find((s) => s.name === 'aav_consignments');
expect(aav?.columns).toEqual([{ name: 'FOO', type: 'string' }]);
});
it('normalizes legacy flat source and column descriptions when loading standalone files', async () => {
const standalonePath = 'semantic-layer/conn-1/orders.yaml';
configService.listFiles.mockResolvedValue({ files: [standalonePath] });
configService.readFile.mockResolvedValue({
content: [
'name: orders',
'description: Finance orders used for invoice reconciliation.',
'table: public.orders',
'grain: [id]',
'columns:',
' - name: id',
' type: string',
' description: Stable order identifier.',
].join('\n'),
});
const sources = await service.loadAllSources('conn-1');
expect(sources[0]).toMatchObject({
name: 'orders',
descriptions: { user: 'Finance orders used for invoice reconciliation.' },
columns: [{ name: 'id', type: 'string', descriptions: { user: 'Stable order identifier.' } }],
});
});
});
describe('validateWithProposedSource', () => {