apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-19 08:28:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(setup): require explicit no-input database scope (#286)

Browse source 
* test(setup): supply explicit --no-input scope to disabled-mode database tests

* fix(setup): require explicit database scope in --no-input instead of auto-scanning the warehouse

* docs(setup): document --no-input database scope requirement
This commit is contained in:
Andrey Avtomonov 2026-06-10 12:36:53 +02:00 • committed by GitHub
parent 036a745fc1
commit 853f39a7c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 138 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

53
packages/cli/src/setup-databases.ts
View file

@ -1382,35 +1382,32 @@ async function maybeConfigureDatabaseScope(input: {
const cliSchemas = input.args.databaseSchemas;
if (input.args.inputMode === 'disabled') {
if (spec) {
let scopeToWrite: string[] = cliSchemas;
if (scopeToWrite.length === 0) {
try {
scopeToWrite = unique(
await (input.deps.listSchemas ?? defaultListSchemas)(input.projectDir, input.connectionId),
);
} catch (error) {
const detail = error instanceof Error ? error.message : String(error);
input.io.stderr.write(
`Could not discover ${spec.promptLabel.toLowerCase()} for ${input.connectionId}; ${detail}\n`,
);
return okValidateResult();
}
}
if (scopeToWrite.length > 0) {
await writeScopeConfig({
projectDir: input.projectDir,
connectionId: input.connectionId,
values: scopeToWrite,
spec,
});
const capitalNounPlural = spec.nounPlural[0]!.toUpperCase() + spec.nounPlural.slice(1);
writeSetupSection(input.io, `${capitalNounPlural} saved for ${input.connectionId}`, [
`✓ ${scopeToWrite.join(', ')}`,
]);
}
if (!spec) {
return okValidateResult();
}
return okValidateResult();
if (cliSchemas.length > 0) {
await writeScopeConfig({
projectDir: input.projectDir,
connectionId: input.connectionId,
values: cliSchemas,
spec,
});
const capitalNounPlural = spec.nounPlural[0]!.toUpperCase() + spec.nounPlural.slice(1);
writeSetupSection(input.io, `${capitalNounPlural} saved for ${input.connectionId}`, [
`✓ ${cliSchemas.join(', ')}`,
]);
return okValidateResult();
}
if (existingScope.length > 0) {
return okValidateResult();
}
writePrefixedLines(
(chunk) => input.io.stderr.write(chunk),
`No ${spec.nounPlural} configured for ${input.connectionId}. ` +
`Pass --database-schema <${spec.noun}> (repeatable) or set ` +
`connections.${input.connectionId}.${spec.configArrayField} in ktx.yaml.`,
);
return failedValidateResult();
}
if (spec && cliSchemas.length > 0) {