mirror of
https://github.com/Kaelio/ktx.git
synced 2026-07-19 11:41:02 +02:00
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
This commit is contained in:
parent
924868841d
commit
56985b7e09
548 changed files with 5048 additions and 2228 deletions
|
|
@ -1,146 +0,0 @@
|
|||
import { describe, expect, it, vi } from 'vitest';
|
||||
import { validateSingleSource } from './sl-warehouse-validation.js';
|
||||
|
||||
function makeDeps(opts: { sourceYaml: string; executeQuery: ReturnType<typeof vi.fn> }) {
|
||||
return {
|
||||
semanticLayerService: {
|
||||
readSourceFile: vi.fn().mockResolvedValue({ content: opts.sourceYaml, path: 'x' }),
|
||||
isManifestBacked: vi.fn().mockResolvedValue(false),
|
||||
listManifestSourceNames: vi.fn().mockResolvedValue([]),
|
||||
loadSource: vi.fn().mockResolvedValue(null),
|
||||
loadAllSources: vi.fn().mockResolvedValue({ sources: [], loadErrors: [] }),
|
||||
validatePhysicalTableReferences: vi.fn().mockResolvedValue([]),
|
||||
} as never,
|
||||
connections: {
|
||||
executeQuery: opts.executeQuery,
|
||||
getConnectionById: vi.fn().mockResolvedValue({ id: 'conn-1', name: 'conn-1', connectionType: 'bigquery' }),
|
||||
listEnabledConnections: vi.fn().mockResolvedValue([]),
|
||||
} as never,
|
||||
configService: {} as never,
|
||||
gitService: {} as never,
|
||||
slSourcesRepository: { deleteByConnectionAndName: vi.fn().mockResolvedValue(undefined) } as never,
|
||||
probeRowCount: 1,
|
||||
};
|
||||
}
|
||||
|
||||
describe('validateSingleSource warehouse dry-run', () => {
|
||||
it('surfaces warehouse error when dry-run fails on unknown column', async () => {
|
||||
const yaml = `name: fct_arr_delta
|
||||
source_type: sql
|
||||
sql: |
|
||||
SELECT * FROM analytics.fct_arr_delta WHERE date_date < CURRENT_DATE()
|
||||
grain: [date_date]
|
||||
columns:
|
||||
- name: date_date
|
||||
type: time
|
||||
measures:
|
||||
- name: count_delta_events
|
||||
expr: count(*)
|
||||
joins: []
|
||||
`;
|
||||
const executeQuery = vi.fn().mockRejectedValue(new Error('Unrecognized name: date_date at [1:42]'));
|
||||
const deps = makeDeps({ sourceYaml: yaml, executeQuery });
|
||||
const result = await validateSingleSource(deps, 'conn-1', 'fct_arr_delta');
|
||||
expect(result.errors.join('\n')).toMatch(/Unrecognized name: date_date/);
|
||||
expect(result.errors.join('\n')).toMatch(/embedded sql dry-run failed/);
|
||||
});
|
||||
|
||||
it('flags declared columns missing from the dry-run result', async () => {
|
||||
const yaml = `name: fct_arr_delta
|
||||
source_type: sql
|
||||
sql: |
|
||||
SELECT date, customer_id FROM analytics.fct_arr_delta
|
||||
columns:
|
||||
- name: date_date
|
||||
type: time
|
||||
- name: customer_id
|
||||
type: string
|
||||
measures:
|
||||
- name: count_delta
|
||||
expr: count(*)
|
||||
joins: []
|
||||
grain: [customer_id]
|
||||
`;
|
||||
const executeQuery = vi.fn().mockResolvedValue({
|
||||
headers: ['date', 'customer_id'],
|
||||
rows: [],
|
||||
totalRows: 0,
|
||||
error: null,
|
||||
});
|
||||
const deps = makeDeps({ sourceYaml: yaml, executeQuery });
|
||||
const result = await validateSingleSource(deps, 'conn-1', 'fct_arr_delta');
|
||||
expect(result.errors.join('\n')).toMatch(/declared columns absent from sql result — date_date/);
|
||||
expect(result.errors.join('\n')).toMatch(/warehouse returned:/);
|
||||
});
|
||||
|
||||
it('passes cleanly when dry-run succeeds and declared columns match', async () => {
|
||||
const yaml = `name: lab_results
|
||||
source_type: sql
|
||||
sql: |
|
||||
SELECT lab_order_id, admin_user_id FROM analytics.raw_lab_results
|
||||
grain: [lab_order_id]
|
||||
columns:
|
||||
- name: lab_order_id
|
||||
type: string
|
||||
- name: admin_user_id
|
||||
type: string
|
||||
measures:
|
||||
- name: count_lab_results
|
||||
expr: count(lab_order_id)
|
||||
joins: []
|
||||
`;
|
||||
const executeQuery = vi.fn().mockResolvedValue({
|
||||
headers: ['lab_order_id', 'admin_user_id'],
|
||||
rows: [],
|
||||
totalRows: 0,
|
||||
error: null,
|
||||
});
|
||||
const deps = makeDeps({ sourceYaml: yaml, executeQuery });
|
||||
const result = await validateSingleSource(deps, 'conn-1', 'lab_results');
|
||||
expect(result.errors).toEqual([]);
|
||||
});
|
||||
|
||||
it('uses LIMIT 1 (not LIMIT 0) so runtime policies fire', async () => {
|
||||
const yaml = `name: foo
|
||||
source_type: sql
|
||||
sql: |
|
||||
SELECT a FROM analytics.bar
|
||||
grain: [a]
|
||||
columns:
|
||||
- {name: a, type: string}
|
||||
measures: []
|
||||
joins: []
|
||||
`;
|
||||
const executeQuery = vi.fn().mockResolvedValue({ headers: ['a'], rows: [], totalRows: 0, error: null });
|
||||
const deps = makeDeps({ sourceYaml: yaml, executeQuery });
|
||||
await validateSingleSource(deps, 'conn-1', 'foo');
|
||||
const probeSql = executeQuery.mock.calls[0][1] as string;
|
||||
expect(probeSql).toMatch(/LIMIT 1\b/);
|
||||
expect(probeSql).not.toMatch(/LIMIT 0\b/);
|
||||
});
|
||||
|
||||
it('adds physical manifest errors for table-backed sources', async () => {
|
||||
const yaml = `name: int_active_contract_arr
|
||||
table: orbit_analytics.int_active_contract_arr
|
||||
grain: [contract_id]
|
||||
columns:
|
||||
- {name: contract_id, type: string}
|
||||
- {name: arr_cents, type: number}
|
||||
measures:
|
||||
- {name: arr, expr: sum(arr_cents)}
|
||||
joins: []
|
||||
`;
|
||||
const executeQuery = vi.fn();
|
||||
const deps = makeDeps({ sourceYaml: yaml, executeQuery }) as any;
|
||||
deps.semanticLayerService.validatePhysicalTableReferences.mockResolvedValue([
|
||||
'int_active_contract_arr.yaml: declared column(s) absent from physical table: arr_cents',
|
||||
]);
|
||||
|
||||
const result = await validateSingleSource(deps, 'conn-1', 'int_active_contract_arr');
|
||||
|
||||
expect(result.errors).toContain(
|
||||
'int_active_contract_arr.yaml: declared column(s) absent from physical table: arr_cents',
|
||||
);
|
||||
expect(executeQuery).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue