mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-22 08:38:08 +02:00
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
This commit is contained in:
parent
924868841d
commit
56985b7e09
548 changed files with 5048 additions and 2228 deletions
|
|
@ -1,177 +0,0 @@
|
|||
import { describe, expect, it } from 'vitest';
|
||||
import { createInitialMemoryFlowInteractionState, reduceMemoryFlowInteractionState } from './interaction.js';
|
||||
import { renderMemoryFlowInteractive } from './interactive-render.js';
|
||||
import type { MemoryFlowViewModel } from './types.js';
|
||||
|
||||
function view(): MemoryFlowViewModel {
|
||||
return {
|
||||
title: 'KTX memory flow warehouse/metricflow done',
|
||||
subtitle: 'Run run-1 Sync sync-1',
|
||||
status: 'done',
|
||||
activeLine: 'active: complete',
|
||||
selectedTitle: 'WORKUNITS',
|
||||
selectedDetails: ['orders: 1 raw, 0 peers, 1 deps'],
|
||||
completionLine:
|
||||
'Saved 2 memories from 2 raw files: 1 wiki pages, 1 SL updates. Commit: abc12345 Run: run-1 Report: report-1',
|
||||
trustIssues: [
|
||||
{
|
||||
id: 'work-unit-failed:customers',
|
||||
severity: 'failed',
|
||||
title: 'WorkUnit failed',
|
||||
detail: 'customers failed: validation reset',
|
||||
columnId: 'workUnits',
|
||||
targetLabel: 'customers',
|
||||
},
|
||||
{
|
||||
id: 'flagged-fallbacks',
|
||||
severity: 'warning',
|
||||
title: 'Flagged fallbacks',
|
||||
detail: '1 fallback needs review',
|
||||
columnId: 'gates',
|
||||
},
|
||||
],
|
||||
details: {
|
||||
actions: [
|
||||
{
|
||||
unitKey: 'orders',
|
||||
target: 'wiki',
|
||||
action: 'created',
|
||||
key: 'wiki/orders.md',
|
||||
summary: 'order facts',
|
||||
rawFiles: ['orders.yml'],
|
||||
status: 'success',
|
||||
},
|
||||
],
|
||||
provenance: [
|
||||
{
|
||||
rawPath: 'orders.yml',
|
||||
artifactKind: 'wiki',
|
||||
artifactKey: 'wiki/orders.md',
|
||||
actionType: 'wiki_written',
|
||||
},
|
||||
],
|
||||
transcripts: [
|
||||
{
|
||||
unitKey: 'customers',
|
||||
path: '/tmp/transcripts/customers.jsonl',
|
||||
toolCallCount: 2,
|
||||
errorCount: 1,
|
||||
toolNames: ['read_raw_span', 'sl_write_source'],
|
||||
},
|
||||
],
|
||||
},
|
||||
columns: [
|
||||
{
|
||||
id: 'source',
|
||||
title: 'SOURCE',
|
||||
status: 'complete',
|
||||
headline: '2 raw files',
|
||||
counters: ['sync sync-1', 'scope none'],
|
||||
chips: [{ label: 'metricflow', status: 'complete' }],
|
||||
details: ['Trigger: manual_resync', 'Adapter: metricflow'],
|
||||
},
|
||||
{
|
||||
id: 'chunks',
|
||||
title: 'CHUNKS',
|
||||
status: 'complete',
|
||||
headline: '2 chunks',
|
||||
counters: ['+1 ~1 -0 =0', '0 deletions'],
|
||||
chips: [{ label: 'orders', status: 'complete' }],
|
||||
details: ['Work units planned: 2', 'Eviction candidates: 0'],
|
||||
},
|
||||
{
|
||||
id: 'workUnits',
|
||||
title: 'WORKUNITS',
|
||||
status: 'warning',
|
||||
headline: '2 WUs',
|
||||
counters: ['1 done', '1 failed', '0 active'],
|
||||
chips: [
|
||||
{ label: 'orders', status: 'complete', detail: '1 raw span' },
|
||||
{ label: 'customers', status: 'failed', detail: 'validation reset' },
|
||||
],
|
||||
details: ['orders: 1 raw, 0 peers, 1 deps', 'customers: 1 raw, 0 peers, 0 deps'],
|
||||
},
|
||||
{
|
||||
id: 'actions',
|
||||
title: 'ACTIONS',
|
||||
status: 'complete',
|
||||
headline: '2 candidates',
|
||||
counters: ['1 wiki', '1 SL'],
|
||||
chips: [{ label: 'wiki/orders.md', status: 'complete' }],
|
||||
details: ['wiki created: wiki/orders.md', 'sl updated: warehouse.orders'],
|
||||
},
|
||||
{
|
||||
id: 'gates',
|
||||
title: 'GATES',
|
||||
status: 'warning',
|
||||
headline: '0 conflict, 1 fallback',
|
||||
counters: ['1 failed', '1 flagged'],
|
||||
chips: [{ label: 'customers', status: 'failed' }],
|
||||
details: ['Failed work units: 1', 'Flagged fallbacks: 1'],
|
||||
},
|
||||
{
|
||||
id: 'saved',
|
||||
title: 'SAVED',
|
||||
status: 'complete',
|
||||
headline: '2 memories',
|
||||
counters: ['1 wiki', '1 SL', '2 provenance'],
|
||||
chips: [{ label: 'abc12345', status: 'complete' }],
|
||||
details: ['Commit: abc12345', 'Run: run-1', 'Report: report-1', 'Provenance rows: 2'],
|
||||
},
|
||||
],
|
||||
};
|
||||
}
|
||||
|
||||
describe('renderMemoryFlowInteractive', () => {
|
||||
it('marks the selected column and selected chip in a wide layout', () => {
|
||||
const state = createInitialMemoryFlowInteractionState(view());
|
||||
|
||||
const output = renderMemoryFlowInteractive(view(), state, { terminalWidth: 140 });
|
||||
|
||||
expect(output).toContain('KTX memory flow warehouse/metricflow done');
|
||||
expect(output).toContain('OK SOURCE -> OK CHUNKS -> !! WORKUNITS -> OK ACTIONS -> !! GATES -> OK SAVED');
|
||||
expect(output).toContain('[WORKUNITS]');
|
||||
expect(output).toContain('> orders');
|
||||
expect(output).toContain('Selected: WORKUNITS > orders');
|
||||
expect(output).toContain('Pane: overview Filter: all');
|
||||
expect(output).toContain('- Selected chip: orders (1 raw span)');
|
||||
expect(output).toContain(
|
||||
'Saved 2 memories from 2 raw files: 1 wiki pages, 1 SL updates. Commit: abc12345 Run: run-1 Report: report-1',
|
||||
);
|
||||
});
|
||||
|
||||
it('renders attention-filtered details in a narrow layout', () => {
|
||||
let state = createInitialMemoryFlowInteractionState(view());
|
||||
state = reduceMemoryFlowInteractionState(state, 'filter', view());
|
||||
state = reduceMemoryFlowInteractionState(state, 'enter', view());
|
||||
|
||||
const output = renderMemoryFlowInteractive(view(), state, { terminalWidth: 72 });
|
||||
|
||||
expect(output).toContain('OK SOURCE -> OK CHUNKS -> !! WORKUNITS -> OK ACTIONS -> !! GATES -> OK SAVED');
|
||||
expect(output).toContain('[WORKUNITS]');
|
||||
expect(output).toContain('Filter: failed_or_flagged');
|
||||
expect(output).toContain('> customers');
|
||||
expect(output).toContain('- customers: 1 raw, 0 peers, 0 deps');
|
||||
});
|
||||
|
||||
it('renders report-backed transcript detail pane rows', () => {
|
||||
let state = createInitialMemoryFlowInteractionState(view());
|
||||
state = reduceMemoryFlowInteractionState(state, 'down', view());
|
||||
state = reduceMemoryFlowInteractionState(state, 'transcript', view());
|
||||
|
||||
const output = renderMemoryFlowInteractive(view(), state, { terminalWidth: 100 });
|
||||
|
||||
expect(output).toContain('Pane: transcript Filter: all');
|
||||
expect(output).toContain('- customers: 2 tool calls, 1 errors, tools read_raw_span, sl_write_source');
|
||||
});
|
||||
|
||||
it('keeps trust issues visible in the interactive renderer', () => {
|
||||
const state = createInitialMemoryFlowInteractionState(view());
|
||||
|
||||
const output = renderMemoryFlowInteractive(view(), state, { terminalWidth: 140 });
|
||||
|
||||
expect(output).toContain('Trust issues');
|
||||
expect(output).toContain('FAILED WorkUnit failed: customers failed: validation reset');
|
||||
expect(output).toContain('WARNING Flagged fallbacks: 1 fallback needs review');
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue