mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-25 08:48:08 +02:00
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
This commit is contained in:
parent
924868841d
commit
56985b7e09
548 changed files with 5048 additions and 2228 deletions
|
|
@ -1,113 +0,0 @@
|
|||
import { describe, expect, it, vi } from 'vitest';
|
||||
import {
|
||||
HistoricSqlExtensionMissingError,
|
||||
HistoricSqlGrantsMissingError,
|
||||
HistoricSqlVersionUnsupportedError,
|
||||
} from '../adapters/historic-sql/errors.js';
|
||||
import { PostgresPgssProbeRunner } from './postgres-runner.js';
|
||||
|
||||
describe('PostgresPgssProbeRunner', () => {
|
||||
it('runs the pg_stat_statements reader and cleans up the client', async () => {
|
||||
const cleanup = vi.fn(async () => undefined);
|
||||
const reader = {
|
||||
probe: vi.fn(async () => ({
|
||||
pgServerVersion: 'PostgreSQL 16.4',
|
||||
warnings: [],
|
||||
info: ['tracked statements: 12'],
|
||||
})),
|
||||
};
|
||||
const runner = new PostgresPgssProbeRunner({
|
||||
reader,
|
||||
createClient: () => ({ client: { executeQuery: vi.fn() }, cleanup }),
|
||||
});
|
||||
|
||||
await expect(
|
||||
runner.run({
|
||||
projectDir: '/work/project',
|
||||
connectionId: 'warehouse',
|
||||
connection: { driver: 'postgres', url: 'env:DATABASE_URL' },
|
||||
env: {},
|
||||
}),
|
||||
).resolves.toEqual({
|
||||
pgServerVersion: 'PostgreSQL 16.4',
|
||||
warnings: [],
|
||||
info: ['tracked statements: 12'],
|
||||
});
|
||||
expect(reader.probe).toHaveBeenCalledOnce();
|
||||
expect(cleanup).toHaveBeenCalledOnce();
|
||||
});
|
||||
|
||||
it('rejects non-Postgres connections', async () => {
|
||||
const runner = new PostgresPgssProbeRunner({
|
||||
reader: { probe: vi.fn() },
|
||||
createClient: () => ({ client: {}, cleanup: vi.fn() }),
|
||||
});
|
||||
|
||||
await expect(
|
||||
runner.run({
|
||||
projectDir: '/work/project',
|
||||
connectionId: 'warehouse',
|
||||
connection: { driver: 'snowflake' },
|
||||
env: {},
|
||||
}),
|
||||
).rejects.toThrow('Native PostgreSQL connector cannot run driver "snowflake"');
|
||||
});
|
||||
|
||||
it('formats successful Postgres details', () => {
|
||||
const runner = new PostgresPgssProbeRunner();
|
||||
|
||||
expect(
|
||||
runner.formatSuccessDetail({
|
||||
pgServerVersion: 'PostgreSQL 16.4',
|
||||
warnings: ['pg_stat_statements.track is top'],
|
||||
info: ['tracked statements: 12'],
|
||||
}),
|
||||
).toEqual({
|
||||
detail: 'pg_stat_statements ready (PostgreSQL 16.4); tracked statements: 12',
|
||||
warnings: ['pg_stat_statements.track is top'],
|
||||
});
|
||||
});
|
||||
|
||||
it('maps Postgres probe errors to actionable advice', () => {
|
||||
const runner = new PostgresPgssProbeRunner();
|
||||
|
||||
expect(
|
||||
runner.fixAdvice(
|
||||
new HistoricSqlExtensionMissingError({
|
||||
dialect: 'postgres',
|
||||
message: 'pg_stat_statements missing',
|
||||
remediation: 'CREATE EXTENSION pg_stat_statements;',
|
||||
}),
|
||||
),
|
||||
).toEqual({
|
||||
failHeadline: 'pg_stat_statements extension is missing',
|
||||
remediation: 'CREATE EXTENSION pg_stat_statements;',
|
||||
});
|
||||
|
||||
expect(
|
||||
runner.fixAdvice(
|
||||
new HistoricSqlGrantsMissingError({
|
||||
dialect: 'postgres',
|
||||
message: 'missing grants',
|
||||
remediation: 'GRANT pg_read_all_stats TO <connection role>;',
|
||||
}),
|
||||
),
|
||||
).toEqual({
|
||||
failHeadline: 'Postgres connection role lacks pg_read_all_stats',
|
||||
remediation: 'GRANT pg_read_all_stats TO <connection role>;',
|
||||
});
|
||||
|
||||
expect(
|
||||
runner.fixAdvice(
|
||||
new HistoricSqlVersionUnsupportedError({
|
||||
dialect: 'postgres',
|
||||
detectedVersion: 'PostgreSQL 13.12',
|
||||
minimumVersion: 'PostgreSQL 14',
|
||||
}),
|
||||
),
|
||||
).toEqual({
|
||||
failHeadline: 'Postgres version too old',
|
||||
remediation: 'Use PostgreSQL 14 or newer, or disable query history for this connection',
|
||||
});
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue