mirror of
https://github.com/Kaelio/ktx.git
synced 2026-07-13 11:22:11 +02:00
chore(workspace): gate dead-code with knip production mode (#196)
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
This commit is contained in:
Andrey Avtomonov
GitHub
parent
a1cfb03d73
commit
2366b00301
1002 changed files with 2286 additions and 12051 deletions
436
packages/cli/src/context/ingest/memory-flow/view-model.test.ts
Normal file
436
packages/cli/src/context/ingest/memory-flow/view-model.test.ts
Normal file
|
|
@ -0,0 +1,436 @@
|
|||
import { describe, expect, it } from 'vitest';
|
||||
import type { MemoryFlowReplayInput } from './types.js';
|
||||
import { buildMemoryFlowViewModel } from './view-model.js';
|
||||
|
||||
function replayInput(): MemoryFlowReplayInput {
|
||||
return {
|
||||
runId: 'run-1',
|
||||
connectionId: 'warehouse',
|
||||
adapter: 'metricflow',
|
||||
status: 'done',
|
||||
sourceDir: '/tmp/source',
|
||||
syncId: 'sync-1',
|
||||
errors: [],
|
||||
plannedWorkUnits: [
|
||||
{ unitKey: 'orders', rawFiles: ['orders.yml'], peerFileCount: 1, dependencyCount: 1 },
|
||||
{ unitKey: 'revenue', rawFiles: ['revenue.yml'], peerFileCount: 0, dependencyCount: 0 },
|
||||
],
|
||||
details: {
|
||||
actions: [
|
||||
{
|
||||
unitKey: 'orders',
|
||||
target: 'wiki',
|
||||
action: 'created',
|
||||
key: 'wiki/orders.md',
|
||||
summary: 'order facts',
|
||||
rawFiles: ['orders.yml'],
|
||||
status: 'success',
|
||||
},
|
||||
{
|
||||
unitKey: 'orders',
|
||||
target: 'sl',
|
||||
action: 'updated',
|
||||
key: 'warehouse.orders',
|
||||
summary: 'order measures',
|
||||
rawFiles: ['orders.yml'],
|
||||
status: 'success',
|
||||
},
|
||||
],
|
||||
provenance: [
|
||||
{
|
||||
rawPath: 'orders.yml',
|
||||
artifactKind: 'wiki',
|
||||
artifactKey: 'wiki/orders.md',
|
||||
actionType: 'wiki_written',
|
||||
},
|
||||
],
|
||||
transcripts: [
|
||||
{
|
||||
unitKey: 'orders',
|
||||
path: '/tmp/transcripts/orders.jsonl',
|
||||
toolCallCount: 3,
|
||||
errorCount: 0,
|
||||
toolNames: ['read_raw_span', 'wiki_write', 'sl_write_source'],
|
||||
},
|
||||
],
|
||||
},
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'metricflow', trigger: 'manual_resync', fileCount: 2 },
|
||||
{ type: 'scope_detected', fingerprint: 'scope-abc' },
|
||||
{ type: 'raw_snapshot_written', syncId: 'sync-1', rawFileCount: 2 },
|
||||
{ type: 'diff_computed', added: 1, modified: 1, deleted: 0, unchanged: 3 },
|
||||
{ type: 'chunks_planned', chunkCount: 2, workUnitCount: 2, evictionCount: 0 },
|
||||
{ type: 'work_unit_started', unitKey: 'orders', skills: ['wiki_capture'], stepBudget: 40 },
|
||||
{ type: 'candidate_action', unitKey: 'orders', target: 'wiki', action: 'created', key: 'wiki/orders.md' },
|
||||
{ type: 'candidate_action', unitKey: 'orders', target: 'sl', action: 'updated', key: 'warehouse.orders' },
|
||||
{ type: 'work_unit_finished', unitKey: 'orders', status: 'success' },
|
||||
{ type: 'work_unit_finished', unitKey: 'revenue', status: 'failed', reason: 'validation failed' },
|
||||
{ type: 'reconciliation_finished', conflictCount: 1, fallbackCount: 1 },
|
||||
{ type: 'saved', commitSha: 'abc123456789', wikiCount: 1, slCount: 1 }, // pragma: allowlist secret
|
||||
{ type: 'provenance_recorded', rowCount: 3 },
|
||||
{ type: 'report_created', runId: 'run-1', reportPath: 'report-1' },
|
||||
],
|
||||
};
|
||||
}
|
||||
|
||||
function baseReplayInput(overrides: Partial<MemoryFlowReplayInput> = {}): MemoryFlowReplayInput {
|
||||
return {
|
||||
runId: 'run-errors',
|
||||
connectionId: 'warehouse',
|
||||
adapter: 'metricflow',
|
||||
status: 'error',
|
||||
sourceDir: '/tmp/source',
|
||||
syncId: 'sync-errors',
|
||||
errors: [],
|
||||
events: [],
|
||||
plannedWorkUnits: [],
|
||||
details: { actions: [], provenance: [], transcripts: [] },
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe('buildMemoryFlowViewModel', () => {
|
||||
it('builds six readable columns from replay events', () => {
|
||||
const view = buildMemoryFlowViewModel(replayInput());
|
||||
|
||||
expect(view.title).toBe('KTX memory flow warehouse/metricflow done');
|
||||
expect(view.activeLine).toBe('active: complete');
|
||||
expect(view.columns.map((column) => column.id)).toEqual([
|
||||
'source',
|
||||
'chunks',
|
||||
'workUnits',
|
||||
'actions',
|
||||
'gates',
|
||||
'saved',
|
||||
]);
|
||||
expect(view.columns.map((column) => column.headline)).toEqual([
|
||||
'2 raw files',
|
||||
'2 chunks',
|
||||
'2 WUs',
|
||||
'2 candidates',
|
||||
'1 conflict, 1 fallback',
|
||||
'2 memories',
|
||||
]);
|
||||
expect(view.columns.find((column) => column.id === 'workUnits')?.counters).toEqual([
|
||||
'1 done',
|
||||
'1 failed',
|
||||
'0 active',
|
||||
]);
|
||||
expect(view.columns.find((column) => column.id === 'actions')?.counters).toEqual(['1 wiki', '1 SL']);
|
||||
expect(view.details.actions).toHaveLength(2);
|
||||
expect(view.details.provenance).toEqual([
|
||||
{
|
||||
rawPath: 'orders.yml',
|
||||
artifactKind: 'wiki',
|
||||
artifactKey: 'wiki/orders.md',
|
||||
actionType: 'wiki_written',
|
||||
},
|
||||
]);
|
||||
expect(view.details.transcripts).toEqual([
|
||||
{
|
||||
unitKey: 'orders',
|
||||
path: '/tmp/transcripts/orders.jsonl',
|
||||
toolCallCount: 3,
|
||||
errorCount: 0,
|
||||
toolNames: ['read_raw_span', 'wiki_write', 'sl_write_source'],
|
||||
},
|
||||
]);
|
||||
expect(view.columns.find((column) => column.id === 'actions')?.details).toContain(
|
||||
'orders wiki created wiki/orders.md: order facts',
|
||||
);
|
||||
expect(view.columns.find((column) => column.id === 'saved')?.details).toContain('Commit: abc12345');
|
||||
expect(view.completionLine).toBe(
|
||||
'Saved 2 memories from 2 raw files: 1 wiki pages, 1 SL updates. Commit: abc12345 Run: run-1 Report: report-1',
|
||||
);
|
||||
});
|
||||
|
||||
it('shows all seeded demo source families and sums raw files in the completion line', () => {
|
||||
const view = buildMemoryFlowViewModel({
|
||||
runId: 'demo-seeded-orbit',
|
||||
connectionId: 'orbit_demo',
|
||||
adapter: 'live-database',
|
||||
status: 'done',
|
||||
sourceDir: null,
|
||||
syncId: 'demo-seeded-sync',
|
||||
errors: [],
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'live-database', trigger: 'demo_seeded', fileCount: 8 },
|
||||
{ type: 'source_acquired', adapter: 'dbt_descriptions', trigger: 'demo_seeded', fileCount: 6 },
|
||||
{ type: 'source_acquired', adapter: 'looker', trigger: 'demo_seeded', fileCount: 7 },
|
||||
{ type: 'source_acquired', adapter: 'notion', trigger: 'demo_seeded', fileCount: 8 },
|
||||
{ type: 'chunks_planned', chunkCount: 1, workUnitCount: 1, evictionCount: 0 },
|
||||
{ type: 'work_unit_started', unitKey: 'revenue-and-contracts', skills: ['wiki_capture'], stepBudget: 40 },
|
||||
{
|
||||
type: 'candidate_action',
|
||||
unitKey: 'revenue-and-contracts',
|
||||
target: 'wiki',
|
||||
action: 'created',
|
||||
key: 'wiki/global/arr-contract-first.md',
|
||||
},
|
||||
{ type: 'work_unit_finished', unitKey: 'revenue-and-contracts', status: 'success' },
|
||||
{ type: 'reconciliation_finished', conflictCount: 0, fallbackCount: 0 },
|
||||
{ type: 'saved', commitSha: 'demo-seeded', wikiCount: 10, slCount: 6 },
|
||||
{ type: 'provenance_recorded', rowCount: 23 },
|
||||
{ type: 'report_created', runId: 'demo-seeded-orbit', reportPath: 'reports/seeded-demo-report.json' },
|
||||
],
|
||||
plannedWorkUnits: [
|
||||
{ unitKey: 'revenue-and-contracts', rawFiles: ['contracts'], peerFileCount: 1, dependencyCount: 1 },
|
||||
],
|
||||
details: { actions: [], provenance: [], transcripts: [] },
|
||||
});
|
||||
|
||||
expect(view.title).toBe('KTX memory flow Warehouse + dbt + BI + Docs done');
|
||||
expect(view.columns.find((column) => column.id === 'source')?.counters[0]).toBe('Warehouse, dbt, BI, Docs');
|
||||
expect(view.completionLine).toContain('Saved 16 memories from 29 raw files');
|
||||
});
|
||||
|
||||
it('derives sticky trust issues from failed work units, gates, and provenance mismatch', () => {
|
||||
const input = replayInput();
|
||||
const view = buildMemoryFlowViewModel({
|
||||
...input,
|
||||
events: [
|
||||
...input.events.filter((event) => event.type !== 'provenance_recorded'),
|
||||
{ type: 'provenance_recorded', rowCount: 1 },
|
||||
],
|
||||
});
|
||||
|
||||
expect(view.trustIssues).toEqual([
|
||||
{
|
||||
id: 'work-unit-failed:revenue',
|
||||
severity: 'failed',
|
||||
title: 'WorkUnit failed',
|
||||
detail: 'revenue failed: validation failed',
|
||||
columnId: 'workUnits',
|
||||
targetLabel: 'revenue',
|
||||
},
|
||||
{
|
||||
id: 'sl-validation-reverted:revenue',
|
||||
severity: 'warning',
|
||||
title: 'SL validation revert',
|
||||
detail: 'revenue reverted after semantic-layer validation failure',
|
||||
columnId: 'gates',
|
||||
targetLabel: 'revenue',
|
||||
},
|
||||
{
|
||||
id: 'reconciliation-conflicts',
|
||||
severity: 'warning',
|
||||
title: 'Reconciliation conflicts',
|
||||
detail: '1 conflict resolved during reconciliation',
|
||||
columnId: 'gates',
|
||||
},
|
||||
{
|
||||
id: 'flagged-fallbacks',
|
||||
severity: 'warning',
|
||||
title: 'Flagged fallbacks',
|
||||
detail: '1 fallback needs review',
|
||||
columnId: 'gates',
|
||||
},
|
||||
{
|
||||
id: 'provenance-mismatch',
|
||||
severity: 'warning',
|
||||
title: 'Provenance mismatch',
|
||||
detail: '2 saved memories but 1 provenance rows recorded',
|
||||
columnId: 'saved',
|
||||
},
|
||||
]);
|
||||
expect(view.columns.find((column) => column.id === 'workUnits')?.chips).toContainEqual({
|
||||
label: 'revenue',
|
||||
status: 'failed',
|
||||
detail: 'validation failed',
|
||||
});
|
||||
});
|
||||
|
||||
it('accepts multiple provenance rows per saved memory', () => {
|
||||
const input = replayInput();
|
||||
const view = buildMemoryFlowViewModel({
|
||||
...input,
|
||||
events: [
|
||||
...input.events.filter((event) => event.type !== 'provenance_recorded'),
|
||||
{ type: 'provenance_recorded', rowCount: 23 },
|
||||
],
|
||||
});
|
||||
|
||||
expect(view.trustIssues.find((issue) => issue.id === 'provenance-mismatch')).toBeUndefined();
|
||||
});
|
||||
|
||||
it('derives deterministic mode as a degraded trust issue', () => {
|
||||
const view = buildMemoryFlowViewModel({
|
||||
runId: 'demo-deterministic-scan',
|
||||
connectionId: 'orbit_demo',
|
||||
adapter: 'live-database',
|
||||
status: 'done',
|
||||
sourceDir: 'raw-sources/orbit_demo/live-database/sync-demo',
|
||||
syncId: 'sync-demo',
|
||||
reportPath: 'raw-sources/orbit_demo/live-database/sync-demo/scan-report.json',
|
||||
errors: [],
|
||||
plannedWorkUnits: [],
|
||||
details: { actions: [], provenance: [], transcripts: [] },
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'live-database', trigger: 'demo_deterministic', fileCount: 7 },
|
||||
{ type: 'chunks_planned', chunkCount: 7, workUnitCount: 0, evictionCount: 0 },
|
||||
{ type: 'stage_skipped', stage: 'workUnits', reason: 'deterministic mode' },
|
||||
{ type: 'stage_skipped', stage: 'actions', reason: 'requires LLM' },
|
||||
{ type: 'stage_skipped', stage: 'gates', reason: 'requires candidate actions' },
|
||||
{ type: 'stage_skipped', stage: 'saved', reason: 'requires LLM memory synthesis' },
|
||||
],
|
||||
});
|
||||
|
||||
expect(view.trustIssues).toEqual([
|
||||
{
|
||||
id: 'degraded-mode:workUnits',
|
||||
severity: 'warning',
|
||||
title: 'Degraded mode',
|
||||
detail: 'WORKUNITS skipped: deterministic mode',
|
||||
columnId: 'workUnits',
|
||||
targetLabel: 'skipped',
|
||||
},
|
||||
{
|
||||
id: 'degraded-mode:actions',
|
||||
severity: 'warning',
|
||||
title: 'Degraded mode',
|
||||
detail: 'ACTIONS skipped: requires LLM',
|
||||
columnId: 'actions',
|
||||
targetLabel: 'skipped',
|
||||
},
|
||||
{
|
||||
id: 'degraded-mode:gates',
|
||||
severity: 'warning',
|
||||
title: 'Degraded mode',
|
||||
detail: 'GATES skipped: requires candidate actions',
|
||||
columnId: 'gates',
|
||||
targetLabel: 'skipped',
|
||||
},
|
||||
{
|
||||
id: 'degraded-mode:saved',
|
||||
severity: 'warning',
|
||||
title: 'Degraded mode',
|
||||
detail: 'SAVED skipped: requires LLM memory synthesis',
|
||||
columnId: 'saved',
|
||||
targetLabel: 'skipped',
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
it('keeps local planning-only runs honest about unsaved memory', () => {
|
||||
const view = buildMemoryFlowViewModel({
|
||||
runId: 'local-run-1',
|
||||
connectionId: 'warehouse',
|
||||
adapter: 'fake',
|
||||
status: 'done',
|
||||
sourceDir: '/tmp/source',
|
||||
syncId: 'sync-local',
|
||||
errors: [],
|
||||
plannedWorkUnits: [{ unitKey: 'orders', rawFiles: ['orders.json'], peerFileCount: 0, dependencyCount: 0 }],
|
||||
details: { actions: [], provenance: [], transcripts: [] },
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'fake', trigger: 'manual_resync', fileCount: 1 },
|
||||
{ type: 'scope_detected', fingerprint: null },
|
||||
{ type: 'raw_snapshot_written', syncId: 'sync-local', rawFileCount: 1 },
|
||||
{ type: 'diff_computed', added: 1, modified: 0, deleted: 0, unchanged: 0 },
|
||||
{ type: 'chunks_planned', chunkCount: 1, workUnitCount: 1, evictionCount: 0 },
|
||||
{ type: 'report_created', runId: 'local-run-1' },
|
||||
],
|
||||
});
|
||||
|
||||
expect(view.columns.find((column) => column.id === 'actions')?.headline).toBe('0 candidates');
|
||||
expect(view.columns.find((column) => column.id === 'gates')?.headline).toBe('not run');
|
||||
expect(view.columns.find((column) => column.id === 'saved')?.headline).toBe('not saved');
|
||||
expect(view.completionLine).toBe(null);
|
||||
});
|
||||
|
||||
it('surfaces a sanitized source acquisition error when no source event exists', () => {
|
||||
const view = buildMemoryFlowViewModel(
|
||||
baseReplayInput({
|
||||
errors: ['failed to read https://example.com/source?token=abc123 password=hunter2'],
|
||||
}),
|
||||
);
|
||||
|
||||
expect(view.activeLine).toBe('active: source failed - failed to read https://[redacted] password=[redacted]');
|
||||
expect(view.selectedTitle).toBe('SOURCE');
|
||||
expect(view.selectedDetails).toContain('Source acquisition failed: failed to read https://[redacted] password=[redacted]');
|
||||
});
|
||||
|
||||
it('surfaces a sanitized planning error after source acquisition but before chunks', () => {
|
||||
const view = buildMemoryFlowViewModel(
|
||||
baseReplayInput({
|
||||
errors: ['adapter detection failed api_key=abc123'],
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'metricflow', trigger: 'manual_resync', fileCount: 3 },
|
||||
{ type: 'raw_snapshot_written', syncId: 'sync-errors', rawFileCount: 3 },
|
||||
],
|
||||
}),
|
||||
);
|
||||
|
||||
expect(view.activeLine).toBe('active: planning failed - adapter detection failed api_key=[redacted]');
|
||||
const source = view.columns.find((column) => column.id === 'source');
|
||||
expect(source?.details).toContain('Error: adapter detection failed api_key=[redacted]');
|
||||
});
|
||||
|
||||
it('labels failed semantic-layer WorkUnits as reverted in gates details', () => {
|
||||
const view = buildMemoryFlowViewModel(
|
||||
baseReplayInput({
|
||||
status: 'error',
|
||||
errors: ['semantic-layer validation failed for warehouse.orders'],
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'metricflow', trigger: 'manual_resync', fileCount: 2 },
|
||||
{ type: 'raw_snapshot_written', syncId: 'sync-errors', rawFileCount: 2 },
|
||||
{ type: 'diff_computed', added: 2, modified: 0, deleted: 0, unchanged: 0 },
|
||||
{ type: 'chunks_planned', chunkCount: 1, workUnitCount: 1, evictionCount: 0 },
|
||||
{ type: 'work_unit_started', unitKey: 'orders', skills: ['wiki_capture'], stepBudget: 40 },
|
||||
{ type: 'candidate_action', unitKey: 'orders', target: 'sl', action: 'updated', key: 'warehouse.orders' },
|
||||
{
|
||||
type: 'work_unit_finished',
|
||||
unitKey: 'orders',
|
||||
status: 'failed',
|
||||
reason: 'semantic-layer validation failed for warehouse.orders',
|
||||
},
|
||||
],
|
||||
plannedWorkUnits: [{ unitKey: 'orders', rawFiles: ['orders.yml'], peerFileCount: 0, dependencyCount: 0 }],
|
||||
}),
|
||||
);
|
||||
|
||||
const gates = view.columns.find((column) => column.id === 'gates');
|
||||
expect(gates?.details).toContain('orders reverted: semantic-layer validation failed for warehouse.orders');
|
||||
expect(gates?.details).toContain('Invalid semantic-layer writes were not saved.');
|
||||
});
|
||||
|
||||
it('keeps non-validation WorkUnit failures actionable', () => {
|
||||
const view = buildMemoryFlowViewModel(
|
||||
baseReplayInput({
|
||||
status: 'error',
|
||||
errors: ['agent step budget exhausted'],
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'metricflow', trigger: 'manual_resync', fileCount: 1 },
|
||||
{ type: 'chunks_planned', chunkCount: 1, workUnitCount: 1, evictionCount: 0 },
|
||||
{ type: 'work_unit_started', unitKey: 'docs', skills: ['wiki_capture'], stepBudget: 40 },
|
||||
{ type: 'work_unit_finished', unitKey: 'docs', status: 'failed', reason: 'agent step budget exhausted' },
|
||||
],
|
||||
plannedWorkUnits: [{ unitKey: 'docs', rawFiles: ['docs.md'], peerFileCount: 0, dependencyCount: 0 }],
|
||||
}),
|
||||
);
|
||||
|
||||
const gates = view.columns.find((column) => column.id === 'gates');
|
||||
expect(gates?.details).toContain('docs failed: agent step budget exhausted');
|
||||
});
|
||||
|
||||
it('shows whether durable memory landed before a post-save failure', () => {
|
||||
const view = buildMemoryFlowViewModel(
|
||||
baseReplayInput({
|
||||
status: 'error',
|
||||
errors: ['index refresh failed token=abc123'],
|
||||
events: [
|
||||
{ type: 'source_acquired', adapter: 'metricflow', trigger: 'manual_resync', fileCount: 2 },
|
||||
{ type: 'chunks_planned', chunkCount: 1, workUnitCount: 1, evictionCount: 0 },
|
||||
{ type: 'work_unit_finished', unitKey: 'orders', status: 'success' },
|
||||
{ type: 'reconciliation_finished', conflictCount: 0, fallbackCount: 0 },
|
||||
{ type: 'saved', commitSha: 'abc123456789', wikiCount: 1, slCount: 1 }, // pragma: allowlist secret
|
||||
],
|
||||
}),
|
||||
);
|
||||
|
||||
const saved = view.columns.find((column) => column.id === 'saved');
|
||||
expect(saved?.details).toContain('Durable memory landed before failure.');
|
||||
expect(saved?.details).toContain('Post-save error: index refresh failed token=[redacted]');
|
||||
expect(view.activeLine).toBe('active: save failed - index refresh failed token=[redacted]');
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue