apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-07-04 10:52:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

chore(workspace): gate dead-code with knip production mode (#196)

Browse source 
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm

* refactor(workspace): rewrite @ktx/llm imports to relative paths

* refactor(workspace): fold internal packages into cli

* chore(workspace): gate dead-code with knip production mode

Turn on production-mode knip plus an autofix run in pre-commit and the
`pnpm dead-code` script, document the `/** @internal */` convention for
test-only exports in AGENTS.md, annotate test-only exports across the
CLI with that JSDoc, and drop dead exports/wrappers the new gate
surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`,
`createLocalScanEnrichmentProvidersFromConfig`,
`PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports).
Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit
production entries so cross-package barrel leaks are caught.

* refactor(cli): delete internal barrel index.ts files

The 34 `index.ts` re-export barrels inside `packages/cli/src/` were
holdovers from the pre-fold multi-workspace structure. Post-fold-in they
served no production purpose: external consumers go through the single
package main entry, and in-repo callers mostly imported through them
only because the path was short. Internally, knip flagged most barrel
re-exports as production-dead (only reached via tests).

This change:
- Deletes every internal barrel except `packages/cli/src/index.ts`
  (the published package entry).
- Rewrites ~270 source/test files to import each name directly from
  the file that defines it.
- Moves `tools/warehouse-verification/index.ts` to
  `create-warehouse-verification-tools.ts` (the function it defined
  locally) and updates its single consumer.
- Renames `search/backend-conformance.ts` → `.test-utils.ts` to match
  the existing test-helper file convention.
- Deletes 13 dead test-only chains (dbt-descriptions/*,
  live-database/extracted-schema, live-database/structural-sync,
  relationship-* feedback/review chain) plus their tests and a
  cascading orphan integration test.
- Updates test mocks that pointed at deleted barrel paths
  (notion-client, connector barrels in scan/local-scan-connectors
  tests) to mock the source files instead.
- Points the maintainer benchmark script
  (`scripts/relationship-benchmark-report.mjs`) at source files
  instead of `dist/context/scan/index.js`.
- Drops the barrel `!` entries from `knip.json`; adds explicit
  production entries only for the benchmark code reached via dist by
  the maintainer script.

Net: 413 files changed, ~1.2k insertions, ~9.4k deletions.

`pnpm run dead-code` (Biome + knip default + knip production) and
`pnpm run type-check` are clean; 2277 tests pass.

* refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly

Promote the CLI workspace package to the public name `@kaelio/ktx` and
drop the separate `scripts/build-public-npm-package.mjs` wrapper. The
CLI package is now publishable in place (`publishConfig.access: public`,
`provenance: true`), so artifact packing uses `pnpm pack` against
`packages/cli/` instead of assembling a parallel package tree.

Updates all workspace filter invocations, docs, tests, and release
readiness checks to reference the new package name, and folds the
tarball-name helper into `scripts/public-npm-release-metadata.mjs`.

* docs: align "agent clients" and "data agents" terminology

Replace "client agents" with "agent clients" and "database agents" with
"data agents" across AGENTS.md, README.md, the docs-site copy, and the
matching setup-agents test description, matching the canonical
vocabulary in docs/terminology.md.

Also moves packages/cli/tsconfig.json's tsBuildInfoFile from
node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive
node_modules reinstalls.

* refactor(release): single source of truth for package version

Make packages/cli/package.json the single source of truth for the
@kaelio/ktx version. publicNpmPackageVersion() now reads it directly,
so artifact filenames, release-readiness checks, and the Python wheel
version all derive from one field. The duplicate
release-policy.json.publicNpmPackageVersion is removed.

Previously the two fields could drift: tarballs were named
kaelio-ktx-0.4.1.tgz while internally containing
@kaelio/ktx@0.0.0-private.

- update-public-release-version.mjs rewrites both Python pyproject.toml
  files (ktx-daemon, ktx-sl) alongside the npm package.jsons,
  normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2).
- semantic-release-config.cjs adds the two pyproject.toml files to
  @semantic-release/git assets so the release commit back to main
  carries every version source in lockstep.
- The six "?? '0.0.0-private'" fallback literals across the CLI are
  replaced with "?? getKtxCliPackageInfo().version", and
  createDefaultKtxMcpServer makes its version arg required.
- docs/release.md describes the actual commit-back model: the dev tree
  always reflects the most recent release; no sentinel pin to
  maintain.

Verified: pnpm run artifacts:build now produces
kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with
@kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and
2287 vitests + 173 script tests pass.

* refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime

Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and
scan command entrypoints so tests can stub them, and teach
resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime
feature when ktx.yaml selects sentence-transformers.

* chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal

Both symbols are consumed only by status-project.test.ts. Annotating with
/** @internal */ keeps knip's production-mode check clean without changing
runtime behavior.

* fix(cli): use real package metadata in print-command-tree

The stubbed package name embedded a forbidden product identifier that
tripped the boundary check in CI. Read the metadata from package.json
instead — keeps the rendered tree unchanged and removes a duplicate
source of truth.

* feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts

Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer
source counts, computed with `SUM(embedding_json IS NOT NULL)` over
`knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to
"Wiki" (canonical per `docs/terminology.md`) and rename the matching
`localStats.knowledgePages` field to `localStats.wikiPages`.

Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those
duplicated the per-surface rows above. Disk now reports only actual byte
usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` /
`semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry`
helpers, and the `filter` arg on `summarizeDir` are removed.
This commit is contained in:
Andrey Avtomonov 2026-05-21 15:28:58 +02:00 • committed by GitHub
parent a1cfb03d73
commit 2366b00301
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1002 changed files with 2286 additions and 12051 deletions
Download patch file Download diff file Expand all files Collapse all files

326
packages/cli/src/context/ingest/memory-flow/interaction.test.ts Normal file
View file

@ -0,0 +1,326 @@
import { describe, expect, it } from 'vitest';
import {
createInitialMemoryFlowInteractionState,
findMemoryFlowSearchMatches,
reduceMemoryFlowInteractionState,
selectMemoryFlowChip,
selectMemoryFlowColumn,
selectedMemoryFlowColumn,
selectedMemoryFlowDetails,
visibleMemoryFlowChips,
} from './interaction.js';
import type { MemoryFlowInteractionState, MemoryFlowViewModel } from './types.js';
function view(): MemoryFlowViewModel {
return {
title: 'KTX memory flow warehouse/metricflow running',
subtitle: 'Run run-1 Sync sync-1',
status: 'running',
activeLine: 'active: WorkUnit orders step 2/4',
selectedTitle: 'WORKUNITS',
selectedDetails: ['orders: 1 raw, 0 peers, 1 deps'],
completionLine: null,
trustIssues: [
{
id: 'flagged-fallbacks',
severity: 'warning',
title: 'Flagged fallbacks',
detail: '1 fallback needs review',
columnId: 'gates',
},
{
id: 'work-unit-failed:customers',
severity: 'failed',
title: 'WorkUnit failed',
detail: 'customers failed: semantic-layer validation failed',
columnId: 'workUnits',
targetLabel: 'customers',
},
],
details: {
actions: [
{
unitKey: 'orders',
target: 'wiki',
action: 'created',
key: 'wiki/orders.md',
summary: 'order facts',
rawFiles: ['orders.yml'],
status: 'success',
},
],
provenance: [
{
rawPath: 'orders.yml',
artifactKind: 'wiki',
artifactKey: 'wiki/orders.md',
actionType: 'wiki_written',
},
],
transcripts: [
{
unitKey: 'customers',
path: '/tmp/transcripts/customers.jsonl',
toolCallCount: 2,
errorCount: 1,
toolNames: ['read_raw_span', 'sl_write_source'],
},
],
},
columns: [
{
id: 'source',
title: 'SOURCE',
status: 'complete',
headline: '2 raw files',
counters: ['sync sync-1', 'scope none'],
chips: [{ label: 'metricflow', status: 'complete' }],
details: ['Trigger: manual_resync', 'Adapter: metricflow'],
},
{
id: 'chunks',
title: 'CHUNKS',
status: 'complete',
headline: '2 chunks',
counters: ['+1 ~1 -0 =0', '0 deletions'],
chips: [{ label: 'orders', status: 'complete' }],
details: ['Work units planned: 2', 'Eviction candidates: 0'],
},
{
id: 'workUnits',
title: 'WORKUNITS',
status: 'active',
headline: '2 WUs',
counters: ['1 done', '1 failed', '1 active'],
chips: [
{ label: 'orders', status: 'complete', detail: '1 raw span' },
{ label: 'customers', status: 'failed', detail: 'semantic-layer validation failed' },
],
details: ['orders: 1 raw, 0 peers, 1 deps', 'customers: 1 raw, 0 peers, 0 deps'],
},
{
id: 'actions',
title: 'ACTIONS',
status: 'complete',
headline: '2 candidates',
counters: ['1 wiki', '1 SL'],
chips: [{ label: 'wiki/orders.md', status: 'complete' }],
details: ['wiki created: wiki/orders.md', 'sl updated: warehouse.orders'],
},
{
id: 'gates',
title: 'GATES',
status: 'warning',
headline: '0 conflict, 1 fallback',
counters: ['1 failed', '1 flagged'],
chips: [{ label: 'customers', status: 'failed' }],
details: ['Failed work units: 1', 'Flagged fallbacks: 1', 'customers: semantic-layer validation failed'],
},
{
id: 'saved',
title: 'SAVED',
status: 'complete',
headline: '2 memories',
counters: ['1 wiki', '1 SL', '2 provenance'],
chips: [{ label: 'abc12345', status: 'complete' }],
details: ['Commit: abc12345', 'Run: run-1', 'Report: report-1', 'Provenance rows: 2'],
},
],
};
}
describe('memory-flow interaction reducer', () => {
it('selects the active work-unit column by default', () => {
const state = createInitialMemoryFlowInteractionState(view());
expect(state).toEqual({
selectedColumnId: 'workUnits',
selectedChipIndex: 0,
expanded: false,
pane: 'overview',
filter: 'all',
search: { editing: false, query: '', matchIndex: 0 },
shouldQuit: false,
});
expect(selectedMemoryFlowColumn(view(), state).title).toBe('WORKUNITS');
});
it('moves between columns and clamps chip selection', () => {
let state = createInitialMemoryFlowInteractionState(view());
state = reduceMemoryFlowInteractionState(state, 'down', view());
state = reduceMemoryFlowInteractionState(state, 'down', view());
expect(state.selectedChipIndex).toBe(1);
state = reduceMemoryFlowInteractionState(state, 'right', view());
expect(state.selectedColumnId).toBe('actions');
expect(state.selectedChipIndex).toBe(0);
state = reduceMemoryFlowInteractionState(state, 'left', view());
expect(state.selectedColumnId).toBe('workUnits');
expect(state.selectedChipIndex).toBe(0);
});
it('selects a column directly for mouse-driven renderers', () => {
const initial = createInitialMemoryFlowInteractionState(view());
const selected = selectMemoryFlowColumn(view(), initial, 'actions');
expect(selected).toMatchObject({
selectedColumnId: 'actions',
selectedChipIndex: 0,
expanded: true,
shouldQuit: false,
});
expect(selectedMemoryFlowColumn(view(), selected).title).toBe('ACTIONS');
expect(selectedMemoryFlowDetails(view(), selected)).toContain('wiki created: wiki/orders.md');
});
it('selects and clamps a chip directly for mouse-driven renderers', () => {
const initial = createInitialMemoryFlowInteractionState(view());
const selected = selectMemoryFlowChip(view(), initial, 'workUnits', 99);
expect(selected).toMatchObject({
selectedColumnId: 'workUnits',
selectedChipIndex: 1,
expanded: true,
shouldQuit: false,
});
expect(selectedMemoryFlowDetails(view(), selected)).toContain(
'Selected chip: customers (semantic-layer validation failed)',
);
});
it('ignores direct selection of an unknown column', () => {
const initial = createInitialMemoryFlowInteractionState(view());
const selected = selectMemoryFlowColumn(view(), initial, 'missing' as never);
expect(selected).toEqual({ ...initial, shouldQuit: false });
});
it('toggles expansion, attention filtering, all panes, and quit', () => {
let state: MemoryFlowInteractionState = createInitialMemoryFlowInteractionState(view());
state = reduceMemoryFlowInteractionState(state, 'enter', view());
expect(state.expanded).toBe(true);
expect(selectedMemoryFlowDetails(view(), state)).toContain('orders: 1 raw, 0 peers, 1 deps');
state = reduceMemoryFlowInteractionState(state, 'filter', view());
expect(state.filter).toBe('failed_or_flagged');
expect(visibleMemoryFlowChips(selectedMemoryFlowColumn(view(), state), state)).toEqual([
{ label: 'customers', status: 'failed', detail: 'semantic-layer validation failed' },
]);
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('trust');
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('details');
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('log');
expect(selectedMemoryFlowDetails(view(), state)).toContain('WORKUNITS active: 2 WUs');
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('provenance');
expect(selectedMemoryFlowDetails(view(), state)).toContain(
'orders.yml -> wiki:wiki/orders.md (wiki_written)',
);
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('transcript');
expect(selectedMemoryFlowDetails(view(), state)).toContain(
'customers: 2 tool calls, 1 errors, tools read_raw_span, sl_write_source',
);
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('overview');
state = reduceMemoryFlowInteractionState(state, 'provenance', view());
expect(state.pane).toBe('provenance');
expect(selectedMemoryFlowDetails(view(), state)).toContain(
'orders.yml -> wiki:wiki/orders.md (wiki_written)',
);
state = reduceMemoryFlowInteractionState(state, 'transcript', view());
expect(state.pane).toBe('transcript');
expect(selectedMemoryFlowDetails(view(), state)).toContain(
'customers: 2 tool calls, 1 errors, tools read_raw_span, sl_write_source',
);
state = reduceMemoryFlowInteractionState(state, 'quit', view());
expect(state.shouldQuit).toBe(true);
});
it('shows trust issue details and filters chips using issue targets', () => {
let state: MemoryFlowInteractionState = createInitialMemoryFlowInteractionState(view());
state = reduceMemoryFlowInteractionState(state, 'tab', view());
expect(state.pane).toBe('trust');
expect(selectedMemoryFlowDetails(view(), state)).toEqual([
'FAILED WorkUnit failed: customers failed: semantic-layer validation failed',
'WARNING Flagged fallbacks: 1 fallback needs review',
]);
state = reduceMemoryFlowInteractionState(state, 'filter', view());
expect(visibleMemoryFlowChips(selectedMemoryFlowColumn(view(), state), state, view())).toEqual([
{ label: 'customers', status: 'failed', detail: 'semantic-layer validation failed' },
]);
});
it('searches across columns, trust issues, actions, provenance, and transcripts', () => {
const matches = findMemoryFlowSearchMatches(view(), 'customers');
expect(matches.map((match) => match.label)).toEqual([
'WORKUNITS > customers',
'GATES',
'Trust > WorkUnit failed',
'Transcript > customers',
]);
let state = createInitialMemoryFlowInteractionState(view());
state = reduceMemoryFlowInteractionState(state, 'search-start', view());
state = reduceMemoryFlowInteractionState(state, { type: 'search-input', value: 'customers' }, view());
expect(state.search).toEqual({
editing: true,
query: 'customers',
matchIndex: 0,
});
expect(state.selectedColumnId).toBe('workUnits');
expect(state.selectedChipIndex).toBe(1);
state = reduceMemoryFlowInteractionState(state, 'search-submit', view());
expect(state.search.editing).toBe(false);
});
it('cycles search matches forward and backward with wraparound', () => {
let state = createInitialMemoryFlowInteractionState(view());
state = reduceMemoryFlowInteractionState(state, 'search-start', view());
state = reduceMemoryFlowInteractionState(state, { type: 'search-input', value: 'customers' }, view());
expect(state.search).toEqual({ editing: true, query: 'customers', matchIndex: 0 });
expect(state.selectedColumnId).toBe('workUnits');
expect(state.selectedChipIndex).toBe(1);
state = reduceMemoryFlowInteractionState(state, 'search-next', view());
expect(state.search).toEqual({ editing: true, query: 'customers', matchIndex: 1 });
expect(state.selectedColumnId).toBe('gates');
expect(state.selectedChipIndex).toBe(0);
state = reduceMemoryFlowInteractionState(state, 'search-next', view());
expect(state.search).toEqual({ editing: true, query: 'customers', matchIndex: 2 });
expect(state.selectedColumnId).toBe('workUnits');
state = reduceMemoryFlowInteractionState(state, 'search-previous', view());
expect(state.search).toEqual({ editing: true, query: 'customers', matchIndex: 1 });
expect(state.selectedColumnId).toBe('gates');
state = reduceMemoryFlowInteractionState(state, 'search-previous', view());
state = reduceMemoryFlowInteractionState(state, 'search-previous', view());
expect(state.search).toEqual({ editing: true, query: 'customers', matchIndex: 3 });
expect(state.selectedColumnId).toBe('workUnits');
});
});