mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-25 08:48:08 +02:00
chore(workspace): gate dead-code with knip production mode (#196)
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
This commit is contained in:
Andrey Avtomonov
GitHub
parent
a1cfb03d73
commit
2366b00301
1002 changed files with 2286 additions and 12051 deletions
163
packages/cli/src/context/ingest/diff-set.service.test.ts
Normal file
163
packages/cli/src/context/ingest/diff-set.service.test.ts
Normal file
|
|
@ -0,0 +1,163 @@
|
|||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { computeDiffSetFromHashes, DiffSetService } from './diff-set.service.js';
|
||||
|
||||
function makeRepo(latest: Map<string, string>) {
|
||||
return {
|
||||
findLatestHashesForCompletedSyncs: () => Promise.resolve(latest),
|
||||
};
|
||||
}
|
||||
|
||||
describe('DiffSetService', () => {
|
||||
let service: DiffSetService;
|
||||
const provenanceRepo = { findLatestHashesForCompletedSyncs: vi.fn() };
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
service = new DiffSetService(provenanceRepo as any);
|
||||
});
|
||||
|
||||
it('first run — no prior completed run — everything is added', async () => {
|
||||
provenanceRepo.findLatestHashesForCompletedSyncs.mockResolvedValue(new Map());
|
||||
const diff = await service.compute(
|
||||
'c1',
|
||||
'fake',
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h2'],
|
||||
]),
|
||||
);
|
||||
expect(diff.added.sort()).toEqual(['a.yml', 'b.yml']);
|
||||
expect(diff.modified).toEqual([]);
|
||||
expect(diff.deleted).toEqual([]);
|
||||
expect(diff.unchanged).toEqual([]);
|
||||
});
|
||||
|
||||
it('classifies added / modified / deleted / unchanged against the latest-hash baseline', async () => {
|
||||
provenanceRepo.findLatestHashesForCompletedSyncs.mockResolvedValue(
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h_old'],
|
||||
['c.yml', 'hc'],
|
||||
]),
|
||||
);
|
||||
const now = new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h_new'],
|
||||
['d.yml', 'hd'],
|
||||
]);
|
||||
const diff = await service.compute('c1', 'fake', now);
|
||||
expect(diff.unchanged).toEqual(['a.yml']);
|
||||
expect(diff.modified).toEqual(['b.yml']);
|
||||
expect(diff.deleted).toEqual(['c.yml']);
|
||||
expect(diff.added).toEqual(['d.yml']);
|
||||
});
|
||||
|
||||
it('computes a pure diff from current and prior hash maps', () => {
|
||||
const diff = computeDiffSetFromHashes(
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h2-new'],
|
||||
['d.yml', 'h4'],
|
||||
]),
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h2-old'],
|
||||
['c.yml', 'h3'],
|
||||
]),
|
||||
);
|
||||
|
||||
expect(diff).toEqual({
|
||||
added: ['d.yml'],
|
||||
modified: ['b.yml'],
|
||||
deleted: ['c.yml'],
|
||||
unchanged: ['a.yml'],
|
||||
});
|
||||
});
|
||||
|
||||
it('returns sorted arrays for deterministic hashing', async () => {
|
||||
provenanceRepo.findLatestHashesForCompletedSyncs.mockResolvedValue(new Map());
|
||||
const diff = await service.compute(
|
||||
'c1',
|
||||
'fake',
|
||||
new Map([
|
||||
['z.yml', 'hz'],
|
||||
['a.yml', 'ha'],
|
||||
]),
|
||||
);
|
||||
expect(diff.added).toEqual(['a.yml', 'z.yml']);
|
||||
});
|
||||
|
||||
it('with isPathInScope predicate, out-of-scope prior entries are not reported as deleted', async () => {
|
||||
const prior = new Map([
|
||||
['cards/1.json', 'hashA'],
|
||||
['cards/2.json', 'hashB'],
|
||||
['cards/3.json', 'hashC'],
|
||||
]);
|
||||
const current = new Map([
|
||||
['cards/1.json', 'hashA'],
|
||||
['cards/2.json', 'hashB'],
|
||||
]);
|
||||
const inScope = new Set(['cards/1.json', 'cards/2.json']);
|
||||
const svc = new DiffSetService(makeRepo(prior) as any);
|
||||
const diff = await svc.compute('conn', 'metabase', current, (p) => inScope.has(p));
|
||||
expect(diff.deleted).toEqual([]);
|
||||
expect(diff.unchanged).toEqual(['cards/1.json', 'cards/2.json']);
|
||||
});
|
||||
|
||||
it('with isPathInScope predicate, in-scope deletions are still reported', async () => {
|
||||
const prior = new Map([
|
||||
['cards/1.json', 'hashA'],
|
||||
['cards/2.json', 'hashB'],
|
||||
]);
|
||||
const current = new Map([['cards/1.json', 'hashA']]);
|
||||
const inScope = new Set(['cards/1.json', 'cards/2.json']);
|
||||
const svc = new DiffSetService(makeRepo(prior) as any);
|
||||
const diff = await svc.compute('conn', 'metabase', current, (p) => inScope.has(p));
|
||||
expect(diff.deleted).toEqual(['cards/2.json']);
|
||||
});
|
||||
|
||||
it('holds unchanged baseline across multiple incremental re-syncs (regression for skipped-row sync_id drift)', async () => {
|
||||
// After sync 1 wrote (a.yml, h1, sync=S1, skipped) and sync 2 computed a no-op,
|
||||
// sync 3 must still see a.yml as unchanged — the baseline comes from S1, not from
|
||||
// the most recent sync_id alone.
|
||||
provenanceRepo.findLatestHashesForCompletedSyncs.mockResolvedValue(
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h2'],
|
||||
]),
|
||||
);
|
||||
const diff = await service.compute(
|
||||
'c1',
|
||||
'fake',
|
||||
new Map([
|
||||
['a.yml', 'h1'],
|
||||
['b.yml', 'h2'],
|
||||
]),
|
||||
);
|
||||
expect(diff.added).toEqual([]);
|
||||
expect(diff.unchanged).toEqual(['a.yml', 'b.yml']);
|
||||
});
|
||||
});
|
||||
|
||||
describe('DiffSetService — scope-narrowing scenario', () => {
|
||||
it('scope from [1,2,3] → [1,2] leaves no spurious deletions', async () => {
|
||||
const prior = new Map([
|
||||
['cards/1.json', 'hashA'],
|
||||
['cards/2.json', 'hashB'],
|
||||
['cards/3.json', 'hashC'],
|
||||
['sync-config.json', 'hashCfg'],
|
||||
]);
|
||||
const current = new Map([
|
||||
['cards/1.json', 'hashA'],
|
||||
['cards/2.json', 'hashB'],
|
||||
['sync-config.json', 'hashCfg2'],
|
||||
]);
|
||||
const inScope = new Set(['cards/1.json', 'cards/2.json', 'sync-config.json']);
|
||||
const svc = new DiffSetService(makeRepo(prior) as any);
|
||||
const diff = await svc.compute('conn', 'metabase', current, (p) => inScope.has(p));
|
||||
expect(diff.deleted).toEqual([]);
|
||||
expect(diff.modified).toEqual(['sync-config.json']);
|
||||
expect(diff.unchanged).toEqual(['cards/1.json', 'cards/2.json']);
|
||||
expect(diff.added).toEqual([]);
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue