apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-28 08:49:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: classify MCP SQL query errors as expected (#285)

Browse source
This commit is contained in:
Andrey Avtomonov 2026-06-10 11:42:31 +02:00 • committed by GitHub
parent b076431b0a
commit 036a745fc1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 226 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

73
packages/cli/test/context/mcp/local-project-ports.test.ts
View file

@ -3,6 +3,7 @@ import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { initKtxProject } from '../../../src/context/project/project.js';
import { KtxQueryError } from '../../../src/errors.js';
import { createKtxConnectorCapabilities, type KtxQueryResult, type KtxScanConnector, type KtxSchemaSnapshot } from '../../../src/context/scan/types.js';
import { writeLocalSlSource } from '../../../src/context/sl/local-sl.js';
import { createLocalProjectMcpContextPorts } from '../../../src/context/mcp/local-project-ports.js';
@ -325,6 +326,78 @@ describe('createLocalProjectMcpContextPorts', () => {
expect(connector.executeReadOnly).not.toHaveBeenCalled();
});
it('wraps warehouse execution errors as KtxQueryError while preserving the diagnostic message', async () => {
const project = await initKtxProject({ projectDir: tempDir });
project.config.connections.warehouse = {
driver: 'snowflake',
url: 'env:DATABASE_URL',
};
const driverError = new Error("SQL compilation error:\nsyntax error line 4 at position 14 unexpected 'rows'.");
driverError.name = 'OperationFailedError';
const connector: KtxScanConnector = {
...testConnector(testSnapshot(), { headers: [], rows: [], totalRows: 0, rowCount: 0 }),
executeReadOnly: vi.fn(async () => {
throw driverError;
}),
};
const sqlAnalysis = {
analyzeForFingerprint: vi.fn(),
analyzeBatch: vi.fn(),
validateReadOnly: vi.fn(async () => ({ ok: true, error: null })),
};
const ports = createLocalProjectMcpContextPorts(project, {
sqlAnalysis,
localScan: { createConnector: vi.fn(async () => connector) },
embeddingService: null,
});
const execution = ports.sqlExecution?.execute({
connectionId: 'warehouse',
sql: 'select\n count(*)\nfrom events\nlimit 100 rows',
maxRows: 1000,
});
await expect(execution).rejects.toBeInstanceOf(KtxQueryError);
await expect(execution).rejects.toThrow("syntax error line 4 at position 14 unexpected 'rows'.");
await expect(execution).rejects.toMatchObject({ cause: driverError });
expect(connector.cleanup).toHaveBeenCalled();
});
it('lets connector programming faults propagate instead of masking them as query errors', async () => {
const project = await initKtxProject({ projectDir: tempDir });
project.config.connections.warehouse = {
driver: 'snowflake',
url: 'env:DATABASE_URL',
};
const bug = new TypeError("Cannot read properties of undefined (reading 'rows')");
const connector: KtxScanConnector = {
...testConnector(testSnapshot(), { headers: [], rows: [], totalRows: 0, rowCount: 0 }),
executeReadOnly: vi.fn(async () => {
throw bug;
}),
};
const sqlAnalysis = {
analyzeForFingerprint: vi.fn(),
analyzeBatch: vi.fn(),
validateReadOnly: vi.fn(async () => ({ ok: true, error: null })),
};
const ports = createLocalProjectMcpContextPorts(project, {
sqlAnalysis,
localScan: { createConnector: vi.fn(async () => connector) },
embeddingService: null,
});
const execution = ports.sqlExecution?.execute({
connectionId: 'warehouse',
sql: 'select 1',
maxRows: 10,
});
await expect(execution).rejects.toBe(bug);
await expect(execution).rejects.toBeInstanceOf(TypeError);
expect(connector.cleanup).toHaveBeenCalled();
});
it('exposes local scan entity details through MCP ports', async () => {
const project = await initKtxProject({ projectDir: tempDir });
project.config.connections.warehouse = {