chore(workspace): gate dead-code with knip production mode (#196)
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm
* refactor(workspace): rewrite @ktx/llm imports to relative paths
* refactor(workspace): fold internal packages into cli
* chore(workspace): gate dead-code with knip production mode
Turn on production-mode knip plus an autofix run in pre-commit and the
`pnpm dead-code` script, document the `/** @internal */` convention for
test-only exports in AGENTS.md, annotate test-only exports across the
CLI with that JSDoc, and drop dead exports/wrappers the new gate
surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`,
`createLocalScanEnrichmentProvidersFromConfig`,
`PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports).
Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit
production entries so cross-package barrel leaks are caught.
* refactor(cli): delete internal barrel index.ts files
The 34 `index.ts` re-export barrels inside `packages/cli/src/` were
holdovers from the pre-fold multi-workspace structure. Post-fold-in they
served no production purpose: external consumers go through the single
package main entry, and in-repo callers mostly imported through them
only because the path was short. Internally, knip flagged most barrel
re-exports as production-dead (only reached via tests).
This change:
- Deletes every internal barrel except `packages/cli/src/index.ts`
(the published package entry).
- Rewrites ~270 source/test files to import each name directly from
the file that defines it.
- Moves `tools/warehouse-verification/index.ts` to
`create-warehouse-verification-tools.ts` (the function it defined
locally) and updates its single consumer.
- Renames `search/backend-conformance.ts` → `.test-utils.ts` to match
the existing test-helper file convention.
- Deletes 13 dead test-only chains (dbt-descriptions/*,
live-database/extracted-schema, live-database/structural-sync,
relationship-* feedback/review chain) plus their tests and a
cascading orphan integration test.
- Updates test mocks that pointed at deleted barrel paths
(notion-client, connector barrels in scan/local-scan-connectors
tests) to mock the source files instead.
- Points the maintainer benchmark script
(`scripts/relationship-benchmark-report.mjs`) at source files
instead of `dist/context/scan/index.js`.
- Drops the barrel `!` entries from `knip.json`; adds explicit
production entries only for the benchmark code reached via dist by
the maintainer script.
Net: 413 files changed, ~1.2k insertions, ~9.4k deletions.
`pnpm run dead-code` (Biome + knip default + knip production) and
`pnpm run type-check` are clean; 2277 tests pass.
* refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly
Promote the CLI workspace package to the public name `@kaelio/ktx` and
drop the separate `scripts/build-public-npm-package.mjs` wrapper. The
CLI package is now publishable in place (`publishConfig.access: public`,
`provenance: true`), so artifact packing uses `pnpm pack` against
`packages/cli/` instead of assembling a parallel package tree.
Updates all workspace filter invocations, docs, tests, and release
readiness checks to reference the new package name, and folds the
tarball-name helper into `scripts/public-npm-release-metadata.mjs`.
* docs: align "agent clients" and "data agents" terminology
Replace "client agents" with "agent clients" and "database agents" with
"data agents" across AGENTS.md, README.md, the docs-site copy, and the
matching setup-agents test description, matching the canonical
vocabulary in docs/terminology.md.
Also moves packages/cli/tsconfig.json's tsBuildInfoFile from
node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive
node_modules reinstalls.
* refactor(release): single source of truth for package version
Make packages/cli/package.json the single source of truth for the
@kaelio/ktx version. publicNpmPackageVersion() now reads it directly,
so artifact filenames, release-readiness checks, and the Python wheel
version all derive from one field. The duplicate
release-policy.json.publicNpmPackageVersion is removed.
Previously the two fields could drift: tarballs were named
kaelio-ktx-0.4.1.tgz while internally containing
@kaelio/ktx@0.0.0-private.
- update-public-release-version.mjs rewrites both Python pyproject.toml
files (ktx-daemon, ktx-sl) alongside the npm package.jsons,
normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2).
- semantic-release-config.cjs adds the two pyproject.toml files to
@semantic-release/git assets so the release commit back to main
carries every version source in lockstep.
- The six "?? '0.0.0-private'" fallback literals across the CLI are
replaced with "?? getKtxCliPackageInfo().version", and
createDefaultKtxMcpServer makes its version arg required.
- docs/release.md describes the actual commit-back model: the dev tree
always reflects the most recent release; no sentinel pin to
maintain.
Verified: pnpm run artifacts:build now produces
kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with
@kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and
2287 vitests + 173 script tests pass.
* refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime
Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and
scan command entrypoints so tests can stub them, and teach
resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime
feature when ktx.yaml selects sentence-transformers.
* chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal
Both symbols are consumed only by status-project.test.ts. Annotating with
/** @internal */ keeps knip's production-mode check clean without changing
runtime behavior.
* fix(cli): use real package metadata in print-command-tree
The stubbed package name embedded a forbidden product identifier that
tripped the boundary check in CI. Read the metadata from package.json
instead — keeps the rendered tree unchanged and removes a duplicate
source of truth.
* feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts
Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer
source counts, computed with `SUM(embedding_json IS NOT NULL)` over
`knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to
"Wiki" (canonical per `docs/terminology.md`) and rename the matching
`localStats.knowledgePages` field to `localStats.wikiPages`.
Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those
duplicated the per-surface rows above. Disk now reports only actual byte
usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` /
`semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry`
helpers, and the `filter` arg on `summarizeDir` are removed.
2026-05-21 15:28:58 +02:00
import type { KtxSchemaDimensionType , KtxTableRef } from '../../context/scan/types.js' ;
2026-05-10 23:12:26 +02:00
2026-05-10 23:51:24 +02:00
type SqlServerTableNameRef = Pick < KtxTableRef , 'name' > & Partial < Pick < KtxTableRef , 'catalog' | 'db' > > ;
2026-05-10 23:12:26 +02:00
2026-05-10 23:51:24 +02:00
export class KtxSqlServerDialect {
2026-05-10 23:12:26 +02:00
readonly type = 'sqlserver' ;
2026-05-10 23:51:24 +02:00
private readonly typeMappings : Record < string , KtxSchemaDimensionType > = {
2026-05-10 23:12:26 +02:00
datetime : 'time' ,
datetime2 : 'time' ,
date : 'time' ,
time : 'time' ,
datetimeoffset : 'time' ,
smalldatetime : 'time' ,
timestamp : 'time' ,
int : 'number' ,
bigint : 'number' ,
smallint : 'number' ,
tinyint : 'number' ,
decimal : 'number' ,
numeric : 'number' ,
float : 'number' ,
real : 'number' ,
money : 'number' ,
smallmoney : 'number' ,
varchar : 'string' ,
nvarchar : 'string' ,
char : 'string' ,
nchar : 'string' ,
text : 'string' ,
ntext : 'string' ,
uniqueidentifier : 'string' ,
xml : 'string' ,
bit : 'boolean' ,
} ;
quoteIdentifier ( identifier : string ) : string {
return ` [ ${ identifier . replace ( /\]/g , ']]' ) } ] ` ;
}
formatTableName ( table : SqlServerTableNameRef ) : string {
return table . db
? ` ${ this . quoteIdentifier ( table . db ) } . ${ this . quoteIdentifier ( table . name ) } `
: this . quoteIdentifier ( table . name ) ;
}
mapDataType ( nativeType : string ) : string {
return nativeType ;
}
2026-05-10 23:51:24 +02:00
mapToDimensionType ( nativeType : string ) : KtxSchemaDimensionType {
2026-05-10 23:12:26 +02:00
if ( ! nativeType ) {
return 'string' ;
}
const lower = nativeType . toLowerCase ( ) . trim ( ) ;
const normalized = lower . includes ( '(' ) ? lower . split ( '(' ) [ 0 ] ! : lower ;
if ( this . typeMappings [ normalized ] ) {
return this . typeMappings [ normalized ] ;
}
if ( normalized . includes ( 'time' ) || normalized . includes ( 'date' ) ) {
return 'time' ;
}
if (
normalized . includes ( 'int' ) ||
normalized . includes ( 'num' ) ||
normalized . includes ( 'dec' ) ||
normalized . includes ( 'float' ) ||
normalized . includes ( 'money' )
) {
return 'number' ;
}
if ( normalized . includes ( 'bit' ) ) {
return 'boolean' ;
}
return 'string' ;
}
generateSampleQuery ( tableName : string , limit : number , columns? : string [ ] ) : string {
const columnList =
columns && columns . length > 0 ? columns . map ( ( column ) = > this . quoteIdentifier ( column ) ) . join ( ', ' ) : '*' ;
return ` SELECT TOP ${ limit } ${ columnList } FROM ${ tableName } ` ;
}
generateColumnSampleQuery ( tableName : string , columnName : string , limit : number ) : string {
const quotedColumn = this . quoteIdentifier ( columnName ) ;
return ` SELECT TOP ${ limit } ${ quotedColumn } FROM ${ tableName } WHERE ${ quotedColumn } IS NOT NULL AND LTRIM(RTRIM(CAST( ${ quotedColumn } AS NVARCHAR(MAX)))) != '' ` ;
}
prepareQuery ( sql : string , params? : Record < string , unknown > ) : { sql : string ; params? : Record < string , unknown > } {
if ( ! params ) {
return { sql , params : undefined } ;
}
let parameterizedQuery = sql ;
for ( const key of Object . keys ( params ) ) {
parameterizedQuery = parameterizedQuery . replace ( new RegExp ( ` : ${ key } \\ b ` , 'g' ) , ` @ ${ key } ` ) ;
}
return { sql : parameterizedQuery , params } ;
}
getRandomSampleFilter ( samplePct : number ) : string {
if ( samplePct <= 0 || samplePct >= 1 ) {
return '' ;
}
return ` ABS(CHECKSUM(NEWID())) % 100 < ${ Math . round ( samplePct * 100 ) } ` ;
}
getTableSampleClause ( samplePct : number ) : string {
if ( samplePct <= 0 || samplePct >= 1 ) {
return '' ;
}
return ` TABLESAMPLE ( ${ samplePct * 100 } PERCENT) ` ;
}
getLimitOffsetClause ( limit : number , offset? : number ) : string {
return offset !== undefined && offset > 0 ? ` OFFSET ${ offset } ROWS FETCH NEXT ${ limit } ROWS ONLY ` : '' ;
}
getTopClause ( limit : number ) : string {
return ` TOP ${ limit } ` ;
}
getNullCountExpression ( column : string ) : string {
return ` SUM(CASE WHEN ${ column } IS NULL THEN 1 ELSE 0 END) ` ;
}
getDistinctCountExpression ( column : string ) : string {
return ` COUNT(DISTINCT ${ column } ) ` ;
}
generateCardinalitySampleQuery ( tableName : string , columnName : string , sampleSize : number ) : string {
return `
WITH sampled AS (
SELECT TOP $ { sampleSize } $ { columnName } AS val
FROM $ { tableName }
WHERE $ { columnName } IS NOT NULL
)
SELECT COUNT ( DISTINCT val ) AS cardinality
FROM sampled
` ;
}
generateDistinctValuesQuery ( tableName : string , columnName : string , limit : number ) : string {
return `
SELECT TOP $ { limit } val
FROM (
SELECT DISTINCT CAST ( $ { columnName } AS NVARCHAR ( MAX ) ) AS val
FROM $ { tableName }
WHERE $ { columnName } IS NOT NULL
) AS distinct_vals
ORDER BY val
` ;
}
generateColumnStatisticsQuery ( _schemaName : string , _tableName : string ) : string | null {
return null ;
}
generateRandomizedCardinalitySampleQuery ( tableName : string , columnName : string , sampleSize : number ) : string {
return `
WITH sampled AS (
SELECT TOP $ { sampleSize } $ { columnName } AS val
FROM $ { tableName }
WHERE $ { columnName } IS NOT NULL
ORDER BY NEWID ( )
)
SELECT COUNT ( DISTINCT val ) AS cardinality
FROM sampled
` ;
}
getTimeTruncExpression (
column : string ,
granularity : 'day' | 'week' | 'month' | 'quarter' | 'year' ,
timezone? : string ,
) : string {
const col = timezone ? ` ${ column } AT TIME ZONE 'UTC' AT TIME ZONE ' ${ timezone } ' ` : column ;
switch ( granularity ) {
case 'day' :
return ` CAST( ${ col } AS DATE) ` ;
case 'week' :
return ` DATEADD(WEEK, DATEDIFF(WEEK, 0, ${ col } ), 0) ` ;
case 'month' :
return ` DATEFROMPARTS(YEAR( ${ col } ), MONTH( ${ col } ), 1) ` ;
case 'quarter' :
return ` DATEFROMPARTS(YEAR( ${ col } ), (DATEPART(QUARTER, ${ col } ) - 1) * 3 + 1, 1) ` ;
case 'year' :
return ` DATEFROMPARTS(YEAR( ${ col } ), 1, 1) ` ;
}
}
getCustomTimeTruncExpression ( column : string , interval : string , origin? : string , timezone? : string ) : string {
const col = timezone ? ` ${ column } AT TIME ZONE 'UTC' AT TIME ZONE ' ${ timezone } ' ` : column ;
const [ amount , unit ] = interval . split ( ' ' ) ;
const originExpr = origin ? ` ' ${ origin } ' ` : ` '1970-01-01' ` ;
return ` DATEADD( ${ unit } , (DATEDIFF( ${ unit } , ${ originExpr } , ${ col } ) / ${ amount } ) * ${ amount } , ${ originExpr } ) ` ;
}
parseIntervalToSql ( interval : string ) : string {
return ` ' ${ interval } ' ` ;
}
}