ktx/packages/cli/src/setup-embeddings.test.ts

382 lines
13 KiB
TypeScript
Raw Normal View History

2026-05-10 23:12:26 +02:00
import { mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { initKloProject, parseKloProjectConfig } from '@klo/context/project';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { type KloSetupEmbeddingsPromptAdapter, runKloSetupEmbeddingsStep } from './setup-embeddings.js';
const EMBEDDING_OPTION_PROMPT_MESSAGE = [
'Which embedding option should KLO use?',
'',
'KLO uses embeddings for semantic search over semantic-layer sources, wiki context, schema metadata, ' +
'and relationship evidence.',
].join('\n');
function makeIo() {
let stdout = '';
let stderr = '';
return {
io: {
stdout: {
isTTY: true,
write: (chunk: string) => {
stdout += chunk;
},
},
stderr: {
write: (chunk: string) => {
stderr += chunk;
},
},
},
stdout: () => stdout,
stderr: () => stderr,
};
}
function makePromptAdapter(options: {
selectValues?: string[];
passwordValue?: string;
}): KloSetupEmbeddingsPromptAdapter {
const selectValues = [...(options.selectValues ?? [])];
return {
select: vi.fn(async () => selectValues.shift() ?? 'retry'),
password: vi.fn(async () => options.passwordValue ?? 'embedding-secret'),
cancel: vi.fn(),
};
}
describe('setup embeddings step', () => {
let tempDir: string;
beforeEach(async () => {
tempDir = await mkdtemp(join(tmpdir(), 'klo-setup-embeddings-'));
await initKloProject({ projectDir: tempDir, projectName: 'warehouse' });
});
afterEach(async () => {
await rm(tempDir, { recursive: true, force: true });
});
it('explains why interactive users choose an embedding option before validating embeddings', async () => {
const io = makeIo();
const healthCheck = vi.fn(async () => ({ ok: true as const }));
const prompts = makePromptAdapter({ selectValues: ['back'] });
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'auto',
skipEmbeddings: false,
},
io.io,
{ prompts, env: {}, healthCheck },
);
expect(result.status).toBe('back');
expect(healthCheck).not.toHaveBeenCalled();
expect(prompts.select).toHaveBeenCalledWith({
message: EMBEDDING_OPTION_PROMPT_MESSAGE,
options: [
{ value: 'sentence-transformers', label: 'Local sentence-transformers embeddings' },
{ value: 'openai', label: 'OpenAI embeddings (recommended)' },
{ value: 'back', label: 'Back' },
],
});
});
it('returns from the OpenAI credential prompt to embedding option selection when Back is selected', async () => {
const io = makeIo();
const healthCheck = vi.fn(async () => ({ ok: true as const }));
const prompts = makePromptAdapter({ selectValues: ['openai', 'back', 'sentence-transformers'] });
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'auto',
skipEmbeddings: false,
},
io.io,
{ prompts, env: {}, healthCheck },
);
expect(result.status).toBe('ready');
expect(healthCheck).toHaveBeenCalledTimes(1);
expect(healthCheck).toHaveBeenCalledWith({
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { baseURL: 'http://127.0.0.1:8765', pathPrefix: '' },
});
expect(vi.mocked(prompts.select).mock.calls.map((call) => call[0].message)).toEqual([
EMBEDDING_OPTION_PROMPT_MESSAGE,
'How should KLO find your OpenAI embedding API key?',
EMBEDDING_OPTION_PROMPT_MESSAGE,
]);
});
it('configures local sentence-transformers embeddings after interactive selection', async () => {
const io = makeIo();
const healthCheck = vi.fn(async () => ({ ok: true as const }));
const prompts = makePromptAdapter({ selectValues: ['sentence-transformers'] });
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'auto',
skipEmbeddings: false,
},
io.io,
{ prompts, env: {}, healthCheck },
);
expect(result.status).toBe('ready');
expect(healthCheck).toHaveBeenCalledWith({
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { baseURL: 'http://127.0.0.1:8765', pathPrefix: '' },
});
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.ingest.embeddings).toMatchObject({
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { base_url: 'http://127.0.0.1:8765', pathPrefix: '' },
});
expect(config.scan.enrichment.embeddings).toMatchObject(config.ingest.embeddings);
expect(config.setup?.completed_steps).toContain('embeddings');
expect(io.stdout()).toContain(
'Testing local sentence-transformers embeddings (all-MiniLM-L6-v2, 384 dimensions). First run may take up to 60 seconds.',
);
expect(io.stdout()).toContain('Embeddings ready: yes');
});
it('shows live progress while local sentence-transformers embeddings are being tested', async () => {
const io = makeIo();
const prompts = makePromptAdapter({ selectValues: ['sentence-transformers'] });
let resolveHealthCheck: ((result: { ok: true }) => void) | undefined;
const healthCheck = vi.fn(
() =>
new Promise<{ ok: true }>((resolve) => {
resolveHealthCheck = resolve;
}),
);
const result = runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'auto',
skipEmbeddings: false,
},
io.io,
{ prompts, env: {}, healthCheck },
);
await vi.waitFor(() => {
expect(io.stdout()).toContain(
'\r- Testing local sentence-transformers embeddings (all-MiniLM-L6-v2, 384 dimensions). First run may take up to 60 seconds.',
);
});
expect(resolveHealthCheck).toBeDefined();
resolveHealthCheck?.({ ok: true });
await expect(result).resolves.toMatchObject({ status: 'ready' });
});
it('uses default local sentence-transformers embeddings in non-interactive setup', async () => {
const io = makeIo();
const healthCheck = vi.fn(async () => ({ ok: true as const }));
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'disabled',
skipEmbeddings: false,
},
io.io,
{ env: {}, healthCheck },
);
expect(result.status).toBe('ready');
expect(healthCheck).toHaveBeenCalledWith({
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { baseURL: 'http://127.0.0.1:8765', pathPrefix: '' },
});
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.ingest.embeddings).toMatchObject({
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { base_url: 'http://127.0.0.1:8765', pathPrefix: '' },
});
expect(config.scan.enrichment.embeddings).toMatchObject(config.ingest.embeddings);
expect(config.setup?.completed_steps).toContain('embeddings');
});
it('does not persist embedding completion when the health check fails', async () => {
const io = makeIo();
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'disabled',
skipEmbeddings: false,
},
io.io,
{
env: {},
healthCheck: vi.fn(async () => ({ ok: false as const, message: '401 invalid api key [redacted]' })),
},
);
expect(result.status).toBe('failed');
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.setup?.completed_steps ?? []).not.toContain('embeddings');
expect(config.ingest.embeddings.backend).toBe('deterministic');
expect(io.stderr()).toContain('Local embedding health check failed: 401 invalid api key [redacted]');
expect(io.stderr()).toContain('klo-daemon serve-http --host 127.0.0.1 --port 8765');
expect(io.stderr()).not.toContain('skip for now');
});
it('uses fixed OpenAI defaults and only asks for credentials when OpenAI is selected', async () => {
const io = makeIo();
const healthCheck = vi.fn(async () => ({ ok: true as const }));
const result = await runKloSetupEmbeddingsStep(
{
projectDir: tempDir,
inputMode: 'disabled',
embeddingBackend: 'openai',
embeddingApiKeyEnv: 'OPENAI_API_KEY',
skipEmbeddings: false,
},
io.io,
{
env: { OPENAI_API_KEY: 'sk-openai-test' },
healthCheck,
},
);
expect(result.status).toBe('ready');
expect(healthCheck).toHaveBeenCalledWith({
backend: 'openai',
model: 'text-embedding-3-small',
dimensions: 1536,
openai: { apiKey: 'sk-openai-test' },
});
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.ingest.embeddings).toMatchObject({
backend: 'openai',
model: 'text-embedding-3-small',
dimensions: 1536,
openai: { api_key: 'env:OPENAI_API_KEY' },
});
expect(io.stdout()).not.toContain('sk-openai-test');
});
it('can fall back to OpenAI after the default local daemon is unavailable', async () => {
const io = makeIo();
const prompts = makePromptAdapter({ selectValues: ['sentence-transformers', 'openai', 'env'] });
const healthCheck = vi
.fn()
.mockResolvedValueOnce({ ok: false as const, message: 'fetch failed' })
.mockResolvedValueOnce({ ok: true as const });
const result = await runKloSetupEmbeddingsStep(
{ projectDir: tempDir, inputMode: 'auto', skipEmbeddings: false },
io.io,
{ prompts, env: { OPENAI_API_KEY: 'sk-openai-test' }, healthCheck },
);
expect(result.status).toBe('ready');
expect(healthCheck).toHaveBeenNthCalledWith(1, {
backend: 'sentence-transformers',
model: 'all-MiniLM-L6-v2',
dimensions: 384,
sentenceTransformers: { baseURL: 'http://127.0.0.1:8765', pathPrefix: '' },
});
expect(healthCheck).toHaveBeenNthCalledWith(2, {
backend: 'openai',
model: 'text-embedding-3-small',
dimensions: 1536,
openai: { apiKey: 'sk-openai-test' },
});
expect(prompts.select).toHaveBeenCalledWith(
expect.objectContaining({
message: 'Local embeddings are not reachable. Start the local KLO daemon, then retry.',
options: expect.arrayContaining([expect.objectContaining({ value: 'openai' })]),
}),
);
expect(vi.mocked(prompts.select).mock.calls[1]?.[0].options).toEqual([
{ value: 'retry', label: 'Retry' },
{ value: 'openai', label: 'Use OpenAI embeddings' },
{ value: 'back', label: 'Back' },
]);
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.ingest.embeddings.backend).toBe('openai');
});
it('leaves setup incomplete when skipped', async () => {
const result = await runKloSetupEmbeddingsStep(
{ projectDir: tempDir, inputMode: 'disabled', skipEmbeddings: true },
makeIo().io,
);
expect(result.status).toBe('skipped');
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.setup?.completed_steps ?? []).not.toContain('embeddings');
expect(config.ingest.embeddings.backend).toBe('deterministic');
});
it('returns back without writing config when the local health check fails and Back is selected', async () => {
const prompts = makePromptAdapter({ selectValues: ['sentence-transformers', 'back'] });
const result = await runKloSetupEmbeddingsStep(
{ projectDir: tempDir, inputMode: 'auto', skipEmbeddings: false },
makeIo().io,
{ prompts, env: {}, healthCheck: vi.fn(async () => ({ ok: false as const, message: 'daemon unavailable' })) },
);
expect(result.status).toBe('back');
const config = parseKloProjectConfig(await readFile(join(tempDir, 'klo.yaml'), 'utf-8'));
expect(config.ingest.embeddings.backend).toBe('deterministic');
});
it('preserves already completed embeddings setup when no embedding args request changes', async () => {
await mkdir(join(tempDir, '.klo'), { recursive: true });
await initKloProject({ projectDir: tempDir, projectName: 'warehouse', force: true });
await writeFile(
join(tempDir, 'klo.yaml'),
[
'project: warehouse',
'setup:',
' database_connection_ids: []',
' completed_steps:',
' - project',
' - llm',
' - embeddings',
'connections: {}',
'ingest:',
' embeddings:',
' backend: sentence-transformers',
' model: all-MiniLM-L6-v2',
' dimensions: 384',
' sentenceTransformers:',
' base_url: http://127.0.0.1:8765',
" pathPrefix: ''",
].join('\n'),
'utf-8',
);
const healthCheck = vi.fn(async () => ({ ok: true as const }));
await expect(
runKloSetupEmbeddingsStep({ projectDir: tempDir, inputMode: 'disabled', skipEmbeddings: false }, makeIo().io, {
env: { OPENAI_API_KEY: 'sk-openai-test' },
healthCheck,
}),
).resolves.toMatchObject({ status: 'ready' });
expect(healthCheck).not.toHaveBeenCalled();
});
});