ktx/packages/cli/test/context/search/backend-conformance.test-utils.ts

152 lines
5.2 KiB
TypeScript
Raw Permalink Normal View History

test: split cli tests from source tree (#216) * feat(cli): define full warehouse dialect contract * test(cli): keep dialect edge tests focused * fix(cli): stabilize dialect contract foundation * refactor(connectors): own read-only query preparation * refactor(connectors): resolve dialects through registry * refactor(connectors): keep concrete dialect classes internal * chore(workspace): enforce dialect import boundary * refactor(cli): resolve relationship dialect at scan boundary * refactor(cli): use dialect display parsing for entity details * refactor(cli): use dialect display parsing for warehouse catalog * refactor(cli): use dialect SQL in relationship workflows * test(cli): verify solid dialect scan workflow closure * test: split cli tests from source tree * refactor(cli): standardize BigQuery scope listing * feat(sqlite): implement connector scope listing * test(connectors): cover required table listing * feat(cli): add warehouse driver registry * refactor(setup): route scope discovery through driver registry * refactor(cli): route local query execution through driver registry * refactor(historic-sql): route dialect support through driver registry * refactor(cli): test warehouse connections through driver registry * fix(cli): close driver registry type export gaps * Improve setup daemon diagnostics * refactor(setup): centralize rail-prefixed diagnostics + query-history fallback Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput into clack.ts so the setup wizard, managed daemons, and embedding/agent steps share one rail-formatted writer. setup-databases.ts also adds a "disable query history and retry" option when the schema-context build fails and query history is the likely culprit, surfaced via a new failed-query-history-unavailable status. * fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match The setup picker's KtxTableListEntry was a 2-level { schema, name }, so qualifiedTableId always wrote db.name into enabled_tables. When BigQuery, Snowflake, or SQL Server later ran fast ingest, their introspect step filtered the scope set with scopedTableNames(scope, { catalog: projectId|database, db }) — catalog was non-null on the introspect side but null in the scope refs, so every entry was rejected, the live-database adapter staged zero table files, and detect() failed with 'Adapter "live-database" did not recognize fetched source output'. Align the picker boundary with the canonical 3-level KtxTableRef: - Add catalog: string | null to KtxTableListEntry. - BigQuery/Snowflake/SQL Server listTables populate catalog from the resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null. - qualifiedTableId emits catalog.schema.name when catalog is non-null (resolveEnabledTables already accepts the 3-part shape) and schemasFromEnabledTables now goes through parseDottedTableEntry so it recovers the schema correctly from both 2-part and 3-part entries. - Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker reuse. Update listTables expectations in all seven connector tests and the setup / picker test fixtures. Add a picker regression test that covers the catalog-bearing round-trip (save + refine). * fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00
import type { SearchBackendCapabilities, SearchLaneStatus } from '../../../src/context/search/types.js';
2026-05-10 23:12:26 +02:00
export interface SearchBackendConformanceLane {
lane: string;
status: SearchLaneStatus;
reason?: string;
}
export interface SearchBackendConformanceDictionaryMatch {
column: string;
values: readonly string[];
overflowCount?: number;
}
export interface SearchBackendConformanceResult {
id: string;
score: number;
matchReasons: readonly string[];
lanes?: readonly SearchBackendConformanceLane[];
dictionaryMatches?: readonly SearchBackendConformanceDictionaryMatch[];
}
export interface ExpectedSearchBackendConformanceLane {
status: SearchLaneStatus;
reason?: string;
}
export interface AssertSearchBackendConformanceCaseInput {
backendName: string;
surface: string;
caseName: string;
results: readonly SearchBackendConformanceResult[];
expectedTopIds: readonly string[];
expectedReasonsById?: Record<string, readonly string[]>;
expectedLanes?: Record<string, ExpectedSearchBackendConformanceLane>;
expectedDictionaryMatchesById?: Record<string, readonly SearchBackendConformanceDictionaryMatch[]>;
}
export interface AssertSearchBackendCapabilitiesInput {
backendName: string;
capabilities: SearchBackendCapabilities;
expected: Partial<SearchBackendCapabilities>;
}
function caseLabel(
input: Pick<AssertSearchBackendConformanceCaseInput, 'backendName' | 'surface' | 'caseName'>,
): string {
return `${input.backendName} ${input.surface} conformance case "${input.caseName}"`;
}
function fail(label: string, failures: string[]): never {
throw new Error([`${label} failed:`, ...failures.map((failure) => `- ${failure}`)].join('\n'));
}
function dictionaryMatchKey(match: SearchBackendConformanceDictionaryMatch): string {
const values = [...match.values].sort((left, right) => left.localeCompare(right)).join(',');
return `${match.column}:${values}:${match.overflowCount ?? 0}`;
}
function dictionaryMatchKeys(matches: readonly SearchBackendConformanceDictionaryMatch[] | undefined): string[] {
return (matches ?? []).map(dictionaryMatchKey).sort((left, right) => left.localeCompare(right));
}
export function assertSearchBackendConformanceCase(input: AssertSearchBackendConformanceCaseInput): void {
const label = caseLabel(input);
const failures: string[] = [];
const topResults = input.results.slice(0, input.expectedTopIds.length);
input.expectedTopIds.forEach((expectedId, index) => {
const actualId = topResults[index]?.id;
if (actualId !== expectedId) {
failures.push(`expected result ${index + 1} to be ${expectedId}, got ${actualId ?? '<missing>'}`);
}
});
const byId = new Map(input.results.map((result) => [result.id, result]));
for (const expectedId of input.expectedTopIds) {
const result = byId.get(expectedId);
if (!result) {
continue;
}
if (!Number.isFinite(result.score) || result.score <= 0) {
failures.push(`expected ${expectedId} to have a positive finite score, got ${result.score}`);
}
}
for (const [id, expectedReasons] of Object.entries(input.expectedReasonsById ?? {})) {
const result = byId.get(id);
if (!result) {
failures.push(`expected reasons for ${id}, but the result was missing`);
continue;
}
for (const reason of expectedReasons) {
if (!result.matchReasons.includes(reason)) {
failures.push(`expected ${id} to include match reason ${reason}, got [${result.matchReasons.join(', ')}]`);
}
}
}
const allLanes = input.results.flatMap((result) => result.lanes ?? []);
for (const [lane, expected] of Object.entries(input.expectedLanes ?? {})) {
const actual = allLanes.find((entry) => entry.lane === lane);
if (!actual) {
failures.push(`expected lane ${lane} to be reported`);
continue;
}
if (actual.status !== expected.status) {
failures.push(`expected lane ${lane} status ${expected.status}, got ${actual.status}`);
}
if (expected.reason !== undefined && actual.reason !== expected.reason) {
failures.push(`expected lane ${lane} reason ${expected.reason}, got ${actual.reason ?? '<missing>'}`);
}
}
for (const [id, expectedMatches] of Object.entries(input.expectedDictionaryMatchesById ?? {})) {
const result = byId.get(id);
if (!result) {
failures.push(`expected dictionary matches for ${id}, but the result was missing`);
continue;
}
const actualKeys = dictionaryMatchKeys(result.dictionaryMatches);
for (const expectedKey of dictionaryMatchKeys(expectedMatches)) {
if (!actualKeys.includes(expectedKey)) {
failures.push(`expected ${id} dictionary evidence ${expectedKey}, got [${actualKeys.join(', ')}]`);
}
}
}
if (failures.length > 0) {
fail(label, failures);
}
}
export function assertSearchBackendCapabilities(input: AssertSearchBackendCapabilitiesInput): void {
const failures: string[] = [];
for (const [capability, expected] of Object.entries(input.expected) as Array<
[keyof SearchBackendCapabilities, boolean]
>) {
const actual = input.capabilities[capability];
if (actual !== expected) {
failures.push(`expected ${capability}=${expected}, got ${actual}`);
}
}
if (failures.length > 0) {
fail(`${input.backendName} search backend capabilities`, failures);
}
}