ktx/packages/cli/test/context/ingest/adapters/notion/notion-client.test.ts

66 lines
2.6 KiB
TypeScript
Raw Permalink Normal View History

2026-05-10 23:12:26 +02:00
import { describe, expect, it, vi } from 'vitest';
test: split cli tests from source tree (#216) * feat(cli): define full warehouse dialect contract * test(cli): keep dialect edge tests focused * fix(cli): stabilize dialect contract foundation * refactor(connectors): own read-only query preparation * refactor(connectors): resolve dialects through registry * refactor(connectors): keep concrete dialect classes internal * chore(workspace): enforce dialect import boundary * refactor(cli): resolve relationship dialect at scan boundary * refactor(cli): use dialect display parsing for entity details * refactor(cli): use dialect display parsing for warehouse catalog * refactor(cli): use dialect SQL in relationship workflows * test(cli): verify solid dialect scan workflow closure * test: split cli tests from source tree * refactor(cli): standardize BigQuery scope listing * feat(sqlite): implement connector scope listing * test(connectors): cover required table listing * feat(cli): add warehouse driver registry * refactor(setup): route scope discovery through driver registry * refactor(cli): route local query execution through driver registry * refactor(historic-sql): route dialect support through driver registry * refactor(cli): test warehouse connections through driver registry * fix(cli): close driver registry type export gaps * Improve setup daemon diagnostics * refactor(setup): centralize rail-prefixed diagnostics + query-history fallback Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput into clack.ts so the setup wizard, managed daemons, and embedding/agent steps share one rail-formatted writer. setup-databases.ts also adds a "disable query history and retry" option when the schema-context build fails and query history is the likely culprit, surfaced via a new failed-query-history-unavailable status. * fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match The setup picker's KtxTableListEntry was a 2-level { schema, name }, so qualifiedTableId always wrote db.name into enabled_tables. When BigQuery, Snowflake, or SQL Server later ran fast ingest, their introspect step filtered the scope set with scopedTableNames(scope, { catalog: projectId|database, db }) — catalog was non-null on the introspect side but null in the scope refs, so every entry was rejected, the live-database adapter staged zero table files, and detect() failed with 'Adapter "live-database" did not recognize fetched source output'. Align the picker boundary with the canonical 3-level KtxTableRef: - Add catalog: string | null to KtxTableListEntry. - BigQuery/Snowflake/SQL Server listTables populate catalog from the resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null. - qualifiedTableId emits catalog.schema.name when catalog is non-null (resolveEnabledTables already accepts the 3-part shape) and schemasFromEnabledTables now goes through parseDottedTableEntry so it recovers the schema correctly from both 2-part and 3-part entries. - Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker reuse. Update listTables expectations in all seven connector tests and the setup / picker test fixtures. Add a picker regression test that covers the catalog-bearing round-trip (save + refine). * fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00
import { retryNotionRequest } from '../../../../../src/context/ingest/adapters/notion/notion-client.js';
2026-05-10 23:12:26 +02:00
describe('Notion client retry helper', () => {
it('retries rate-limited requests and then returns the response', async () => {
const sleep = vi.fn().mockResolvedValue(undefined);
const operation = vi
.fn()
.mockRejectedValueOnce({ code: 'rate_limited', headers: { 'retry-after': '2' } })
.mockResolvedValueOnce({ ok: true });
const result = await retryNotionRequest(operation, { sleep, maxAttempts: 2 });
expect(result).toEqual({ ok: true });
expect(sleep).toHaveBeenCalledWith(2000);
});
it('caps retry-after sleep from rate-limit responses', async () => {
const sleep = vi.fn().mockResolvedValue(undefined);
const operation = vi
.fn()
.mockRejectedValueOnce({ code: 'rate_limited', headers: { 'retry-after': '3600' } })
.mockResolvedValueOnce({ ok: true });
await retryNotionRequest(operation, { sleep, maxAttempts: 2 });
expect(sleep).toHaveBeenCalledWith(60_000);
});
it('retries transient 5xx requests and then returns the response', async () => {
const sleep = vi.fn().mockResolvedValue(undefined);
const operation = vi
.fn()
.mockRejectedValueOnce({ code: 'service_unavailable', status: 503, message: 'temporary outage' })
.mockResolvedValueOnce({ ok: true });
const result = await retryNotionRequest(operation, { sleep, maxAttempts: 2 });
expect(result).toEqual({ ok: true });
expect(sleep).toHaveBeenCalledWith(1000);
});
it('uses exponential backoff for transient 5xx retries', async () => {
const sleep = vi.fn().mockResolvedValue(undefined);
const operation = vi
.fn()
.mockRejectedValueOnce({ code: 'service_unavailable', status: 503, message: 'temporary outage' })
.mockRejectedValueOnce({ code: 'service_unavailable', status: 503, message: 'temporary outage' })
.mockResolvedValueOnce({ ok: true });
await retryNotionRequest(operation, { sleep, maxAttempts: 3 });
expect(sleep).toHaveBeenNthCalledWith(1, 1000);
expect(sleep).toHaveBeenNthCalledWith(2, 2000);
});
it('throws the sanitized error after attempts are exhausted', async () => {
const sleep = vi.fn().mockResolvedValue(undefined);
const operation = vi.fn().mockRejectedValue({ code: 'rate_limited', message: 'token secret leaked' });
await expect(retryNotionRequest(operation, { sleep, maxAttempts: 2, authToken: 'secret' })).rejects.toThrow(
/token \*\*\* leaked/,
);
});
});