ktx/packages/cli/test/context/ingest/adapters/lookml/graph.test.ts

119 lines
5.9 KiB
TypeScript
Raw Permalink Normal View History

2026-05-10 23:12:26 +02:00
import { describe, expect, it } from 'vitest';
test: split cli tests from source tree (#216) * feat(cli): define full warehouse dialect contract * test(cli): keep dialect edge tests focused * fix(cli): stabilize dialect contract foundation * refactor(connectors): own read-only query preparation * refactor(connectors): resolve dialects through registry * refactor(connectors): keep concrete dialect classes internal * chore(workspace): enforce dialect import boundary * refactor(cli): resolve relationship dialect at scan boundary * refactor(cli): use dialect display parsing for entity details * refactor(cli): use dialect display parsing for warehouse catalog * refactor(cli): use dialect SQL in relationship workflows * test(cli): verify solid dialect scan workflow closure * test: split cli tests from source tree * refactor(cli): standardize BigQuery scope listing * feat(sqlite): implement connector scope listing * test(connectors): cover required table listing * feat(cli): add warehouse driver registry * refactor(setup): route scope discovery through driver registry * refactor(cli): route local query execution through driver registry * refactor(historic-sql): route dialect support through driver registry * refactor(cli): test warehouse connections through driver registry * fix(cli): close driver registry type export gaps * Improve setup daemon diagnostics * refactor(setup): centralize rail-prefixed diagnostics + query-history fallback Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput into clack.ts so the setup wizard, managed daemons, and embedding/agent steps share one rail-formatted writer. setup-databases.ts also adds a "disable query history and retry" option when the schema-context build fails and query history is the likely culprit, surfaced via a new failed-query-history-unavailable status. * fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match The setup picker's KtxTableListEntry was a 2-level { schema, name }, so qualifiedTableId always wrote db.name into enabled_tables. When BigQuery, Snowflake, or SQL Server later ran fast ingest, their introspect step filtered the scope set with scopedTableNames(scope, { catalog: projectId|database, db }) — catalog was non-null on the introspect side but null in the scope refs, so every entry was rejected, the live-database adapter staged zero table files, and detect() failed with 'Adapter "live-database" did not recognize fetched source output'. Align the picker boundary with the canonical 3-level KtxTableRef: - Add catalog: string | null to KtxTableListEntry. - BigQuery/Snowflake/SQL Server listTables populate catalog from the resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null. - qualifiedTableId emits catalog.schema.name when catalog is non-null (resolveEnabledTables already accepts the 3-part shape) and schemasFromEnabledTables now goes through parseDottedTableEntry so it recovers the schema correctly from both 2-part and 3-part entries. - Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker reuse. Update listTables expectations in all seven connector tests and the setup / picker test fixtures. Add a picker regression test that covers the catalog-bearing round-trip (save + refine). * fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00
import { buildLookmlGraph } from '../../../../../src/context/ingest/adapters/lookml/graph.js';
import type { ParsedLookmlProject } from '../../../../../src/context/ingest/adapters/lookml/parse.js';
2026-05-10 23:12:26 +02:00
type LooseParsedLookmlProject = Omit<Partial<ParsedLookmlProject>, 'models' | 'views'> & {
models?: Array<Omit<ParsedLookmlProject['models'][number], 'connectionName'> & { connectionName?: string | null }>;
views?: Array<Omit<ParsedLookmlProject['views'][number], 'rawSqlTableName'> & { rawSqlTableName?: string | null }>;
};
const mkProject = (overrides: LooseParsedLookmlProject): ParsedLookmlProject => ({
dashboards: [],
allPaths: [],
...overrides,
models: (overrides.models ?? []).map((model) => ({ connectionName: null, ...model })),
views: (overrides.views ?? []).map((view) => ({ rawSqlTableName: null, ...view })),
});
describe('buildLookmlGraph', () => {
it('assigns a single model as owner of all its included views', () => {
const project = mkProject({
models: [{ path: 'orders.model.lkml', name: 'orders', includes: ['views/*.view.lkml'], explores: ['orders'] }],
views: [
{ path: 'views/orders.view.lkml', name: 'orders', extendsFrom: [] },
{ path: 'views/customers.view.lkml', name: 'customers', extendsFrom: [] },
],
allPaths: ['orders.model.lkml', 'views/customers.view.lkml', 'views/orders.view.lkml'],
});
const graph = buildLookmlGraph(project);
expect(graph.ownerByViewPath.get('views/orders.view.lkml')).toBe('orders');
expect(graph.ownerByViewPath.get('views/customers.view.lkml')).toBe('orders');
expect(graph.viewsIncludedByModel.get('orders')?.sort()).toEqual([
'views/customers.view.lkml',
'views/orders.view.lkml',
]);
});
it('assigns shared views to the lexicographically-first model that includes them', () => {
const project = mkProject({
models: [
{ path: 'marketing.model.lkml', name: 'marketing', includes: ['views/shared.view.lkml'], explores: [] },
{
path: 'orders.model.lkml',
name: 'orders',
includes: ['views/shared.view.lkml', 'views/orders.view.lkml'],
explores: [],
},
],
views: [
{ path: 'views/shared.view.lkml', name: 'shared', extendsFrom: [] },
{ path: 'views/orders.view.lkml', name: 'orders', extendsFrom: [] },
],
allPaths: ['marketing.model.lkml', 'orders.model.lkml', 'views/orders.view.lkml', 'views/shared.view.lkml'],
});
const graph = buildLookmlGraph(project);
// "marketing" sorts before "orders", so marketing owns the shared view.
expect(graph.ownerByViewPath.get('views/shared.view.lkml')).toBe('marketing');
expect(graph.ownerByViewPath.get('views/orders.view.lkml')).toBe('orders');
// Both models list the shared view in their include set:
expect(graph.includersByViewPath.get('views/shared.view.lkml')?.sort()).toEqual(['marketing', 'orders']);
});
it('resolves transitive extends chains into dependency paths', () => {
const project = mkProject({
models: [{ path: 'orders.model.lkml', name: 'orders', includes: ['views/*.view.lkml'], explores: [] }],
views: [
{ path: 'views/base.view.lkml', name: 'base', extendsFrom: [] },
{ path: 'views/orders.view.lkml', name: 'orders', extendsFrom: ['base'] },
{ path: 'views/orders_ext.view.lkml', name: 'orders_ext', extendsFrom: ['orders'] },
],
allPaths: ['orders.model.lkml', 'views/base.view.lkml', 'views/orders.view.lkml', 'views/orders_ext.view.lkml'],
});
const graph = buildLookmlGraph(project);
expect(graph.extendsAncestorsByViewName.get('orders_ext')?.sort()).toEqual(['base', 'orders']);
expect(graph.extendsAncestorsByViewName.get('orders')?.sort()).toEqual(['base']);
expect(graph.extendsAncestorsByViewName.get('base')?.sort()).toEqual([]);
});
it('resolves glob-style include patterns (views/*.view.lkml) against allPaths', () => {
const project = mkProject({
models: [{ path: 'orders.model.lkml', name: 'orders', includes: ['views/*.view.lkml'], explores: [] }],
views: [
{ path: 'views/a.view.lkml', name: 'a', extendsFrom: [] },
{ path: 'views/sub/b.view.lkml', name: 'b', extendsFrom: [] },
],
allPaths: ['orders.model.lkml', 'views/a.view.lkml', 'views/sub/b.view.lkml'],
});
const graph = buildLookmlGraph(project);
// Single-star glob matches one path segment — "views/sub/b.view.lkml" is NOT matched.
expect(graph.viewsIncludedByModel.get('orders')?.sort()).toEqual(['views/a.view.lkml']);
});
it('resolves double-star include patterns (views/**/*.view.lkml) recursively', () => {
const project = mkProject({
models: [{ path: 'orders.model.lkml', name: 'orders', includes: ['views/**/*.view.lkml'], explores: [] }],
views: [
{ path: 'views/a.view.lkml', name: 'a', extendsFrom: [] },
{ path: 'views/sub/b.view.lkml', name: 'b', extendsFrom: [] },
],
allPaths: ['orders.model.lkml', 'views/a.view.lkml', 'views/sub/b.view.lkml'],
});
const graph = buildLookmlGraph(project);
expect(graph.viewsIncludedByModel.get('orders')?.sort()).toEqual(['views/a.view.lkml', 'views/sub/b.view.lkml']);
});
it('leaves a view ownerless when no model includes it', () => {
const project = mkProject({
models: [{ path: 'other.model.lkml', name: 'other', includes: ['views/included.view.lkml'], explores: [] }],
views: [
{ path: 'views/included.view.lkml', name: 'included', extendsFrom: [] },
{ path: 'views/orphan.view.lkml', name: 'orphan', extendsFrom: [] },
],
allPaths: ['other.model.lkml', 'views/included.view.lkml', 'views/orphan.view.lkml'],
});
const graph = buildLookmlGraph(project);
expect(graph.ownerByViewPath.has('views/orphan.view.lkml')).toBe(false);
expect(graph.ownerByViewPath.get('views/included.view.lkml')).toBe('other');
});
});