2026-05-22 18:18:47 +02:00
|
|
|
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
|
|
|
|
import { tmpdir } from 'node:os';
|
|
|
|
|
import { join } from 'node:path';
|
|
|
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
|
|
test: split cli tests from source tree (#216)
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
2026-05-26 08:49:05 +02:00
|
|
|
import { runCommanderKtxCli } from '../src/cli-program.js';
|
|
|
|
|
import type { KtxCliDeps, KtxCliIo, KtxCliPackageInfo } from '../src/cli-runtime.js';
|
2026-05-31 23:44:33 +02:00
|
|
|
import { TELEMETRY_NOTICE } from '../src/telemetry/identity.js';
|
2026-05-22 18:18:47 +02:00
|
|
|
|
|
|
|
|
function makeIo(stdoutIsTTY = true): { io: KtxCliIo; stdout: () => string; stderr: () => string } {
|
|
|
|
|
let stdout = '';
|
|
|
|
|
let stderr = '';
|
|
|
|
|
return {
|
|
|
|
|
io: {
|
|
|
|
|
stdout: {
|
|
|
|
|
isTTY: stdoutIsTTY,
|
|
|
|
|
write: (chunk) => {
|
|
|
|
|
stdout += chunk;
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
stderr: {
|
|
|
|
|
write: (chunk) => {
|
|
|
|
|
stderr += chunk;
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
stdout: () => stdout,
|
|
|
|
|
stderr: () => stderr,
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const info: KtxCliPackageInfo = { name: '@kaelio/ktx', version: '0.4.1' };
|
|
|
|
|
|
|
|
|
|
describe('runCommanderKtxCli telemetry', () => {
|
|
|
|
|
let tempDir: string;
|
|
|
|
|
const originalEnv = process.env;
|
|
|
|
|
|
|
|
|
|
beforeEach(async () => {
|
|
|
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-cli-telemetry-'));
|
|
|
|
|
await writeFile(join(tempDir, 'ktx.yaml'), '{}\n', 'utf-8');
|
|
|
|
|
vi.stubEnv('KTX_TELEMETRY_DEBUG', '1');
|
|
|
|
|
vi.stubEnv('HOME', tempDir);
|
|
|
|
|
vi.stubEnv('CI', '');
|
|
|
|
|
vi.stubEnv('KTX_TELEMETRY_DISABLED', '');
|
|
|
|
|
vi.stubEnv('DO_NOT_TRACK', '');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
afterEach(async () => {
|
|
|
|
|
vi.unstubAllEnvs();
|
|
|
|
|
process.env = originalEnv;
|
|
|
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('emits debug command telemetry for registered actions', async () => {
|
|
|
|
|
const io = makeIo(true);
|
|
|
|
|
await expect(
|
|
|
|
|
runCommanderKtxCli(
|
|
|
|
|
['--project-dir', tempDir, 'status', '--help'],
|
|
|
|
|
io.io,
|
|
|
|
|
{},
|
|
|
|
|
info,
|
|
|
|
|
{ runInit: async () => 0 },
|
|
|
|
|
),
|
|
|
|
|
).resolves.toBe(0);
|
|
|
|
|
|
|
|
|
|
expect(io.stderr()).not.toContain('[telemetry]');
|
|
|
|
|
|
|
|
|
|
const statusIo = makeIo(true);
|
|
|
|
|
const deps: KtxCliDeps = { doctor: async () => 0 };
|
|
|
|
|
|
|
|
|
|
await expect(
|
|
|
|
|
runCommanderKtxCli(
|
|
|
|
|
['--project-dir', tempDir, 'status', '--json'],
|
|
|
|
|
statusIo.io,
|
|
|
|
|
deps,
|
|
|
|
|
info,
|
|
|
|
|
{ runInit: async () => 0 },
|
|
|
|
|
),
|
|
|
|
|
).resolves.toBe(0);
|
|
|
|
|
|
|
|
|
|
expect(statusIo.stderr()).toContain('[telemetry]');
|
|
|
|
|
expect(statusIo.stderr()).toContain('"event":"install_first_run"');
|
|
|
|
|
expect(statusIo.stderr()).toContain('"event":"command"');
|
|
|
|
|
expect(statusIo.stderr()).toContain('"commandPath":["ktx","status"]');
|
|
|
|
|
expect(statusIo.stderr()).toContain('"event":"project_stack_snapshot"');
|
|
|
|
|
expect(statusIo.stderr()).toContain('"connectionCount"');
|
|
|
|
|
expect(statusIo.stderr()).not.toContain(tempDir);
|
|
|
|
|
|
2026-05-31 23:44:33 +02:00
|
|
|
const noticeIndex = statusIo.stderr().indexOf(TELEMETRY_NOTICE);
|
2026-05-22 18:18:47 +02:00
|
|
|
const firstTelemetryIndex = statusIo.stderr().indexOf('[telemetry]');
|
|
|
|
|
expect(noticeIndex).toBeGreaterThanOrEqual(0);
|
|
|
|
|
expect(firstTelemetryIndex).toBeGreaterThan(noticeIndex);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('emits aborted telemetry when project validation aborts after preAction starts', async () => {
|
|
|
|
|
const missingProjectDir = join(tempDir, 'missing');
|
|
|
|
|
await mkdir(missingProjectDir, { recursive: true });
|
|
|
|
|
const io = makeIo(true);
|
|
|
|
|
|
|
|
|
|
await expect(
|
|
|
|
|
runCommanderKtxCli(
|
|
|
|
|
['--project-dir', missingProjectDir, 'connection'],
|
|
|
|
|
io.io,
|
|
|
|
|
{},
|
|
|
|
|
info,
|
|
|
|
|
{ runInit: async () => 0 },
|
|
|
|
|
),
|
|
|
|
|
).resolves.toBe(1);
|
|
|
|
|
|
|
|
|
|
expect(io.stderr()).toContain('[telemetry]');
|
|
|
|
|
expect(io.stderr()).toContain('"outcome":"aborted"');
|
|
|
|
|
expect(io.stderr()).toContain('"hasProject":false');
|
|
|
|
|
expect(io.stderr()).toContain('"projectGroupAttached":false');
|
|
|
|
|
expect(io.stderr()).not.toContain(missingProjectDir);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('does not import or emit telemetry for help, version, bare non-TTY, or unknown top-level command', async () => {
|
|
|
|
|
const helpIo = makeIo(true);
|
|
|
|
|
await expect(runCommanderKtxCli(['--help'], helpIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
|
|
|
expect(helpIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
|
|
|
|
|
|
const versionIo = makeIo(true);
|
|
|
|
|
await expect(runCommanderKtxCli(['--version'], versionIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
|
|
|
expect(versionIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
|
|
|
|
|
|
const bareIo = makeIo(false);
|
|
|
|
|
await expect(runCommanderKtxCli([], bareIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
|
|
|
expect(bareIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
|
|
|
|
|
|
const unknownIo = makeIo(true);
|
|
|
|
|
await expect(runCommanderKtxCli(['unknown'], unknownIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(1);
|
|
|
|
|
expect(unknownIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
|
});
|
|
|
|
|
});
|