From 2e5b0442335a626f0a8b13a6125f096591982edd Mon Sep 17 00:00:00 2001 From: dannyward630 Date: Sat, 13 Jun 2026 12:57:40 +0200 Subject: [PATCH 1/2] test: cover macOS in the unit matrix --- .github/workflows/tests.yml | 2 +- tests/test_download.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index de0c00c..f98e3aa 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest] + os: [ubuntu-latest, windows-latest, macos-15, macos-15-intel] python: ["3.11", "3.12"] steps: diff --git a/tests/test_download.py b/tests/test_download.py index e4159ca..af07b77 100644 --- a/tests/test_download.py +++ b/tests/test_download.py @@ -321,6 +321,8 @@ def test_ensure_binary_accepts_binary_mode_checksums(tmp_path, monkeypatch): # Force the platform branch the test mocks: monkeypatch.setattr("sys.platform", "win32") + import platform + monkeypatch.setattr(platform, "machine", lambda: "AMD64") out = ensure_binary() # No RuntimeError means the parser accepted the `*`-prefixed key. assert out.exists() From 524a5e8a6159913e4b8a92f493ec69cff407211f Mon Sep 17 00:00:00 2001 From: dannyward630 Date: Sat, 13 Jun 2026 12:57:40 +0200 Subject: [PATCH 2/2] docs: mark macOS supported in issue forms --- .github/ISSUE_TEMPLATE/01-launch-failure.yml | 3 ++- .github/ISSUE_TEMPLATE/02-site-or-action-bug.yml | 5 +++-- .github/ISSUE_TEMPLATE/03-stealth-detection.yml | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/01-launch-failure.yml b/.github/ISSUE_TEMPLATE/01-launch-failure.yml index 2c5451f..a7d5a7c 100644 --- a/.github/ISSUE_TEMPLATE/01-launch-failure.yml +++ b/.github/ISSUE_TEMPLATE/01-launch-failure.yml @@ -25,7 +25,8 @@ body: options: - Windows 10/11 x86_64 - Linux x86_64 - - macOS (unsupported) + - macOS arm64 + - macOS x86_64 - Other validations: required: true diff --git a/.github/ISSUE_TEMPLATE/02-site-or-action-bug.yml b/.github/ISSUE_TEMPLATE/02-site-or-action-bug.yml index 6c38de6..cdc772a 100644 --- a/.github/ISSUE_TEMPLATE/02-site-or-action-bug.yml +++ b/.github/ISSUE_TEMPLATE/02-site-or-action-bug.yml @@ -26,7 +26,8 @@ body: options: - Windows 10/11 x86_64 - Linux x86_64 - - macOS (unsupported) + - macOS arm64 + - macOS x86_64 - Other validations: required: true @@ -43,7 +44,7 @@ body: id: headless attributes: label: headless= - description: Some bugs only repro on Windows headless=True (hidden alt-desktop path). + description: Some bugs only repro with headless=True (hidden-window path on Windows/macOS, Xvfb on Linux). options: - "True" - "False" diff --git a/.github/ISSUE_TEMPLATE/03-stealth-detection.yml b/.github/ISSUE_TEMPLATE/03-stealth-detection.yml index b2c5e1d..25d3b4f 100644 --- a/.github/ISSUE_TEMPLATE/03-stealth-detection.yml +++ b/.github/ISSUE_TEMPLATE/03-stealth-detection.yml @@ -25,7 +25,8 @@ body: options: - Windows 10/11 x86_64 - Linux x86_64 - - macOS (unsupported) + - macOS arm64 + - macOS x86_64 - Other validations: required: true